New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 846276 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Web downloading stops at 68% of its progress

Reported by smcsas...@gmail.com, May 24 2018

Issue description

Steps to reproduce the problem:
[*Step-by-step Instruction]

1. Opens Chrome on UE and accesses to the http server.
2. Downloads 3GB file from the server.

[*Reproducibility]
3/3(100%)

What is the expected behavior?
At step2, the downloading completes without any interruption.

What went wrong?
[*Actual Result]
At step2, the downloading stops at 68% of its progress.

WebStore page: 

Did this work before? Yes Chrome-64.0.3282.137

Chrome version: 66.0.3359.181  Channel: stable
OS Version: 8.1
Flash Version:
 
Labels: Needs-triage-Mobile

Comment 2 by smcsas...@gmail.com, May 25 2018

issue is observed in xperia devices and also in pixel download doesnot complete for files more than 3GB, Can please let us know if there is any data download restriction
Cc: sandeepkumars@chromium.org
Components: -Webstore UI>Browser>Downloads
Labels: Needs-Feedback Triaged-Mobile
@smcsasnew: Thanks for the report!!

Could you please help us with a sample URL where you're seeing this issue?

Thanks!! 

Comment 4 by smcsas...@gmail.com, May 28 2018

i tried to download 3.8GB file from 
https://prodesigntools.com/adobe-cc-2018-dirsct-download-links.html

Checked this issue in Nexus also with latest Chrome issue is reproduced,Downloaded is getting paused at certain percentage everytime, I tried to uninstall updates of chrome with chrome version 61 issue is not reproduced Download completed
Project Member

Comment 5 by sheriffbot@chromium.org, May 28 2018

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Owner: qin...@chromium.org
Status: Assigned (was: Unconfirmed)

Comment 7 by qin...@chromium.org, May 31 2018

is it possible to resume the download after it is paused?
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9f43dc800c3fa3ba5acfeac80addc22d492d641

commit e9f43dc800c3fa3ba5acfeac80addc22d492d641
Author: Min Qin <qinmin@chromium.org>
Date: Sat Jun 02 00:58:19 2018

use pwrite64() instead of pwrite() when writing to file on Android

The issue was fixed in https://chromium-review.googlesource.com/578290
But was reintroduced by https://chromium-review.googlesource.com/834609.
This CL changes File::Write() to always use pwrite64 on Android.

The offset param for File::Write() is int64_t.
However, pwrite() takes a signed integer for offset.
As a result, File::Write() will not work for offset larger than 2GB.
Change to pwrite64() so it will work on 32bit legacy systems.
This issue is not present on Linux because __USE_FILE_OFFSET64 is set.

BUG= 846276 

Change-Id: Ie4fcc4749e9a04c691f61a0477feaf0fa1806923
Reviewed-on: https://chromium-review.googlesource.com/1081608
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563891}
[modify] https://crrev.com/e9f43dc800c3fa3ba5acfeac80addc22d492d641/base/files/file_posix.cc
[modify] https://crrev.com/e9f43dc800c3fa3ba5acfeac80addc22d492d641/base/files/file_unittest.cc

Labels: -Pri-2 -Arch-x86_64 Merge-Request-68 Arch-ARM Pri-1
Status: Started (was: Assigned)
Issue 849354 has been merged into this issue.
Project Member

Comment 12 by sheriffbot@chromium.org, Jun 5 2018

Labels: -Merge-Request-68 Hotlist-Merge-Approved Merge-Approved-68
Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
for #11, looks like the windows has very poor support on sparse file. The passing test took 183 seconds.
Project Member

Comment 14 by bugdroid1@chromium.org, Jun 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a63776a6187ea9b7356f56c5eeed5b53a3716765

commit a63776a6187ea9b7356f56c5eeed5b53a3716765
Author: Min Qin <qinmin@chromium.org>
Date: Tue Jun 05 20:46:33 2018

Mark FileTest::WriteDataToLargeOffset as flaky on windows

Windows seem to have a poor sparse file support.
The test took about 180 seconds to pass, and sometimes it times out.

BUG= 846276 

Change-Id: I9899c6025e938f38e5079f4ef6da53fcffa1709d
Reviewed-on: https://chromium-review.googlesource.com/1087591
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564655}
[modify] https://crrev.com/a63776a6187ea9b7356f56c5eeed5b53a3716765/base/files/file_unittest.cc

Project Member

Comment 15 by bugdroid1@chromium.org, Jun 6 2018

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f26c06a764b7e4475ba825425cdf7381848f7ea3

commit f26c06a764b7e4475ba825425cdf7381848f7ea3
Author: Min Qin <qinmin@chromium.org>
Date: Wed Jun 06 06:55:22 2018

use pwrite64() instead of pwrite() when writing to file on Android

The issue was fixed in https://chromium-review.googlesource.com/578290
But was reintroduced by https://chromium-review.googlesource.com/834609.
This CL changes File::Write() to always use pwrite64 on Android.

The offset param for File::Write() is int64_t.
However, pwrite() takes a signed integer for offset.
As a result, File::Write() will not work for offset larger than 2GB.
Change to pwrite64() so it will work on 32bit legacy systems.
This issue is not present on Linux because __USE_FILE_OFFSET64 is set.

BUG= 846276 

Change-Id: Ie4fcc4749e9a04c691f61a0477feaf0fa1806923
Reviewed-on: https://chromium-review.googlesource.com/1081608
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#563891}(cherry picked from commit e9f43dc800c3fa3ba5acfeac80addc22d492d641)
Reviewed-on: https://chromium-review.googlesource.com/1088406
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#207}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/f26c06a764b7e4475ba825425cdf7381848f7ea3/base/files/file_posix.cc
[modify] https://crrev.com/f26c06a764b7e4475ba825425cdf7381848f7ea3/base/files/file_unittest.cc

Project Member

Comment 16 by bugdroid1@chromium.org, Jun 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/243eea5e9018942e5333515689d612d612a399f5

commit 243eea5e9018942e5333515689d612d612a399f5
Author: Min Qin <qinmin@chromium.org>
Date: Wed Jun 06 06:56:11 2018

Mark FileTest::WriteDataToLargeOffset as flaky on windows

Windows seem to have a poor sparse file support.
The test took about 180 seconds to pass, and sometimes it times out.

BUG= 846276 

Change-Id: I9899c6025e938f38e5079f4ef6da53fcffa1709d
Reviewed-on: https://chromium-review.googlesource.com/1087591
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#564655}(cherry picked from commit a63776a6187ea9b7356f56c5eeed5b53a3716765)
Reviewed-on: https://chromium-review.googlesource.com/1088407
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#208}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/243eea5e9018942e5333515689d612d612a399f5/base/files/file_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment