New issue
Advanced search Search tips

Issue 846270 link

Starred by 3 users
Status: Fixed
Owner:
grunell@chromium.org
Closed: May 2018
Cc:
guidou@chromium.org
ossu@chromium.org
solenberg@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac , Fuchsia
Pri: 2
Type: Feature



Sign in to add a comment

Add echo canceller type constraint

Project Member Reported by grunell@chromium.org, May 24 2018 
Add a proposed echo canceller type constraint available under the existing origin trial for experimental echo cancellation.

* Add this to MediaTrackConstraints and MediaTrackSettings.
* Let the origin trial control exposure of the constraint instead of controlling the echo canceller type directly.
* Let the constraint control the echo canceller type.
Project Member

Comment 2 by bugdroid1@chromium.org, May 25 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b117c3ea89ca8946a33cb189eb2248876703062d

commit b117c3ea89ca8946a33cb189eb2248876703062d
Author: Henrik Grunell <grunell@chromium.org>
Date: Fri May 25 08:02:29 2018

Add experimental echo canceller type constraint to blink interface.

Also copy it to Chrome.

blink-dev discussion: https://groups.google.com/a/chromium.org/d/topic/blink-dev/ZvL_BhJjXGQ/discussion

Bug:  846270 
Change-Id: I75fb55a8e71a5b8ae5afb33eb3cd617f88f82f27
Reviewed-on: https://chromium-review.googlesource.com/1071427
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561806}
[modify] https://crrev.com/b117c3ea89ca8946a33cb189eb2248876703062d/third_party/blink/public/platform/web_media_constraints.h
[modify] https://crrev.com/b117c3ea89ca8946a33cb189eb2248876703062d/third_party/blink/renderer/modules/mediastream/media_constraints_impl.cc
[modify] https://crrev.com/b117c3ea89ca8946a33cb189eb2248876703062d/third_party/blink/renderer/modules/mediastream/media_track_constraint_set.idl
[modify] https://crrev.com/b117c3ea89ca8946a33cb189eb2248876703062d/third_party/blink/renderer/modules/mediastream/media_track_supported_constraints.idl
[modify] https://crrev.com/b117c3ea89ca8946a33cb189eb2248876703062d/third_party/blink/renderer/platform/exported/web_media_constraints.cc
Project Member

Comment 3 by bugdroid1@chromium.org, May 30 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbabe1803f0206acd8dbba4475b30148e803554e

commit cbabe1803f0206acd8dbba4475b30148e803554e
Author: Henrik Grunell <grunell@chromium.org>
Date: Wed May 30 08:24:30 2018

Add support for conditional constraint for echo canceller type.

* Change controlling of the type from existing origin trial to constraint.
* Instead control exposure of constraint by existing origin trial.

Bug:  846270 
Change-Id: Ia95b7384b284e93b887e4b57bf66e9b617171f84
Reviewed-on: https://chromium-review.googlesource.com/1070163
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562761}
[modify] https://crrev.com/cbabe1803f0206acd8dbba4475b30148e803554e/content/renderer/media/stream/media_stream_audio_processor_options.h
[modify] https://crrev.com/cbabe1803f0206acd8dbba4475b30148e803554e/content/renderer/media/stream/media_stream_constraints_util_audio.cc
[modify] https://crrev.com/cbabe1803f0206acd8dbba4475b30148e803554e/content/renderer/media/stream/media_stream_constraints_util_audio.h
[modify] https://crrev.com/cbabe1803f0206acd8dbba4475b30148e803554e/content/renderer/media/stream/media_stream_constraints_util_audio_unittest.cc
[modify] https://crrev.com/cbabe1803f0206acd8dbba4475b30148e803554e/content/renderer/media/stream/user_media_processor.cc
[modify] https://crrev.com/cbabe1803f0206acd8dbba4475b30148e803554e/third_party/blink/public/web/web_user_media_request.h
[modify] https://crrev.com/cbabe1803f0206acd8dbba4475b30148e803554e/third_party/blink/renderer/modules/exported/web_user_media_request.cc
[modify] https://crrev.com/cbabe1803f0206acd8dbba4475b30148e803554e/third_party/blink/renderer/modules/mediastream/user_media_request.cc
[modify] https://crrev.com/cbabe1803f0206acd8dbba4475b30148e803554e/third_party/blink/renderer/modules/mediastream/user_media_request.h

Comment 4 by grunell@chromium.org, May 31 2018

Labels: M-68 Merge-Request-68
Status: Fixed (was: Started)

Comment 5 by ossu@chromium.org, May 31 2018

Labels: -Merge-Request-68
Just realized we need to change the behavior in #3 slightly. Removing merge-request flag for now.
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a55cf339e3b84e8f7c39f69d33d500ea30878d0

commit 7a55cf339e3b84e8f7c39f69d33d500ea30878d0
Author: Henrik Grunell <grunell@chromium.org>
Date: Fri Jun 01 11:26:50 2018

Support for echo cancellation type in MediaStreamTrack.getCapabilities.

Bug:  846270 
Change-Id: I14da18e8412d420bfdff9742da157dee12e83886
Reviewed-on: https://chromium-review.googlesource.com/1079867
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563594}
[modify] https://crrev.com/7a55cf339e3b84e8f7c39f69d33d500ea30878d0/content/renderer/media/stream/media_stream_constraints_util_audio.cc
[modify] https://crrev.com/7a55cf339e3b84e8f7c39f69d33d500ea30878d0/content/renderer/media/stream/user_media_processor.cc
[modify] https://crrev.com/7a55cf339e3b84e8f7c39f69d33d500ea30878d0/third_party/WebKit/LayoutTests/fast/mediastream/MediaStreamTrack-getCapabilities.html
[modify] https://crrev.com/7a55cf339e3b84e8f7c39f69d33d500ea30878d0/third_party/blink/public/platform/web_media_constraints.h
[modify] https://crrev.com/7a55cf339e3b84e8f7c39f69d33d500ea30878d0/third_party/blink/public/platform/web_media_stream_source.h
[modify] https://crrev.com/7a55cf339e3b84e8f7c39f69d33d500ea30878d0/third_party/blink/renderer/modules/mediastream/media_stream_track.cc
[modify] https://crrev.com/7a55cf339e3b84e8f7c39f69d33d500ea30878d0/third_party/blink/renderer/modules/mediastream/media_track_capabilities.idl
[modify] https://crrev.com/7a55cf339e3b84e8f7c39f69d33d500ea30878d0/third_party/blink/renderer/platform/exported/web_media_constraints.cc
Project Member

Comment 8 by bugdroid1@chromium.org, Jun 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e4f65bddf5658e78aa6e0ccbb8163fad4a9f77b4

commit e4f65bddf5658e78aa6e0ccbb8163fad4a9f77b4
Author: Oskar Sundbom <ossu@chromium.org>
Date: Tue Jun 05 18:19:21 2018

Add getSettings support for echoCancellationType

Bug:  846270 
Change-Id: Iaae204f95e3da9304915ee5f118a7ea3a0b1bdec
Reviewed-on: https://chromium-review.googlesource.com/1079388
Commit-Queue: Oskar Sundbom <ossu@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564583}
[modify] https://crrev.com/e4f65bddf5658e78aa6e0ccbb8163fad4a9f77b4/content/renderer/media/stream/user_media_processor.cc
[modify] https://crrev.com/e4f65bddf5658e78aa6e0ccbb8163fad4a9f77b4/third_party/WebKit/LayoutTests/fast/mediastream/MediaStreamTrack-getSettings.html
[modify] https://crrev.com/e4f65bddf5658e78aa6e0ccbb8163fad4a9f77b4/third_party/blink/public/platform/web_media_stream_source.h
[modify] https://crrev.com/e4f65bddf5658e78aa6e0ccbb8163fad4a9f77b4/third_party/blink/public/platform/web_media_stream_track.h
[modify] https://crrev.com/e4f65bddf5658e78aa6e0ccbb8163fad4a9f77b4/third_party/blink/renderer/modules/mediastream/media_stream_track.cc
[modify] https://crrev.com/e4f65bddf5658e78aa6e0ccbb8163fad4a9f77b4/third_party/blink/renderer/modules/mediastream/media_track_settings.idl
[modify] https://crrev.com/e4f65bddf5658e78aa6e0ccbb8163fad4a9f77b4/third_party/blink/renderer/platform/exported/web_media_stream_source.cc
[modify] https://crrev.com/e4f65bddf5658e78aa6e0ccbb8163fad4a9f77b4/third_party/blink/renderer/platform/mediastream/media_stream_source.cc
[modify] https://crrev.com/e4f65bddf5658e78aa6e0ccbb8163fad4a9f77b4/third_party/blink/renderer/platform/mediastream/media_stream_source.h

Comment 9 by grunell@chromium.org, Jun 11 2018

Labels: Merge-Request-68
Project Member

Comment 10 by sheriffbot@chromium.org, Jun 11 2018

Labels: -Merge-Request-68 Merge-Reject-68 Hotlist-Merge-Reject
The bug is marked as P3 or Feature. It should not be merged as M68 is in beta. 
Please contact the approriate milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 11 by abdulsyed@google.com, Jun 11 2018

Labels: -Merge-Reject-68 Merge-Approved-68
Discussed this offline; it's behind an origin trial flag. Approving it for M68. Branch:3440
Project Member

Comment 12 by bugdroid1@chromium.org, Jun 12 2018

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f6bba419411be6367a2560d8ed7a94bc04c1dde4

commit f6bba419411be6367a2560d8ed7a94bc04c1dde4
Author: Henrik Grunell <grunell@chromium.org>
Date: Tue Jun 12 09:32:00 2018

Add experimental echo canceller type constraint to blink interface.

Also copy it to Chrome.

blink-dev discussion: https://groups.google.com/a/chromium.org/d/topic/blink-dev/ZvL_BhJjXGQ/discussion

Bug:  846270 
Change-Id: I75fb55a8e71a5b8ae5afb33eb3cd617f88f82f27
Reviewed-on: https://chromium-review.googlesource.com/1071427
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#561806}(cherry picked from commit b117c3ea89ca8946a33cb189eb2248876703062d)
Reviewed-on: https://chromium-review.googlesource.com/1096955
Reviewed-by: Henrik Grunell <grunell@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#294}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/f6bba419411be6367a2560d8ed7a94bc04c1dde4/third_party/blink/public/platform/web_media_constraints.h
[modify] https://crrev.com/f6bba419411be6367a2560d8ed7a94bc04c1dde4/third_party/blink/renderer/modules/mediastream/media_constraints_impl.cc
[modify] https://crrev.com/f6bba419411be6367a2560d8ed7a94bc04c1dde4/third_party/blink/renderer/modules/mediastream/media_track_constraint_set.idl
[modify] https://crrev.com/f6bba419411be6367a2560d8ed7a94bc04c1dde4/third_party/blink/renderer/modules/mediastream/media_track_supported_constraints.idl
[modify] https://crrev.com/f6bba419411be6367a2560d8ed7a94bc04c1dde4/third_party/blink/renderer/platform/exported/web_media_constraints.cc
Project Member

Comment 13 by bugdroid1@chromium.org, Jun 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8639e48c71413599b63c770ad1b3509917df9044

commit 8639e48c71413599b63c770ad1b3509917df9044
Author: Henrik Grunell <grunell@chromium.org>
Date: Tue Jun 12 09:33:58 2018

Add support for conditional constraint for echo canceller type.

* Change controlling of the type from existing origin trial to constraint.
* Instead control exposure of constraint by existing origin trial.

Bug:  846270 
Change-Id: Ia95b7384b284e93b887e4b57bf66e9b617171f84
Reviewed-on: https://chromium-review.googlesource.com/1070163
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#562761}(cherry picked from commit cbabe1803f0206acd8dbba4475b30148e803554e)
Reviewed-on: https://chromium-review.googlesource.com/1096956
Reviewed-by: Henrik Grunell <grunell@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#295}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/8639e48c71413599b63c770ad1b3509917df9044/content/renderer/media/stream/media_stream_audio_processor_options.h
[modify] https://crrev.com/8639e48c71413599b63c770ad1b3509917df9044/content/renderer/media/stream/media_stream_constraints_util_audio.cc
[modify] https://crrev.com/8639e48c71413599b63c770ad1b3509917df9044/content/renderer/media/stream/media_stream_constraints_util_audio.h
[modify] https://crrev.com/8639e48c71413599b63c770ad1b3509917df9044/content/renderer/media/stream/media_stream_constraints_util_audio_unittest.cc
[modify] https://crrev.com/8639e48c71413599b63c770ad1b3509917df9044/content/renderer/media/stream/user_media_processor.cc
[modify] https://crrev.com/8639e48c71413599b63c770ad1b3509917df9044/third_party/blink/public/web/web_user_media_request.h
[modify] https://crrev.com/8639e48c71413599b63c770ad1b3509917df9044/third_party/blink/renderer/modules/exported/web_user_media_request.cc
[modify] https://crrev.com/8639e48c71413599b63c770ad1b3509917df9044/third_party/blink/renderer/modules/mediastream/user_media_request.cc
[modify] https://crrev.com/8639e48c71413599b63c770ad1b3509917df9044/third_party/blink/renderer/modules/mediastream/user_media_request.h
Project Member

Comment 14 by bugdroid1@chromium.org, Jun 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db3570f2eb446fadb71bccc8674c11cf03d34471

commit db3570f2eb446fadb71bccc8674c11cf03d34471
Author: Henrik Grunell <grunell@chromium.org>
Date: Tue Jun 12 09:34:54 2018

Support for echo cancellation type in MediaStreamTrack.getCapabilities.

Bug:  846270 
Change-Id: I14da18e8412d420bfdff9742da157dee12e83886
Reviewed-on: https://chromium-review.googlesource.com/1079867
Commit-Queue: Henrik Grunell <grunell@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#563594}(cherry picked from commit 7a55cf339e3b84e8f7c39f69d33d500ea30878d0)
Reviewed-on: https://chromium-review.googlesource.com/1096975
Reviewed-by: Henrik Grunell <grunell@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#296}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/db3570f2eb446fadb71bccc8674c11cf03d34471/content/renderer/media/stream/media_stream_constraints_util_audio.cc
[modify] https://crrev.com/db3570f2eb446fadb71bccc8674c11cf03d34471/content/renderer/media/stream/user_media_processor.cc
[modify] https://crrev.com/db3570f2eb446fadb71bccc8674c11cf03d34471/third_party/WebKit/LayoutTests/fast/mediastream/MediaStreamTrack-getCapabilities.html
[modify] https://crrev.com/db3570f2eb446fadb71bccc8674c11cf03d34471/third_party/blink/public/platform/web_media_constraints.h
[modify] https://crrev.com/db3570f2eb446fadb71bccc8674c11cf03d34471/third_party/blink/public/platform/web_media_stream_source.h
[modify] https://crrev.com/db3570f2eb446fadb71bccc8674c11cf03d34471/third_party/blink/renderer/modules/mediastream/media_stream_track.cc
[modify] https://crrev.com/db3570f2eb446fadb71bccc8674c11cf03d34471/third_party/blink/renderer/modules/mediastream/media_track_capabilities.idl
[modify] https://crrev.com/db3570f2eb446fadb71bccc8674c11cf03d34471/third_party/blink/renderer/platform/exported/web_media_constraints.cc
Project Member

Comment 15 by bugdroid1@chromium.org, Jun 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4934c682007846bced378e9ef5d820795a96538

commit b4934c682007846bced378e9ef5d820795a96538
Author: Henrik Grunell <grunell@chromium.org>
Date: Tue Jun 12 10:31:06 2018

Make echoCancellationTypes 'system' and 'browser' mean hardware and software

TBR=ossu@chromium.org

(cherry picked from commit 0c11ef8827af184b38737ffa823dbf779a5fadaa)

Bug:  846270 
Change-Id: I8ca8bb7768cef75328e3549efb397a780dff0318
Reviewed-on: https://chromium-review.googlesource.com/1080793
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Henrik Grunell <grunell@chromium.org>
Commit-Queue: Oskar Sundbom <ossu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#564517}
Reviewed-on: https://chromium-review.googlesource.com/1096939
Cr-Commit-Position: refs/branch-heads/3440@{#298}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/b4934c682007846bced378e9ef5d820795a96538/content/renderer/media/stream/media_stream_audio_processor_options.cc
[modify] https://crrev.com/b4934c682007846bced378e9ef5d820795a96538/content/renderer/media/stream/media_stream_audio_processor_options.h
[modify] https://crrev.com/b4934c682007846bced378e9ef5d820795a96538/content/renderer/media/stream/media_stream_constraints_util_audio.cc
[modify] https://crrev.com/b4934c682007846bced378e9ef5d820795a96538/content/renderer/media/stream/media_stream_constraints_util_audio_unittest.cc
[modify] https://crrev.com/b4934c682007846bced378e9ef5d820795a96538/content/renderer/media/stream/user_media_client_impl_unittest.cc
Project Member

Comment 16 by bugdroid1@chromium.org, Jun 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/831495b28ae964db51a571f4e1abad34bd5dcdfc

commit 831495b28ae964db51a571f4e1abad34bd5dcdfc
Author: Oskar Sundbom <ossu@chromium.org>
Date: Tue Jun 12 10:45:03 2018

Add getSettings support for echoCancellationType

Bug:  846270 
Change-Id: Iaae204f95e3da9304915ee5f118a7ea3a0b1bdec
Reviewed-on: https://chromium-review.googlesource.com/1079388
Commit-Queue: Oskar Sundbom <ossu@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#564583}(cherry picked from commit e4f65bddf5658e78aa6e0ccbb8163fad4a9f77b4)
Reviewed-on: https://chromium-review.googlesource.com/1097055
Reviewed-by: Henrik Grunell <grunell@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#299}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/831495b28ae964db51a571f4e1abad34bd5dcdfc/content/renderer/media/stream/user_media_processor.cc
[modify] https://crrev.com/831495b28ae964db51a571f4e1abad34bd5dcdfc/third_party/WebKit/LayoutTests/fast/mediastream/MediaStreamTrack-getSettings.html
[modify] https://crrev.com/831495b28ae964db51a571f4e1abad34bd5dcdfc/third_party/blink/public/platform/web_media_stream_source.h
[modify] https://crrev.com/831495b28ae964db51a571f4e1abad34bd5dcdfc/third_party/blink/public/platform/web_media_stream_track.h
[modify] https://crrev.com/831495b28ae964db51a571f4e1abad34bd5dcdfc/third_party/blink/renderer/modules/mediastream/media_stream_track.cc
[modify] https://crrev.com/831495b28ae964db51a571f4e1abad34bd5dcdfc/third_party/blink/renderer/modules/mediastream/media_track_settings.idl
[modify] https://crrev.com/831495b28ae964db51a571f4e1abad34bd5dcdfc/third_party/blink/renderer/platform/exported/web_media_stream_source.cc
[modify] https://crrev.com/831495b28ae964db51a571f4e1abad34bd5dcdfc/third_party/blink/renderer/platform/mediastream/media_stream_source.cc
[modify] https://crrev.com/831495b28ae964db51a571f4e1abad34bd5dcdfc/third_party/blink/renderer/platform/mediastream/media_stream_source.h
Project Member

Comment 17 by bugdroid1@chromium.org, Jun 20 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65a07689aec111f6af8a2de242765647f95a0f09

commit 65a07689aec111f6af8a2de242765647f95a0f09
Author: Oskar Sundbom <ossu@chromium.org>
Date: Wed Jun 20 13:45:23 2018

Rename the ExperimentalHardwareEchoCancellation origin trial

Renaming it to ExperimentalHardwareEchoCancellation2, so that new
tokens don't trigger the old behaviour in older versions of Chrome.

The runtime flag retains its name, since that's user controlled.

Bug:  854577 ,  846270 
Change-Id: I577e37082ed4cd84d4e77dc6f13155a4eba49131
Reviewed-on: https://chromium-review.googlesource.com/1106338
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Oskar Sundbom <ossu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568821}
[modify] https://crrev.com/65a07689aec111f6af8a2de242765647f95a0f09/third_party/blink/renderer/platform/runtime_enabled_features.json5
Project Member

Comment 18 by bugdroid1@chromium.org, Jun 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/77ea8ef8fabc87461b67c653f12eefb0273bae80

commit 77ea8ef8fabc87461b67c653f12eefb0273bae80
Author: Oskar Sundbom <ossu@chromium.org>
Date: Wed Jun 27 07:23:12 2018

Rename the ExperimentalHardwareEchoCancellation origin trial

Renaming it to ExperimentalHardwareEchoCancellation2, so that new
tokens don't trigger the old behaviour in older versions of Chrome.

The runtime flag retains its name, since that's user controlled.

Bug:  854577 ,  846270 
Change-Id: I577e37082ed4cd84d4e77dc6f13155a4eba49131
Reviewed-on: https://chromium-review.googlesource.com/1106338
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Oskar Sundbom <ossu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#568821}(cherry picked from commit 65a07689aec111f6af8a2de242765647f95a0f09)
Reviewed-on: https://chromium-review.googlesource.com/1116578
Reviewed-by: Henrik Grunell <grunell@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#547}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/77ea8ef8fabc87461b67c653f12eefb0273bae80/third_party/blink/renderer/platform/runtime_enabled_features.json5
►

Sign in to add a comment