Regression:Cursor does not stay in the textbox after pressing backspace for pages on Print overlay
Reported by
vineetha...@etouch.net,
May 24 2018
|
|||
Issue descriptionChrome Version: 68.0.3438.3 (Official Build) Revision afd1806837c9d50e92124fb7456f12611681e652-refs/branch-heads/3438@(32/64 bit) OS: Mac(10.12.6,10.13.1), 10.13.5(Macbook Pro Touchbar), Windows(7,8,8.1,10) and Linux(14.04) OS Pre-condition: Enabled 'Enable new Print Preview UI' flag from chrome://flags What steps will reproduce the problem? (1) Launch Chrome open NTP and give print command using 'Ctrl+P'to open Print Preview overlay. (2) In Pages Section , choose the second option button and provide an invalid input(e.g: 678 or hhh) (3) Now press backspace or delete to erase all the characters entered and take cursor back to start of textbox and observe. Actual Result: Cursor does not remain in textbox and automatically first option button(with Value 'All')gets selected. Expected Result: Instead the cursor should remain in the textbox and the second option button should remain selected. This is regression issue broken in ‘M-68’ and providing the bisect using per-revision bisect, Good build: 68.0.3437.0(Revision: 560454) Bad build : 68.0.3438.0(Revision: 560883) You are probably looking for a change made after 560879 (known good), but no later than 560880 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/da7dc652f35badf004c0c7e5b7966152fddbf4d3..a7cf8ab129b7590cccd12ca0d243a93573311d37 Suspect: https://chromium.googlesource.com/chromium/src/+/a7cf8ab129b7590cccd12ca0d243a93573311d37 @rbpotter: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thank You!
,
May 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3fbc9d8705c5368646ba55cc192f3aca6f881ff5 commit 3fbc9d8705c5368646ba55cc192f3aca6f881ff5 Author: rbpotter <rbpotter@chromium.org> Date: Fri May 25 03:02:16 2018 Print Preview Componentization: Fix focus in pages again Switching the order of event firing and setting turning valid caused the input to be temporarily disabled when validity changed from false to true. Revert the previous change and depend on the errorState_ instead of pages.valid. This ensures that |disabled| will always update second. Bug: 846268 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0b4df89dc8e75fc3ba4bfc2e2018fae2aff2cf50 Reviewed-on: https://chromium-review.googlesource.com/1071827 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#561749} [modify] https://crrev.com/3fbc9d8705c5368646ba55cc192f3aca6f881ff5/chrome/browser/resources/print_preview/new/pages_settings.html [modify] https://crrev.com/3fbc9d8705c5368646ba55cc192f3aca6f881ff5/chrome/browser/resources/print_preview/new/pages_settings.js
,
May 28 2018
Update : Rechecked the above issue on Mac(10.12.6, 10.13.1, 10.13.5), Windows(7,8,8.1,10) and Linux(14.04) OS with latest Canary Chrome version #69.0.3443.0 and the issue is still reproducible. Kindly refer the attached screen cast.
,
May 29 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/314223aa3fb78b3a7de8b3d00776d9cec3a9b614 commit 314223aa3fb78b3a7de8b3d00776d9cec3a9b614 Author: rbpotter <rbpotter@chromium.org> Date: Tue May 29 22:11:45 2018 Print Preview Componentization: Update disabled for all pages inputs Bug: 846268 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id5263825fc5740d44d43fc73916473a85fb660bc Reviewed-on: https://chromium-review.googlesource.com/1076777 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#562621} [modify] https://crrev.com/314223aa3fb78b3a7de8b3d00776d9cec3a9b614/chrome/browser/resources/print_preview/new/pages_settings.html
,
May 30 2018
Update : Rechecked the above issue on Mac(10.12.6, 10.13.1, 10.13.5), Windows(7,8,8.1,10) and Linux(14.04) OS with latest Canary Chrome version #69.0.3445.0 and the issue is fixed. Kindly refer the attached screen cast for Canary behaviour.
,
Jun 2 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by rbpotter@chromium.org
, May 24 2018Status: Started (was: Assigned)