New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 846254 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Languages list is not seen completely in 'Add languages' dialog.

Reported by avsha...@etouch.net, May 24 2018

Issue description

Chrome Version : 68.0.3439.0 (Official Build) 1666e272389d5933c9d96ce25114aa327dfb9233-refs/branch-heads/3439@{#1} 64-bit
OS : Windows(7, 8, 8.1, 10)

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://settings/languages
2. Expand 'Language' section and click on 'Add languages' button.
3. Observe the  'Add languages' dialog.

Actual Result : Languages list is not seen completely in 'Add languages' dialog.

Expected Result : Languages list should appear completely in 'Add languages' dialog.

This is a regression issue, broken in M-68 and will soon update other info.
Good Build : 68.0.3438.0  (Revision : 560884) 
Bad Build : 68.0.3439.0 (Revision : 561388)
 
Actual_overlay.mp4
489 KB View Download
Expected_overlay.mp4
707 KB View Download

Comment 1 by avsha...@etouch.net, May 24 2018

Labels: RegressedIn-68 ET-MUM-Reported hasbisect FoundIn-68 Target-68 OS-Linux
Owner: aee@chromium.org
Status: Assigned (was: Unconfirmed)
(Unable to narrow down the range using per-revision bisect,hence providing bisect using old script)

This is a regression issue, broken in M-68 and below is the narrow bisect info:
Good Build : 68.0.3438.0  (Revision : 560884)
Bad Build : 68.0.3439.0 (Revision : 561388)

Narrow bisect URL :
https://chromium.googlesource.com/chromium/src/+log/dc6ff4ef543f5491073f442c1fae7928024da5eb..435dd3259184cedbb03f6f088a51181e6cb22c84

Suspecting : r561365

@Esmael : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note : 
1. Issue is also reproducible on Linux(14.04 LTS) and will update Mac(10.12.6, 10.13.1, 10.13.5) OS behaviour once build gets available.

Comment 2 by avsha...@etouch.net, May 24 2018

Labels: OS-Mac
This issue is also observed on Mac(10.12.6, 10.13.1, 10.13.5) OS
Cc: manoranj...@chromium.org
Labels: ReleaseBlock-Stable
marking as RBS, please change if required.

Comment 4 by dpa...@chromium.org, May 24 2018

I can reproduce on an optimized build only. Seems like something is tripping polymer and/or polymer-css-build to behave incorrectly.

Comment 5 by aee@chromium.org, May 24 2018

Status: Started (was: Assigned)

Comment 6 by dpa...@chromium.org, May 24 2018

Labels: Proj-MaterialDesign-Refresh-WebUI

Comment 7 by aee@chromium.org, May 24 2018

Cc: aee@chromium.org
 Issue 846258  has been merged into this issue.
Project Member

Comment 8 by bugdroid1@chromium.org, May 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1350b7a5002547d277410140ef7444969aadf4c9

commit 1350b7a5002547d277410140ef7444969aadf4c9
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Fri May 25 00:14:15 2018

WebUI: set initial values for padding so there is a default value

When a polyer element style is overridden and there is no explicitly set
style, all the other usages of that polymer element will erroneously
try to override the style with an undefined variable and no default.

Example: |padding-bottom: var(--cr-dialog-body_-_padding-bottom);|

This is only happens when |optimize_webui=true| is set in the build
arguments.

Bug:  846254 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I010c560e80f89c0473722351dce346d481cd3113
Reviewed-on: https://chromium-review.googlesource.com/1072236
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561700}
[modify] https://crrev.com/1350b7a5002547d277410140ef7444969aadf4c9/chrome/browser/resources/md_extensions/options_dialog.html
[modify] https://crrev.com/1350b7a5002547d277410140ef7444969aadf4c9/chrome/browser/resources/print_preview/new/destination_dialog.html
[modify] https://crrev.com/1350b7a5002547d277410140ef7444969aadf4c9/chrome/browser/resources/print_preview/new/search_dialog_css.html
[modify] https://crrev.com/1350b7a5002547d277410140ef7444969aadf4c9/chrome/browser/resources/settings/languages_page/add_languages_dialog.html
[modify] https://crrev.com/1350b7a5002547d277410140ef7444969aadf4c9/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html

Comment 9 by aee@chromium.org, May 25 2018

Status: Fixed (was: Started)
Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-68; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-68 label, otherwise remove Merge-TBD label. Thanks.
Labels: TE-Verified-68.0.3440.0 TE-Verified-M68
Update : 
Retested above issue in latest Canary build #68.0.3440.0 on Windows(7, 8, 8.1, 10), Mac(10.12.6, 10.13.1, 10.13.5) and Linux 14.04 LTS OS (with build #68.0.3440.2) and the issue is fixed. Language list appears properly in 'Add Languages' dialog. Kindly review an attached screen-cast for the reference.

Thank you..!
Canary_behaviour.mp4
762 KB View Download
Labels: TE-Verified-68.0.3440.2

Comment 13 by aee@chromium.org, May 25 2018

Labels: -Merge-TBD

Sign in to add a comment