New issue
Advanced search Search tips

Issue 846243 link

Starred by 0 users
Status: Fixed
Owner:
mcnee@chromium.org
Closed: May 2018
Cc:
mcnee@chromium.org
fhorschig@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----

Blocking:
issue 787924



Sign in to add a comment

Mac10.10 Tests fail scroll-visual-viewport-send-boundary-events.html

Project Member Reported by fhorschig@chromium.org, May 24 2018 
The last ~40 builds on have been failing one specific test:
fast/events/pinch/scroll-visual-viewport-send-boundary-events.html

The first failure was:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/32406

(There was actually one run where it succeeded, one out of 40.)

Excerpt of one error log FTR:
[...]
18:14:24.544 14765 worker/7 virtual/mouseevent_fractional/fast/events/pinch/scroll-visual-viewport-send-boundary-events.html output stderr lines:
18:14:24.544 14765   [18:14:22.446] vtDecompressionDuctCreate signalled err=-8973 (err) (Could not select and open decoder instance) at /SourceCache/CoreMedia_frameworks/CoreMedia-1562.240/Sources/VideoToolbox/VTDecompressionSession.c line 1181
18:14:24.544 14765   <<<< VTVideoEncoderSelection >>>> VTSelectAndCreateVideoEncoderInstanceInternal: no video encoder found for 'avc1'
18:14:24.544 14765   
18:14:24.544 14765   [18:14:22.663] VTSelectAndCreateVideoEncoderInstanceInternal signalled err=-12908 (err) (Video encoder not available) at /SourceCache/CoreMedia_frameworks/CoreMedia-1562.240/Sources/VideoToolbox/VTVideoEncoderSelection.c line 1245
18:14:24.544 14765   [18:14:22.663] VTCompressionSessionCreate signalled err=-12908 (err) (Could not select and open encoder instance) at /SourceCache/CoreMedia_frameworks/CoreMedia-1562.240/Sources/VideoToolbox/VTCompressionSession.c line 946
18:14:24.550 13545 [10/32] virtual/mouseevent_fractional/fast/events/pinch/scroll-visual-viewport-send-boundary-events.html failed unexpectedly (asserts failed)
[...]

I am going to revert the CL that introduced this test:
https://chromium-review.googlesource.com/c/chromium/src/+/1068625

mcnee@, could you please take a look?
Project Member

Comment 1 by bugdroid1@chromium.org, May 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1323de0969cbbd35f06c5286cfcdebe76ccfa263

commit 1323de0969cbbd35f06c5286cfcdebe76ccfa263
Author: Friedrich Horschig <fhorschig@chromium.org>
Date: Thu May 24 09:38:02 2018

Revert "Adapt scroll-visual-viewport-send-boundary-events.html to run with a compositor"

This reverts commit ec54e1ca07094b9b8e737d9e87e72555ef2215b5.

Reason for revert: The newly introduced test failed consistently. Please check either the test or it's implementation. Details in the linked bug.

Original change's description:
> Adapt scroll-visual-viewport-send-boundary-events.html to run with a compositor
> 
> Since this test uses chrome.gpuBenchmarking.pinchBy, we need to have
> it run with a compositor. As part of  issue 787924 , we will no longer
> handle gesture pinch events on the main thread.
> 
> Bug:  787924 
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Change-Id: I0127028f246ae72a772ef8c9f163b4403b6c3036
> Reviewed-on: https://chromium-review.googlesource.com/1068625
> Commit-Queue: Kevin McNee <mcnee@chromium.org>
> Reviewed-by: Ella Ge <eirage@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#560831}

TBR=mcnee@chromium.org,eirage@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  787924 ,  846243 
Change-Id: I9e6b2f6e8d0ad6d6a43048659f825d590f218fd8
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/1071527
Reviewed-by: Friedrich Horschig <fhorschig@chromium.org>
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561440}
[modify] https://crrev.com/1323de0969cbbd35f06c5286cfcdebe76ccfa263/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-gen-property-trees
[modify] https://crrev.com/1323de0969cbbd35f06c5286cfcdebe76ccfa263/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[rename] https://crrev.com/1323de0969cbbd35f06c5286cfcdebe76ccfa263/third_party/WebKit/LayoutTests/fast/events/scroll-visual-viewport-send-boundary-events.html

Comment 2 by fhorschig@chromium.org, May 24 2018

Status: Fixed (was: Assigned)
Yupp, the revert did help. Please reopen should the errors return.
►

Sign in to add a comment