New issue
Advanced search Search tips

Issue 846235 link

Starred by 3 users

Issue metadata

Status: Started
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug


Sign in to add a comment

Enable ServiceWorkerServicification without NetworkService.

Project Member Reported by falken@google.com, May 24 2018

Issue description

ServiceWorkerServicification is a flag that lets you turn on the "NetS13nServiceWorker" implementation ( issue 715640 ) without NetworkService. The plan is to ship this before NetworkService to reduce the risk of shipping NetworkService.

This is meant to be an umbrella bug that depends on the "NetS13nServiceWorker without NetworkService" bugs.

Internal design doc (focused on field trial metrics):
https://docs.google.com/document/d/1fkJqZYlJRsHabhi2_D-EhA4MW23-7PatQ4JPli1mXTo/edit#
 

Comment 1 by falken@chromium.org, May 24 2018

Blocking: 715640

Comment 2 by falken@chromium.org, May 24 2018

Blockedon: 846197

Comment 3 by falken@chromium.org, May 24 2018

Blockedon: 828331

Comment 4 by falken@chromium.org, May 24 2018

Blockedon: 846196

Comment 5 by shimazu@google.com, May 24 2018

Blockedon: 846237
Blockedon: 846232

Comment 7 by falken@chromium.org, May 25 2018

Blockedon: 846637

Comment 8 by npm@chromium.org, May 25 2018

Blockedon: 846631
Blockedon: 847565
Components: Internals>Services>Network
Labels: Proj-Servicification
Blockedon: 850355

Comment 12 by dxie@google.com, Jun 7 2018

Labels: Hotlist-KnownIssue
Blockedon: -846631
Blockedon: 851831
Blockedon: 852202
Description: Show this description
Blockedon: 852698
Blockedon: 855948
Blockedon: 856521
Blockedon: 854902
Blockedon: 857005
Blockedon: 857040
Blocking: 853518
Blockedon: 860106
Blockedon: 860361
Blockedon: 861644
Blockedon: 861657
Blockedon: 866335
Blockedon: 866367
Blockedon: 869302
Description: Show this description
Project Member

Comment 32 by bugdroid1@chromium.org, Jul 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a58e775ebe7eb45924b891b73f8a21c24b6fdf14

commit a58e775ebe7eb45924b891b73f8a21c24b6fdf14
Author: Matt Falkenhagen <falken@chromium.org>
Date: Tue Jul 31 22:59:32 2018

Declare the ServiceWorkerServicification experiment for fieldtrial testing.

This experiment is ready for testing on the Beta channel.

Bug: 846235
Change-Id: Ibcaafcab93fced86a2831b6c7cb53b02bbc869db
Reviewed-on: https://chromium-review.googlesource.com/1147891
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#579610}
[modify] https://crrev.com/a58e775ebe7eb45924b891b73f8a21c24b6fdf14/testing/variations/fieldtrial_testing_config.json

Blockedon: 871654
Blocking: 804546
Blockedon: 873433
Blockedon: 884960
Blockedon: 893476
Project Member

Comment 38 by bugdroid1@chromium.org, Oct 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d2271ca9f5f569bbec950f9f0cc98af070ea52f

commit 5d2271ca9f5f569bbec950f9f0cc98af070ea52f
Author: Matt Falkenhagen <falken@chromium.org>
Date: Wed Oct 17 10:12:44 2018

Enable ServiceWorkerServicification by default.

Bug:  715640 , 846235
Change-Id: I49ed8a5a3bc5962cd52e24ab734b00fdfdd7b32d
Reviewed-on: https://chromium-review.googlesource.com/c/1286238
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600337}
[modify] https://crrev.com/5d2271ca9f5f569bbec950f9f0cc98af070ea52f/third_party/blink/common/features.cc

Status: Fixed (was: Started)
Let me mark this one fixed and we can track this at the main issue 846235.
err... the main  issue 715640 
Status: Started (was: Fixed)
I'm reopening this just because the Chrome variations experiment is tied to this bug and gets warnings if this bug is closed.

Sign in to add a comment