NetworkService: Service worker content browser test failures |
|||
Issue descriptionFailing tests: -ServiceWorkerBrowserTest.ImportsBustMemcache -ServiceWorkerBrowserTest.ResponseFromHTTPSServiceWorkerIsMarkedAsSecure -ServiceWorkerNavigationPreloadTest.CanceledByInterceptor -ServiceWorkerNavigationPreloadTest.RespondWithNavigationPreloadWithMimeSniffing -ServiceWorkerV8CodeCacheForCacheStorageTest.V8CacheOnCacheStorage -ServiceWorkerVersionBrowserTest.ServiceWorkerScriptHeader -ServiceWorkerVersionBrowserV8CacheTest.Restart
,
May 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3c070b2689354f8d5449a79463a77f497131c632 commit 3c070b2689354f8d5449a79463a77f497131c632 Author: Kenichi Ishibashi <bashi@chromium.org> Date: Mon May 28 05:58:48 2018 Replace URLRequestInterceptor with mock http headers in SW browsertests ServiceWorkerBrowserTest.ImportsBustMemcache was failing with --enable-features=NetworkService because the test depends on URLRequestInterceptor but it's not supported by network service. This CL replaces the interceptor with JS files and .mock-http-headers. Bug: 846229 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ia828803fc997dd69fb4bf7a96e688c7b8510c65a Reviewed-on: https://chromium-review.googlesource.com/1073030 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#562190} [modify] https://crrev.com/3c070b2689354f8d5449a79463a77f497131c632/content/browser/service_worker/service_worker_browsertest.cc [add] https://crrev.com/3c070b2689354f8d5449a79463a77f497131c632/content/test/data/service_worker/long_lived_import.js [add] https://crrev.com/3c070b2689354f8d5449a79463a77f497131c632/content/test/data/service_worker/long_lived_import.js.mock-http-headers [add] https://crrev.com/3c070b2689354f8d5449a79463a77f497131c632/content/test/data/service_worker/worker_with_one_import.js [add] https://crrev.com/3c070b2689354f8d5449a79463a77f497131c632/content/test/data/service_worker/worker_with_one_import.js.mock-http-headers [modify] https://crrev.com/3c070b2689354f8d5449a79463a77f497131c632/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter
,
Jun 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1a4877949772923aec952a4182118a42c50831ff commit 1a4877949772923aec952a4182118a42c50831ff Author: Kenichi Ishibashi <bashi@chromium.org> Date: Fri Jun 01 00:41:40 2018 S13nSW: Set "Service-Worker" header when fetching service worker script The spec requires "Service-Worker: script" header[1]. This fixes ServiceWorkerVersionBrowserTest.ServiceWorkerScriptHeader. [1] https://w3c.github.io/ServiceWorker/#update-algorithm Bug: 846229 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I20a080eee91f66f99a5e8ea1320adc0c1d8b983e Reviewed-on: https://chromium-review.googlesource.com/1080358 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#563462} [modify] https://crrev.com/1a4877949772923aec952a4182118a42c50831ff/content/browser/service_worker/service_worker_new_script_loader.cc [modify] https://crrev.com/1a4877949772923aec952a4182118a42c50831ff/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter
,
Jun 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2819ce2b691d1c0f93bfe132a57ccea7503aff76 commit 2819ce2b691d1c0f93bfe132a57ccea7503aff76 Author: Kenichi Ishibashi <bashi@chromium.org> Date: Mon Jun 04 01:19:23 2018 S13nSW: Populate cached metadata from ServiceWorkerInstalledScriptLoader When V8ScriptRunner compiles a script it check if there is a cached metadata for the script to decide it should generate code cache or not. Before this CL, we didn't populate cached metadata for installed scripts in S13nServiceWorker code path so V8ScriptRunner never generated caches for installed scripts. This fixes ServiceWorkerVersionBrowserV8CacheTest.Restart. Bug: 846229 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I51d8d6cae30449ab35ba735280815ae5c8ecc4a9 Reviewed-on: https://chromium-review.googlesource.com/1082172 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#563984} [modify] https://crrev.com/2819ce2b691d1c0f93bfe132a57ccea7503aff76/content/browser/service_worker/service_worker_browsertest.cc [modify] https://crrev.com/2819ce2b691d1c0f93bfe132a57ccea7503aff76/content/browser/service_worker/service_worker_installed_script_loader.cc [modify] https://crrev.com/2819ce2b691d1c0f93bfe132a57ccea7503aff76/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter
,
Jun 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1b1c6ee31adaf386f367ea36c8065917b553bea7 commit 1b1c6ee31adaf386f367ea36c8065917b553bea7 Author: Kenichi Ishibashi <bashi@chromium.org> Date: Mon Jun 04 08:06:13 2018 Set response_time in ServiceWorkerLoaderHelpers::SaveResponseInfo() As described in [1], cache storage uses (url, response_time) tuple as a key to identify cache entry. V8 code cache wouldn't be stored in the cache storage when response_time isn't set correctly. Before this CL we didn't populate response_time in ServiceWorkerSubresourceLoader and ServiceWorkerNavigationLoader so V8 code cache was never created when a script is supplied by cache storage via service worker. This fixes ServiceWorkerV8CodeCacheForCacheStorageTest.V8CacheOnCacheStorage. [1] https://docs.google.com/document/d/1dVlgbXls-G65koU2vlmAXy1EVsoY9Z55jaEX7cZgfDA/edit#heading=h.6vaw3rtxg1s5 Bug: 846229 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ib82546cb9e0581df75e6280232ed8c9a8ca57cfe Reviewed-on: https://chromium-review.googlesource.com/1084362 Reviewed-by: Matt Falkenhagen <falken@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#564014} [modify] https://crrev.com/1b1c6ee31adaf386f367ea36c8065917b553bea7/content/common/service_worker/service_worker_loader_helpers.cc [modify] https://crrev.com/1b1c6ee31adaf386f367ea36c8065917b553bea7/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter
,
Jun 5 2018
,
Jun 12 2018
All tests listed in the description are fixed (and skipped). Let me close this. |
|||
►
Sign in to add a comment |
|||
Comment 1 by bashi@chromium.org
, May 25 2018Status: Started (was: Available)