New issue
Advanced search Search tips

Issue 846220 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-06-06
OS: iOS
Pri: 2
Type: Bug
Q2



Sign in to add a comment

Forward and backward buttons are not displayed on navigating to any webpage. landscape mode.

Project Member Reported by pmadalla@chromium.org, May 24 2018

Issue description

App Version: 68.0.3439.0 Canary
iOS Version: 11.3.1,10.3.3
Device: iPhone 7+,8+ only

Precondition:
1. Enable ui-refresh-phase-1 in chrome://flag

Steps to reproduce:
  1.  Launch chrome in portrait mode.
  2.  Change the device orientation to landscape mode.
  3.  Goto any webpage “say : Facebook.com” or tap on any Most visited tile.

Observed results:
Only Reload button is displayed

Expected results:
Backward forward and Reload buttons should be displayed

Number of times you were able to reproduce: 3/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: NA
Bug reproducible on Dolphin/Safari/Firefox: Safari : NA
Bug reproducible on the current beta channel build : No in M66
Bug reproducible on the current beta channel build : NA in M67

Link to video/image:
https://drive.google.com/file/d/1OfXq18IcQyUwpqxtrD04Py60HacH7Jw4/view?usp=sharing

 
Components: -UI>Browser>Omnibox UI>Browser>Toolbar
Labels: Q2
Owner: gambard@chromium.org
Status: Assigned (was: Untriaged)
68.0.3434.0 is working, 68.0.3435.0 isn't working.
NextAction: 2018-06-06
Project Member

Comment 4 by bugdroid1@chromium.org, May 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c04b238d511d37d1fadb8b5605f2fe42efbfe770

commit c04b238d511d37d1fadb8b5605f2fe42efbfe770
Author: Gauthier Ambard <gambard@chromium.org>
Date: Tue May 29 09:08:50 2018

Remove layout pass of the toolbar on rotation

This CL removes the relayout of the top toolbar on rotation as it is
creating an issue with the stack views.
It was added to fix an issue where the incognito NTP was flickering
during the open animation. However, this is issue is fixed in UI
Refresh.

Bug:  846220 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ic9b4d2eae03c63d84f204ccf799f755367378f7d
Reviewed-on: https://chromium-review.googlesource.com/1075790
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562373}
[modify] https://crrev.com/c04b238d511d37d1fadb8b5605f2fe42efbfe770/ios/chrome/browser/ui/browser_view_controller.mm

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verified in 69.0.3450.0 Canary in iPhone 7(iOS 11.3.1) and iPhone 6 plus(iOS 10.3.3)

Forward and backward buttons are now displayed on navigating to any webpage in landscape mode
The NextAction date has arrived: 2018-06-06

Sign in to add a comment