New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 846213 link

Starred by 6 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Crostini windows always get associated with the active profile

Project Member Reported by timloh@chromium.org, May 24 2018

Issue description

When a Crostini window opens, we associate it with the active profile (see CrostiniAppWindowShelfController::OnWindowVisibilityChanged()). This can be unexpected in some cases, for example if an app is slow to launch and the user switches profile, or an app receives push notifications and displays them. We should have some sort of way to identify which profile (or container) a window came from when it opens.
 
Can we use the some startup id logic that handles launching on correct display?

Comment 2 by timloh@chromium.org, May 25 2018

Are you referring to https://chromium-review.googlesource.com/c/chromium/src/+/1070711? I don't think that would be sufficient because we'd need to handle windows popping up not associated with the user launching from crOS, e.g. chat clients or other programs that will receive notifications.
If a new window is associated with an existing app then it will have properties set that will allow you to detect that. Either it's a transient of another window or the app/startup id will be set.

We can also expose the peer credentials of the connection if you're looking for a reliable trusted way to determine where a window comes from. This would give us the crosvm pid in our case. 

Comment 4 by vapier@chromium.org, May 29 2018

Components: OS>Systems>Containers
Labels: Hotlist-Crostini-UI
Owner: reve...@chromium.org
Status: Assigned (was: Untriaged)
Cc: nverne@chromium.org timloh@chromium.org
 Issue 849896  has been merged into this issue.
Owner: timzheng@chromium.org
Status: Started (was: Assigned)
I tried to reproduce but got another result.
1) Logon with account A.
2) Sign in another account B.
3) Switch back to account A.
4) Click to start a Crostini app.
5) A spinner appears and wait for the container to start up.
6) Hurry up and switch to account B before the app starts.
7) The spinner appears on the shelf.
8) Then Chrome crashes.
With the tip of tree chrome build, chrome crashes when I try to do step 2) sign in another account B. The login screen shows and immediately crashes and back to account A.
Status: Untriaged (was: Started)
Status: Assigned (was: Untriaged)

Sign in to add a comment