New issue
Advanced search Search tips

Issue 846211 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

Audits2 layout tests are flaky on Linux

Project Member Reported by paulirish@google.com, May 24 2018

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, May 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a745fe4457a6dda2ebca843cfbb9a9ec16563805

commit a745fe4457a6dda2ebca843cfbb9a9ec16563805
Author: Paul Irish <paulirish@chromium.org>
Date: Thu May 24 07:48:15 2018

DevTools: [Audits] Roll Lighthouse to v3.0-beta

Bug: 772558, 846211
Change-Id: I4f74ea0d4a84908d2e7c4ccfe7035ee421bdf023
Reviewed-on: https://chromium-review.googlesource.com/1070532
Commit-Queue: Paul Irish <paulirish@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561412}
[modify] https://crrev.com/a745fe4457a6dda2ebca843cfbb9a9ec16563805/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/a745fe4457a6dda2ebca843cfbb9a9ec16563805/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-limited-run-expected.txt
[modify] https://crrev.com/a745fe4457a6dda2ebca843cfbb9a9ec16563805/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-limited-run.js
[modify] https://crrev.com/a745fe4457a6dda2ebca843cfbb9a9ec16563805/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-successful-run-expected.txt
[modify] https://crrev.com/a745fe4457a6dda2ebca843cfbb9a9ec16563805/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-successful-run.js
[modify] https://crrev.com/a745fe4457a6dda2ebca843cfbb9a9ec16563805/third_party/blink/renderer/devtools/BUILD.gn
[modify] https://crrev.com/a745fe4457a6dda2ebca843cfbb9a9ec16563805/third_party/blink/renderer/devtools/front_end/audits2/Audits2Controller.js
[modify] https://crrev.com/a745fe4457a6dda2ebca843cfbb9a9ec16563805/third_party/blink/renderer/devtools/front_end/audits2/Audits2Panel.js
[modify] https://crrev.com/a745fe4457a6dda2ebca843cfbb9a9ec16563805/third_party/blink/renderer/devtools/front_end/audits2/Audits2ProtocolService.js
[modify] https://crrev.com/a745fe4457a6dda2ebca843cfbb9a9ec16563805/third_party/blink/renderer/devtools/front_end/audits2/Audits2ReportRenderer.js
[modify] https://crrev.com/a745fe4457a6dda2ebca843cfbb9a9ec16563805/third_party/blink/renderer/devtools/front_end/audits2/Audits2ReportSelector.js
[modify] https://crrev.com/a745fe4457a6dda2ebca843cfbb9a9ec16563805/third_party/blink/renderer/devtools/front_end/audits2/RadioSetting.js
[modify] https://crrev.com/a745fe4457a6dda2ebca843cfbb9a9ec16563805/third_party/blink/renderer/devtools/front_end/audits2/audits2Panel.css
[modify] https://crrev.com/a745fe4457a6dda2ebca843cfbb9a9ec16563805/third_party/blink/renderer/devtools/front_end/audits2/lighthouse/renderer/category-renderer.js
[modify] https://crrev.com/a745fe4457a6dda2ebca843cfbb9a9ec16563805/third_party/blink/renderer/devtools/front_end/audits2/lighthouse/renderer/crc-details-renderer.js
[modify] https://crrev.com/a745fe4457a6dda2ebca843cfbb9a9ec16563805/third_party/blink/renderer/devtools/front_end/audits2/lighthouse/renderer/details-renderer.js
[modify] https://crrev.com/a745fe4457a6dda2ebca843cfbb9a9ec16563805/third_party/blink/renderer/devtools/front_end/audits2/lighthouse/renderer/dom.js
[add] https://crrev.com/a745fe4457a6dda2ebca843cfbb9a9ec16563805/third_party/blink/renderer/devtools/front_end/audits2/lighthouse/renderer/performance-category-renderer.js
[modify] https://crrev.com/a745fe4457a6dda2ebca843cfbb9a9ec16563805/third_party/blink/renderer/devtools/front_end/audits2/lighthouse/renderer/report-renderer.js
[modify] https://crrev.com/a745fe4457a6dda2ebca843cfbb9a9ec16563805/third_party/blink/renderer/devtools/front_end/audits2/lighthouse/renderer/util.js
[modify] https://crrev.com/a745fe4457a6dda2ebca843cfbb9a9ec16563805/third_party/blink/renderer/devtools/front_end/audits2/lighthouse/report-styles.css
[modify] https://crrev.com/a745fe4457a6dda2ebca843cfbb9a9ec16563805/third_party/blink/renderer/devtools/front_end/audits2/lighthouse/templates.html
[modify] https://crrev.com/a745fe4457a6dda2ebca843cfbb9a9ec16563805/third_party/blink/renderer/devtools/front_end/audits2/module.json
[modify] https://crrev.com/a745fe4457a6dda2ebca843cfbb9a9ec16563805/third_party/blink/renderer/devtools/front_end/audits2_worker/Audits2Service.js
[modify] https://crrev.com/a745fe4457a6dda2ebca843cfbb9a9ec16563805/third_party/blink/renderer/devtools/front_end/audits2_worker/lighthouse/lighthouse-background.js
[modify] https://crrev.com/a745fe4457a6dda2ebca843cfbb9a9ec16563805/third_party/blink/renderer/devtools/front_end/bindings/FileUtils.js
[modify] https://crrev.com/a745fe4457a6dda2ebca843cfbb9a9ec16563805/third_party/blink/renderer/devtools/front_end/externs.js

Project Member

Comment 2 by bugdroid1@chromium.org, May 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28abe7802899b037a176426f883c750fec5a6d24

commit 28abe7802899b037a176426f883c750fec5a6d24
Author: Trent Apted <tapted@chromium.org>
Date: Fri May 25 02:13:48 2018

Revert "DevTools: [Audits] Roll Lighthouse to v3.0-beta"

This reverts commit a745fe4457a6dda2ebca843cfbb9a9ec16563805.

Bug:  846551 

Reason for revert: Suspected for failures in


* http/tests/devtools/audits2/audits2-limited-run.js
* http/tests/devtools/audits2/audits2-successful-run.js

since

https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac10.11%20%28dbg%29/16181

Original change's description:
> DevTools: [Audits] Roll Lighthouse to v3.0-beta
> 
> Bug: 772558, 846211
> Change-Id: I4f74ea0d4a84908d2e7c4ccfe7035ee421bdf023
> Reviewed-on: https://chromium-review.googlesource.com/1070532
> Commit-Queue: Paul Irish <paulirish@chromium.org>
> Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#561412}

TBR=pfeldman@chromium.org,paulirish@chromium.org,phulce@chromium.org

Change-Id: I71f125736ac908f37c3d90988b85de51f4fb283c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 772558, 846211
Reviewed-on: https://chromium-review.googlesource.com/1073008
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561735}
[modify] https://crrev.com/28abe7802899b037a176426f883c750fec5a6d24/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/28abe7802899b037a176426f883c750fec5a6d24/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-limited-run-expected.txt
[modify] https://crrev.com/28abe7802899b037a176426f883c750fec5a6d24/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-limited-run.js
[modify] https://crrev.com/28abe7802899b037a176426f883c750fec5a6d24/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-successful-run-expected.txt
[modify] https://crrev.com/28abe7802899b037a176426f883c750fec5a6d24/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-successful-run.js
[modify] https://crrev.com/28abe7802899b037a176426f883c750fec5a6d24/third_party/blink/renderer/devtools/BUILD.gn
[modify] https://crrev.com/28abe7802899b037a176426f883c750fec5a6d24/third_party/blink/renderer/devtools/front_end/audits2/Audits2Controller.js
[modify] https://crrev.com/28abe7802899b037a176426f883c750fec5a6d24/third_party/blink/renderer/devtools/front_end/audits2/Audits2Panel.js
[modify] https://crrev.com/28abe7802899b037a176426f883c750fec5a6d24/third_party/blink/renderer/devtools/front_end/audits2/Audits2ProtocolService.js
[modify] https://crrev.com/28abe7802899b037a176426f883c750fec5a6d24/third_party/blink/renderer/devtools/front_end/audits2/Audits2ReportRenderer.js
[modify] https://crrev.com/28abe7802899b037a176426f883c750fec5a6d24/third_party/blink/renderer/devtools/front_end/audits2/Audits2ReportSelector.js
[modify] https://crrev.com/28abe7802899b037a176426f883c750fec5a6d24/third_party/blink/renderer/devtools/front_end/audits2/RadioSetting.js
[modify] https://crrev.com/28abe7802899b037a176426f883c750fec5a6d24/third_party/blink/renderer/devtools/front_end/audits2/audits2Panel.css
[modify] https://crrev.com/28abe7802899b037a176426f883c750fec5a6d24/third_party/blink/renderer/devtools/front_end/audits2/lighthouse/renderer/category-renderer.js
[modify] https://crrev.com/28abe7802899b037a176426f883c750fec5a6d24/third_party/blink/renderer/devtools/front_end/audits2/lighthouse/renderer/crc-details-renderer.js
[modify] https://crrev.com/28abe7802899b037a176426f883c750fec5a6d24/third_party/blink/renderer/devtools/front_end/audits2/lighthouse/renderer/details-renderer.js
[modify] https://crrev.com/28abe7802899b037a176426f883c750fec5a6d24/third_party/blink/renderer/devtools/front_end/audits2/lighthouse/renderer/dom.js
[delete] https://crrev.com/c4d26bf432ed85aff2ac8ed238829aeacb05523a/third_party/blink/renderer/devtools/front_end/audits2/lighthouse/renderer/performance-category-renderer.js
[modify] https://crrev.com/28abe7802899b037a176426f883c750fec5a6d24/third_party/blink/renderer/devtools/front_end/audits2/lighthouse/renderer/report-renderer.js
[modify] https://crrev.com/28abe7802899b037a176426f883c750fec5a6d24/third_party/blink/renderer/devtools/front_end/audits2/lighthouse/renderer/util.js
[modify] https://crrev.com/28abe7802899b037a176426f883c750fec5a6d24/third_party/blink/renderer/devtools/front_end/audits2/lighthouse/report-styles.css
[modify] https://crrev.com/28abe7802899b037a176426f883c750fec5a6d24/third_party/blink/renderer/devtools/front_end/audits2/lighthouse/templates.html
[modify] https://crrev.com/28abe7802899b037a176426f883c750fec5a6d24/third_party/blink/renderer/devtools/front_end/audits2/module.json
[modify] https://crrev.com/28abe7802899b037a176426f883c750fec5a6d24/third_party/blink/renderer/devtools/front_end/audits2_worker/Audits2Service.js
[modify] https://crrev.com/28abe7802899b037a176426f883c750fec5a6d24/third_party/blink/renderer/devtools/front_end/audits2_worker/lighthouse/lighthouse-background.js
[modify] https://crrev.com/28abe7802899b037a176426f883c750fec5a6d24/third_party/blink/renderer/devtools/front_end/bindings/FileUtils.js
[modify] https://crrev.com/28abe7802899b037a176426f883c750fec5a6d24/third_party/blink/renderer/devtools/front_end/externs.js

Project Member

Comment 4 by bugdroid1@chromium.org, May 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8405e18c05b9e5a1c714db1e204de6aaae3be24d

commit 8405e18c05b9e5a1c714db1e204de6aaae3be24d
Author: Paul Irish <paulirish@chromium.org>
Date: Thu May 31 02:29:50 2018

Restore "DevTools: [Audits] Roll Lighthouse to v3.0-beta"

This reverts commit 28abe7802899b037a176426f883c750fec5a6d24.

Bug: 772558, 846211, 846551 
Change-Id: Ib782b1fb5ee737f31deaa94630fb2bb1021b579b
Reviewed-on: https://chromium-review.googlesource.com/1077597
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Reviewed-by: Patrick Hulce <phulce@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563121}
[modify] https://crrev.com/8405e18c05b9e5a1c714db1e204de6aaae3be24d/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-limited-run-expected.txt
[modify] https://crrev.com/8405e18c05b9e5a1c714db1e204de6aaae3be24d/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-successful-run-expected.txt
[modify] https://crrev.com/8405e18c05b9e5a1c714db1e204de6aaae3be24d/third_party/WebKit/LayoutTests/http/tests/devtools/audits2/audits2-successful-run.js
[modify] https://crrev.com/8405e18c05b9e5a1c714db1e204de6aaae3be24d/third_party/blink/renderer/devtools/BUILD.gn
[modify] https://crrev.com/8405e18c05b9e5a1c714db1e204de6aaae3be24d/third_party/blink/renderer/devtools/front_end/audits2/Audits2Controller.js
[modify] https://crrev.com/8405e18c05b9e5a1c714db1e204de6aaae3be24d/third_party/blink/renderer/devtools/front_end/audits2/Audits2Panel.js
[modify] https://crrev.com/8405e18c05b9e5a1c714db1e204de6aaae3be24d/third_party/blink/renderer/devtools/front_end/audits2/Audits2ProtocolService.js
[modify] https://crrev.com/8405e18c05b9e5a1c714db1e204de6aaae3be24d/third_party/blink/renderer/devtools/front_end/audits2/Audits2ReportRenderer.js
[modify] https://crrev.com/8405e18c05b9e5a1c714db1e204de6aaae3be24d/third_party/blink/renderer/devtools/front_end/audits2/Audits2ReportSelector.js
[modify] https://crrev.com/8405e18c05b9e5a1c714db1e204de6aaae3be24d/third_party/blink/renderer/devtools/front_end/audits2/RadioSetting.js
[modify] https://crrev.com/8405e18c05b9e5a1c714db1e204de6aaae3be24d/third_party/blink/renderer/devtools/front_end/audits2/audits2Panel.css
[modify] https://crrev.com/8405e18c05b9e5a1c714db1e204de6aaae3be24d/third_party/blink/renderer/devtools/front_end/audits2/lighthouse/renderer/category-renderer.js
[modify] https://crrev.com/8405e18c05b9e5a1c714db1e204de6aaae3be24d/third_party/blink/renderer/devtools/front_end/audits2/lighthouse/renderer/crc-details-renderer.js
[modify] https://crrev.com/8405e18c05b9e5a1c714db1e204de6aaae3be24d/third_party/blink/renderer/devtools/front_end/audits2/lighthouse/renderer/details-renderer.js
[modify] https://crrev.com/8405e18c05b9e5a1c714db1e204de6aaae3be24d/third_party/blink/renderer/devtools/front_end/audits2/lighthouse/renderer/dom.js
[add] https://crrev.com/8405e18c05b9e5a1c714db1e204de6aaae3be24d/third_party/blink/renderer/devtools/front_end/audits2/lighthouse/renderer/performance-category-renderer.js
[modify] https://crrev.com/8405e18c05b9e5a1c714db1e204de6aaae3be24d/third_party/blink/renderer/devtools/front_end/audits2/lighthouse/renderer/report-renderer.js
[modify] https://crrev.com/8405e18c05b9e5a1c714db1e204de6aaae3be24d/third_party/blink/renderer/devtools/front_end/audits2/lighthouse/renderer/util.js
[modify] https://crrev.com/8405e18c05b9e5a1c714db1e204de6aaae3be24d/third_party/blink/renderer/devtools/front_end/audits2/lighthouse/report-styles.css
[modify] https://crrev.com/8405e18c05b9e5a1c714db1e204de6aaae3be24d/third_party/blink/renderer/devtools/front_end/audits2/lighthouse/templates.html
[modify] https://crrev.com/8405e18c05b9e5a1c714db1e204de6aaae3be24d/third_party/blink/renderer/devtools/front_end/audits2/module.json
[modify] https://crrev.com/8405e18c05b9e5a1c714db1e204de6aaae3be24d/third_party/blink/renderer/devtools/front_end/audits2_worker/Audits2Service.js
[modify] https://crrev.com/8405e18c05b9e5a1c714db1e204de6aaae3be24d/third_party/blink/renderer/devtools/front_end/audits2_worker/lighthouse/lighthouse-background.js
[modify] https://crrev.com/8405e18c05b9e5a1c714db1e204de6aaae3be24d/third_party/blink/renderer/devtools/front_end/bindings/FileUtils.js
[modify] https://crrev.com/8405e18c05b9e5a1c714db1e204de6aaae3be24d/third_party/blink/renderer/devtools/front_end/externs.js

Owner: paulir...@chromium.org

Sign in to add a comment