New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 846210 link

Starred by 3 users
Status: Fixed
Owner:
█ scottchen@chromium.org
Last visit > 30 days ago
Closed: Jul 25
Cc:
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

The spacing between label+card and label+top bar should be consistent between Settings and Downloads

Project Member Reported by namratakannan@chromium.org, May 24 2018 
The spacing between label+card and label+top bar should be consistent between Settings and Downloads
Top level alignment.png
118 KB View Download

Comment 1 by scottchen@chromium.org, Jul 24

Owner: scottchen@chromium.org
Status: Started (was: Untriaged)

Comment 2 by scottchen@chromium.org, Jul 24

Description: Show this description

Comment 3 by scottchen@chromium.org, Jul 24

Summary: The spacing between label+card and label+top bar should be consistent between Settings and Downloads (was: Inconsistent position of top label/cards on downloads and settings)
I noticed spacing between top bar and label are also inconsistent between the two pages, so I've changed the bug title to reflect that issue as well.
Screenshot from 2018-07-24 10-46-12.png
46.9 KB View Download

Comment 4 by scottchen@chromium.org, Jul 24 

screenshot after the Fix:
Screenshot from 2018-07-24 11-21-22.png
25.1 KB View Download
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6cf1138b57ed4d2c36ad5f46b612be15046086e1

commit 6cf1138b57ed4d2c36ad5f46b612be15046086e1
Author: Scott Chen <scottchen@chromium.org>
Date: Wed Jul 25 01:58:35 2018

Downloads: make label styling consistent with Settings.

Bug:  846210 
Change-Id: I0c20f572ad294050ec78187cfbcc6f4cdd47141f
Reviewed-on: https://chromium-review.googlesource.com/1148760
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577768}
[modify] https://crrev.com/6cf1138b57ed4d2c36ad5f46b612be15046086e1/chrome/browser/resources/md_downloads/item.html
[modify] https://crrev.com/6cf1138b57ed4d2c36ad5f46b612be15046086e1/chrome/browser/resources/md_downloads/manager.html

Comment 6 by scottchen@chromium.org, Jul 25

Status: Fixed (was: Started)
►

Sign in to add a comment