S13nServiceWorker: Consistent GlobalRequestID() |
||||
Issue descriptionConsistent GlobalRequestID() ResourceDispatcherHostImpl issues the id, and NavigationURLLoaderNetworkService also issues another id. (copied from spreadsheet)
,
Jun 5 2018
,
Jun 13 2018
These three look using the global request id. - data_use_measurement::ChromeDataUseAscriberService::ReadyToCommitNavigation - page_load_metrics::PageLoadTracker::WillProcessNavigationResponse - content::protocol::NetworkNavigationThrottle::WillProcessResponse MakeGlobalRequestID() in navigation_url_loader_impl.cc and extra_info->GetGlobalRequestID() in resource_dispatcher_host_impl.cc are generating GlobalRequestIDs in the same range, so I think they might be possible to be overlapped.
,
Jun 18 2018
,
Jun 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ff60c141b832c6c230f6282780722b7cc9378735 commit ff60c141b832c6c230f6282780722b7cc9378735 Author: Makoto Shimazu <shimazu@chromium.org> Date: Tue Jun 19 06:17:33 2018 Create GlobalRequestID by ResourceDispatcherHost when non-NetworkService Previously GlobalRequestID could be created at both of NavigationURLLoader and ResourceDispatcherHost when ServiceWorkerServicification is on, and these IDs could be overlapped. This CL is to generate the id always by ResourceDispatcherHost. Bug: 846197 Change-Id: Id6b70b60e920995b98c62e7e8e01d0d99fa7e5b0 Reviewed-on: https://chromium-review.googlesource.com/1104057 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#568357} [modify] https://crrev.com/ff60c141b832c6c230f6282780722b7cc9378735/content/browser/loader/navigation_url_loader_impl.cc [modify] https://crrev.com/ff60c141b832c6c230f6282780722b7cc9378735/content/browser/loader/resource_dispatcher_host_impl.cc [modify] https://crrev.com/ff60c141b832c6c230f6282780722b7cc9378735/content/browser/loader/resource_dispatcher_host_impl.h
,
Jun 19 2018
|
||||
►
Sign in to add a comment |
||||
Comment 1 by falken@chromium.org
, May 24 2018