New issue
Advanced search Search tips

Issue 846196 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 846235



Sign in to add a comment

S13nServiceWorker: Set correct base url and history url to CommonNavigationParams for redirection to a data URL

Project Member Reported by falken@google.com, May 24 2018

Issue description

Set correct base url and history url to CommonNavigationParams for redirection to a data URL

It only affects android webview according to a comment.

(copied from tracker spreadsheet)
 

Comment 1 by falken@chromium.org, May 24 2018

Labels: -Proj-Servicification-Canary
I think this is S13nServiceWorker without  NetworkService, so removing the Canary label.

Comment 2 by falken@chromium.org, May 24 2018

Blocking: -715640 846235
Labels: Proj-Servicification
Status: Started (was: Available)

Comment 5 by dxie@google.com, Jun 19 2018

Labels: Hotlist-KnownIssue
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26d1747329f88167d683a578317ffb9e8af8d275

commit 26d1747329f88167d683a578317ffb9e8af8d275
Author: Makoto Shimazu <shimazu@chromium.org>
Date: Wed Jun 20 05:39:36 2018

Remove a TODO comment in NavigationURLLoader

The base url and history url have already been set appropriately.

TBR=kinuko@chromium.org

Bug:  846196 
Change-Id: Ib0da047983f19c781dbf5e6d6bce3acda8006bda
Reviewed-on: https://chromium-review.googlesource.com/1104079
Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568737}
[modify] https://crrev.com/26d1747329f88167d683a578317ffb9e8af8d275/content/browser/loader/navigation_url_loader_impl.cc

Cc: -shimazu@chromium.org
Owner: shimazu@chromium.org
Status: Fixed (was: Started)

Sign in to add a comment