New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 846165 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug
Hotlist-MemoryInfra



Sign in to add a comment

CrashDumpManager::CrashDumpDetails::file_size is never updated

Project Member Reported by csharrison@chromium.org, May 24 2018

Issue description

Since we use file_size == 0 as a proxy for OOMs, this is probably giving us some wrong data.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96a994dc4bef97e7295dc0126dcfe73cf822fdab

commit 96a994dc4bef97e7295dc0126dcfe73cf822fdab
Author: Charlie Harrison <csharrison@chromium.org>
Date: Wed May 30 02:08:21 2018

Fix CrashDumpManager reporting

file_size was never being set, so OOMs were being reported for normal
foreground crashes.

This CL removes file_size in favor of just using |status| to identify
empty crash dumps.

Unfortunately, this would have been caught if a TODO to beef up the
testing infrastructure had been done. This CL implements those changes
required to regression test this bug.

Bug:  846165 
Change-Id: Ibf272588af4029887792bffec509e0fbdfe9f63b
Reviewed-on: https://chromium-review.googlesource.com/1070794
Reviewed-by: Siddhartha S <ssid@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562694}
[modify] https://crrev.com/96a994dc4bef97e7295dc0126dcfe73cf822fdab/chrome/browser/metrics/oom/out_of_memory_reporter_unittest.cc
[modify] https://crrev.com/96a994dc4bef97e7295dc0126dcfe73cf822fdab/components/crash/content/browser/crash_dump_manager_android.cc
[modify] https://crrev.com/96a994dc4bef97e7295dc0126dcfe73cf822fdab/components/crash/content/browser/crash_dump_manager_android.h
[modify] https://crrev.com/96a994dc4bef97e7295dc0126dcfe73cf822fdab/components/crash/content/browser/crash_dump_manager_android_unittest.cc
[modify] https://crrev.com/96a994dc4bef97e7295dc0126dcfe73cf822fdab/components/data_reduction_proxy/content/browser/data_reduction_proxy_pingback_client_impl_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment