New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 846155 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Task

Blocking:
issue 734722



Sign in to add a comment

Rename ChildProcessSecurityPolicyImpl::LockToOrigin to LockToPrincipal

Project Member Reported by creis@chromium.org, May 23 2018

Issue description

CPSPI::LockToOrigin is used for locking a process to documents from a given set, but this varies in granularity.  With Site Isolation's SitePerProcess policy enabled, (almost) all processes are locked to a site (i.e., scheme + eTLD+1, such as https://google.com).  However, it's also possible to lock some processes to an origin (e.g., https://accounts.google.com) with IsolateOrigins, while other times a process may be locked to a broader category (e.g., file://, or perhaps chrome-extension:// in the future).  Thus, calling it LockToOrigin is confusing and inaccurate.

To eliminate confusion, we should rename it to LockToPrincipal, and eventually start moving more of the "site" terminology toward "principal" in general when it doesn't actually refer to a site (e.g., perhaps SiteInstance).

This came up in https://chromium-review.googlesource.com/c/chromium/src/+/1012502, where the actual "site" concept was important (vs cases where the lock might be broader than that).
 
Blocking: 734722
Note that we have an umbrella issue 734722 for moving the process model from sites to security principals, so I'll mark this as a blocker for that.

Sign in to add a comment