I'm going to switch to using chrome's crash reporter.

https://chromium-review.googlesource.com/#/c/chromium/src/+/1072205

OS-side change: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1072507

What a tap_visualizer_app crash looks like in crash console:
https://screenshot.googleplex.com/fB7gfT1EXW5
https://screenshot.googleplex.com/E5O2j0j0k61

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/783fdeb075c4ff023b1cb941537270ea988a625d

commit 783fdeb075c4ff023b1cb941537270ea988a625d
Author: James Cook <jamescook@chromium.org>
Date: Thu May 24 22:28:46 2018

chromeos: Use chrome's crash reporter for mash services

Mash services like tap_visualizer are launched as utility processes
so Chrome's crash reporting system works fine with them. Using chrome's
crash system gives us Chrome's version number for the crashes (which
makes sense, since the services are built into the chrome binary),
support for chrome-specific crash features like crash-keys, etc.

Override the process type with the service name so these crashes
show up independently in the crash console, similar to what we do for
extension renderers.

Bug:  846123 
Test: browser_tests, also kill -SEGV the tap_visualizer process and check reports
Change-Id: I133aedcf1f263beb2d349e9bc24e5b3624d03ea8
Reviewed-on: https://chromium-review.googlesource.com/1072205
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561656}
[modify] https://crrev.com/783fdeb075c4ff023b1cb941537270ea988a625d/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/783fdeb075c4ff023b1cb941537270ea988a625d/chrome/browser/chrome_content_browser_client_browsertest_chromeos.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/22204d7653709a51ef86049ca46cfdc37f5dffcf

commit 22204d7653709a51ef86049ca46cfdc37f5dffcf
Author: James Cook <jamescook@chromium.org>
Date: Tue May 29 02:58:31 2018

crash: Use chrome's crash reporter for mash services

Remove the special handling in crash_reporter for chrome
crashes that have the --mash-service-name command line
switch.

For out-of-process ash ("mustash") we're making small system
UI features run as out-of-process chrome mojo services. They
are launched as chrome utility processes, so chrome's crash
reporting system works fine with them.

Using chrome's crash system gives us chrome's version number
for the crashes (which makes sense because these services are
built into the chrome binary). It also gives us chrome-specific
features like crash-keys, chrome-specific UI in the crash
console, etc.

This is mostly a revert of:
https://chromium-review.googlesource.com/c/chromiumos/platform2/+/438796

BUG= chromium:846123 
TEST=existing unit tests, also turn on "Show Taps" in chrome's
about:flags, kill -SEGV the tap_visualizer process, and check
for chrome crash report on go/crash

Change-Id: I54cd8a1ff29edc8235024ae3a2fea84efd39f180
Reviewed-on: https://chromium-review.googlesource.com/1072507
Tested-by: James Cook <jamescook@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/22204d7653709a51ef86049ca46cfdc37f5dffcf/crash-reporter/user_collector.h
[modify] https://crrev.com/22204d7653709a51ef86049ca46cfdc37f5dffcf/crash-reporter/user_collector_test.cc
[modify] https://crrev.com/22204d7653709a51ef86049ca46cfdc37f5dffcf/crash-reporter/user_collector.cc

Requesting merge for CL in comment #4. The chrome side of this patch went in before the branch, but the OS side landed after the branch.

I have manually tested crash reporting in canary and it works fine, https://crash.corp.google.com/browse?q=reportid=%279530c366f165ffaf%27

Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/a0bfb06eb38668117d37b08d487e0e20bbaa8ab5

commit a0bfb06eb38668117d37b08d487e0e20bbaa8ab5
Author: James Cook <jamescook@chromium.org>
Date: Thu May 31 20:53:03 2018

crash: Use chrome's crash reporter for mash services

Remove the special handling in crash_reporter for chrome
crashes that have the --mash-service-name command line
switch.

For out-of-process ash ("mustash") we're making small system
UI features run as out-of-process chrome mojo services. They
are launched as chrome utility processes, so chrome's crash
reporting system works fine with them.

Using chrome's crash system gives us chrome's version number
for the crashes (which makes sense because these services are
built into the chrome binary). It also gives us chrome-specific
features like crash-keys, chrome-specific UI in the crash
console, etc.

This is mostly a revert of:
https://chromium-review.googlesource.com/c/chromiumos/platform2/+/438796

BUG= chromium:846123 
TEST=existing unit tests, also turn on "Show Taps" in chrome's
about:flags, kill -SEGV the tap_visualizer process, and check
for chrome crash report on go/crash

Change-Id: I54cd8a1ff29edc8235024ae3a2fea84efd39f180
Reviewed-on: https://chromium-review.googlesource.com/1072507
Tested-by: James Cook <jamescook@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
(cherry picked from commit 22204d7653709a51ef86049ca46cfdc37f5dffcf)
Reviewed-on: https://chromium-review.googlesource.com/1081033
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>

[modify] https://crrev.com/a0bfb06eb38668117d37b08d487e0e20bbaa8ab5/crash-reporter/user_collector.h
[modify] https://crrev.com/a0bfb06eb38668117d37b08d487e0e20bbaa8ab5/crash-reporter/user_collector_test.cc
[modify] https://crrev.com/a0bfb06eb38668117d37b08d487e0e20bbaa8ab5/crash-reporter/user_collector.cc

Release builders look happy post-merge.

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot