"TaskSchedulerWorkerTest.SchedulerWorkerObserver" is flaky |
||||
Issue description"TaskSchedulerWorkerTest.SchedulerWorkerObserver" is flaky. This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label. We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyOgsSBUZsYWtlIi9UYXNrU2NoZWR1bGVyV29ya2VyVGVzdC5TY2hlZHVsZXJXb3JrZXJPYnNlcnZlcgw. Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
,
May 24 2018
This test is created on https://chromium-review.googlesource.com/1062805
,
May 24 2018
The stack looks strange, though. Some GMock stuff is leaking? I don't know much about GMock, but EXPECT_CALL() of VerifyCallsToObserverDelegate ::OnMainExit() seems to be the culprit. Perhaps it can't be used at this stage of the test?
,
May 24 2018
For now I'm going to disable the test.
,
May 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/568d1b135d55b75dbed8f29bb6f0a627d26275c0 commit 568d1b135d55b75dbed8f29bb6f0a627d26275c0 Author: Yuta Kitamura <yutak@chromium.org> Date: Thu May 24 06:26:07 2018 Disable flaky test TaskSchedulerWorkerTest.SchedulerWorkerObserver. TBR=fhorschig@chromium.org,fdoray@chromium.org Bug: 846121 Change-Id: I8056ceedd453daf33f210cae953deb10a148cc26 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1071329 Reviewed-by: Yuta Kitamura <yutak@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#561402} [modify] https://crrev.com/568d1b135d55b75dbed8f29bb6f0a627d26275c0/base/task_scheduler/scheduler_worker_unittest.cc
,
May 24 2018
Test is disabled, reducing priority.
,
May 24 2018
Test is disabled, dropping from sheriffs queue |
||||
►
Sign in to add a comment |
||||
Comment 1 by yutak@chromium.org
, May 24 2018Error log: [ RUN ] TaskSchedulerWorkerTest.SchedulerWorkerObserver [ OK ] TaskSchedulerWorkerTest.SchedulerWorkerObserver (11 ms) [----------] 1 test from TaskSchedulerWorkerTest (11 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test case ran. (11 ms total) [ PASSED ] 1 test. ================================================================= ==18072==ERROR: LeakSanitizer: detected memory leaks Direct leak of 16 byte(s) in 1 object(s) allocated from: #0 0xb5ff72 in operator new(unsigned long) /b/build/slave/linux_upload_clang/build/src/third_party/llvm/compiler-rt/lib/asan/asan_new_delete.cc:93:3 #1 0x2d8665d in testing::internal::ThreadLocal<testing::Sequence*>::DefaultValueHolderFactory::MakeNewHolder() const third_party/googletest/src/googletest/include/gtest/internal/gtest-port.h:2224:57 #2 0xbd1e34 in testing::internal::ThreadLocal<testing::Sequence*>::GetOrCreateValue() const third_party/googletest/src/googletest/include/gtest/internal/gtest-port.h:2205:55 #3 0xbd289d in pointer third_party/googletest/src/googletest/include/gtest/internal/gtest-port.h:2171:37 #4 0xbd289d in get third_party/googletest/src/googletest/include/gtest/internal/gtest-port.h:2172 #5 0xbd289d in testing::internal::FunctionMockerBase<void ()>::AddNewExpectation(char const*, int, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::tuple<> const&) third_party/googletest/src/googlemock/include/gmock/gmock-spec-builders.h:1632 #6 0xbcf269 in testing::internal::MockSpec<void ()>::InternalExpectedAt(char const*, int, char const*, char const*) third_party/googletest/src/googlemock/include/gmock/gmock-spec-builders.h:1281:30 #7 0x23e980f in base::internal::(anonymous namespace)::VerifyCallsToObserverDelegate::OnMainExit(base::internal::SchedulerWorker*) base/task_scheduler/scheduler_worker_unittest.cc:791:5 #8 0x2fc4a03 in base::internal::SchedulerWorker::RunWorker() base/task_scheduler/scheduler_worker.cc:340:14 #9 0x2fc3d74 in base::internal::SchedulerWorker::RunDedicatedWorker() base/task_scheduler/scheduler_worker.cc:239:3 #10 0x3113f52 in base::(anonymous namespace)::ThreadFunc(void*) base/threading/platform_thread_posix.cc:76:13 #11 0x7faca8919183 in start_thread /build/eglibc-ripdx6/eglibc-2.19/nptl/pthread_create.c:312 SUMMARY: AddressSanitizer: 16 byte(s) leaked in 1 allocation(s).