HitTestQuery Not Always Updated |
||
Issue descriptionOS: Linux Test suite: content_browsertests Test: SitePerProcessHitTestBrowserTest.SurfaceHitTestTest/0 I'm on today's ToT and am seeing different results for HitTestQuery::OnAggregatedHitTestRegionListUpdated being called during the test. Flag States: No Flags: Never called --enable-features=VizDisplayCompositor: called --enable-features=VizHitTestDrawQuad: Not called, at least not within the time it takes for WaitForChildSurfaceReady to complete --enable-viz-hit-test-draw-quad: Same as above --use-viz-hit-test-surface-layer: Called both before and during WaitForChildFrameSurfaceReady
,
May 23 2018
Oh, with /0, viz hit-testing is disabled, i.e. the non-viz hit-testing is used. So this is WAI.
,
May 24 2018
For more context, the associated code is: https://cs.chromium.org/chromium/src/content/browser/site_per_process_hit_test_browsertest.cc?l=489 The purpose is to keep testing the non-viz hit-testing code, until viz hit-testing becomes the default on stable, in case we need to switch back to that for some reason. For the test-api for hit-test, I guess it needs to know to fallback to using WaitForChildFrameSurfaceReady() for non viz-hitesting cases. |
||
►
Sign in to add a comment |
||
Comment 1 by sadrul@chromium.org
, May 23 2018Owner: ----