Layout test results not shown on win_mojo trybot |
|||
Issue descriptionWe have an FYI bot https://ci.chromium.org/buildbot/chromium.fyi/Mojo%20Windows/?limit=200 that has an optional trybot https://ci.chromium.org/buildbot/tryserver.chromium.win/win_mojo/ This was added in https://chromium-review.googlesource.com/c/chromium/src/+/1035202, to match the Linux Mojo variants. The trybot doesn't show combined layout test results, i.e. see https://ci.chromium.org/buildbot/tryserver.chromium.win/win_mojo/113 which says "Total tests: n/a" The stdout shows the section at the bottom, but I'm not sure if that's the cause or another symptom, and how to fix it. Traceback (most recent call last): File "E:\b\c\b\win_mojo\src\third_party\blink\tools\merge_web_test_results.py", line 12, in <module> main(sys.argv[1:]) File "E:\b\c\b\win_mojo\src\third_party\blink\tools\blinkpy\web_tests\merge_results.py", line 823, in main merger.merge(args.output_directory, args.input_directories) File "E:\b\c\b\win_mojo\src\third_party\blink\tools\blinkpy\web_tests\merge_results.py", line 514, in merge merge_func(out_path, to_merge) File "E:\b\c\b\win_mojo\src\third_party\blink\tools\blinkpy\web_tests\merge_results.py", line 287, in __call__ self.filesystem.copyfile(to_merge[0], out_filename) File "E:\b\c\b\win_mojo\src\third_party\blink\tools\blinkpy\common\system\filesystem.py", line 84, in copyfile shutil.copyfile(source, destination) File "E:\b\depot_tools\win_tools-2_7_6_bin\python\bin\lib\shutil.py", line 82, in copyfile with open(src, 'rb') as fsrc: IOError: [Errno 2] No such file or directory: 'c:\\users\\chrome~2\\appdata\\local\\temp\\tmpc6z39g\\10\\layout-test-results\\virtual\\outofblink-cors\\external\\wpt\\referrer-policy\\strict-origin-when-cross-origin\\meta-referrer\\cross-origin\\http-https\\fetch-request\\upgrade-protocol.swap-origin-redirect.http-stderr.txt' WARNING:root:merge_cmd had non-zero return code: 1
,
May 23 2018
@martiniss - we should fix the merge script to not err out in this case, but rather display some sort of warning and move on.
,
May 23 2018
,
May 23 2018
Yeah the CL in #1 would solve this. dpranke@: Could you take a look at my reply to your comment in that CL? (I'm not inclined to require abspath, but open to change the name of the method.) https://chromium-review.googlesource.com/c/chromium/src/+/1064805/4/third_party/blink/tools/blinkpy/common/system/filesystem.py#62
,
May 23 2018
whoops, forgot that this was on me. commented. Though, 'win_mojo' is a comparatively short builder name. If it's breaking here, I'd guess that this is breaking all over the place?
,
May 23 2018
'win_mojo' isn't in the path; it's 'outofblink-cors', which is also pretty short... The tests in `wpt\referrer-policy` have some of the longest paths, some of them very close to the 150 limit imposed in WPT upstream. It's the temporary directory (on BuildBot, when merging results) that's too long. The test runs fine on Swarming.
,
May 23 2018
ah, ok. I forget that the tmpdir is outside of the build dir.
,
May 24 2018
The CL in #1 has landed. I kicked off some jobs on various Windows try bots including win_mojo and they all seemed fine. Marking the issue as fixed, but feel free to reopen if I missed something. |
|||
►
Sign in to add a comment |
|||
Comment 1 by martiniss@chromium.org
, May 23 2018