New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 846061 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

blink_perf.svg/SierpinskiCarpet.html in blink_perf.svg crashing on multiple builders

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, May 23 2018

Issue description

Cc: f...@opera.com kouhei@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, May 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4fffb41bc1da1bdafadb20c0f90fc7eb615a1a2d

commit 4fffb41bc1da1bdafadb20c0f90fc7eb615a1a2d
Author: Annie Sullivan <sullivan@chromium.org>
Date: Wed May 23 20:36:58 2018

Disable crashing SierpinskiCarpet story on Mac/Win.

Bug: 846061
Change-Id: Ibcfd0cda00575ee5d6717bbc0fc0bda6cfb4895e
TBR: charliea@chromium.org
NOTRY: true
Reviewed-on: https://chromium-review.googlesource.com/1070561
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561237}
[modify] https://crrev.com/4fffb41bc1da1bdafadb20c0f90fc7eb615a1a2d/tools/perf/expectations.config

Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, May 24 2018

Cc: hpayer@chromium.org
Owner: hpayer@chromium.org
Status: Assigned (was: Available)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/14e30802240000

[oilpan] Move CompleteSweep() to ScheduleGCIfNeeded() during allocation to play safe. by hpayer@chromium.org
https://chromium.googlesource.com/chromium/src/+/5fa0b1a7de7547cb02efdb970f85b9ff25000bc8

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Project Member

Comment 5 by bugdroid1@chromium.org, May 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c523fa4278f8fb9bf2ce4730851ab118e846c6d

commit 5c523fa4278f8fb9bf2ce4730851ab118e846c6d
Author: Hannes Payer <hpayer@chromium.org>
Date: Thu May 24 11:51:32 2018

Revert "[oilpan] Move CompleteSweep() to ScheduleGCIfNeeded() during allocation to play safe."

This reverts commit 5fa0b1a7de7547cb02efdb970f85b9ff25000bc8.

Reason for revert:
This is not correct since external memory reporting may 1) start an incremental V8 gc which 2) invokes wrapper tracing 3) which may fail if GC is forbidden, c.f. crbug/846093 I will look into this offline.

Bug: chromium:846093 , chromium:846061

Original change's description:
> [oilpan] Move CompleteSweep() to ScheduleGCIfNeeded() during allocation to play safe.
>
> CompleteSweep() needs to be called before we call ReportMemoryToV8(). This change
> makes this dependency more explicit.
>
> Change-Id: I044af54bcfdc8a7457edbb492fba6bfe4ff210aa
> Reviewed-on: https://chromium-review.googlesource.com/1069271
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
> Commit-Queue: Hannes Payer <hpayer@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#560987}

TBR=haraken@chromium.org,hpayer@chromium.org,mlippautz@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I06899e2e5bf0c4303afdd946fd3e6a99f2954530
Reviewed-on: https://chromium-review.googlesource.com/1071288
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hannes Payer <hpayer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561467}
[modify] https://crrev.com/5c523fa4278f8fb9bf2ce4730851ab118e846c6d/third_party/blink/renderer/platform/heap/thread_state.cc

Comment 6 by sullivan@google.com, May 24 2018

hpayer: should I re-enable the test now that you've reverted?

Sign in to add a comment