New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 846057 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 832309
issue 845268
issue 845337



Sign in to add a comment

"atest server --skylab" needs to support --json

Project Member Reported by nxia@chromium.org, May 23 2018

Issue description

--json is supported in "atest server" but not "atest server --skylab" now, will add the support.
 

Comment 1 by nxia@chromium.org, May 23 2018

Blocking: 845337

Comment 2 by nxia@chromium.org, May 23 2018

Blocking: 832309

Comment 3 by nxia@chromium.org, May 23 2018

the output will be a json format string of lab_pb2.Infrastructure which contains all the servers.
Blocking: 845268
Project Member

Comment 5 by bugdroid1@chromium.org, May 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/infra/skylab_inventory/+/7769c5287906216c81269d1e59ec1b48cc6f86f2

commit 7769c5287906216c81269d1e59ec1b48cc6f86f2
Author: Ningning Xia <nxia@google.com>
Date: Thu May 24 20:32:09 2018

Add method to format servers to json.

BUG= chromium:846057 
TEST='atest server list --json'

Change-Id: I58428902e506326466b9c709cd4d22c2f7e0310e
Reviewed-on: https://chromium-review.googlesource.com/1070671
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/7769c5287906216c81269d1e59ec1b48cc6f86f2/venv/skylab_inventory/lib/server.py

Project Member

Comment 6 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/32b266823efb2f27eeadb265b6a550ebb7becd37

commit 32b266823efb2f27eeadb265b6a550ebb7becd37
Author: Ningning Xia <nxia@google.com>
Date: Wed May 30 00:15:23 2018

Support 'atest server list --skylab' with '--json'

BUG= chromium:846057 
TEST=None
CQ-DEPEND=CL:1070671

Change-Id: I4ec17681c99295d826b67d7264130fb4b2e96c6e
Reviewed-on: https://chromium-review.googlesource.com/1070709
Commit-Ready: Ningning Xia <nxia@chromium.org>
Tested-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Allen Li <ayatane@chromium.org>

[modify] https://crrev.com/32b266823efb2f27eeadb265b6a550ebb7becd37/cli/server.py

Comment 7 by nxia@chromium.org, Jun 1 2018

Status: Fixed (was: Untriaged)

Sign in to add a comment