New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 846008 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

git cl format forces no space between "override" and "{"

Project Member Reported by junov@chromium.org, May 23 2018

Issue description

If you write:

   void myMethod() override {}

git cl format will "correct" it to:

   void myMethod() override{}

Not so old code is not like this, so this must be a recent regression in the formatting rules.

For example see this CR: https://chromium-review.googlesource.com/c/chromium/src/+/1067647
 

Comment 1 by junov@chromium.org, May 23 2018

Cc: fs...@chromium.org

Comment 2 by mar...@chromium.org, May 23 2018

Cc: thakis@chromium.org

Comment 3 by thakis@chromium.org, May 23 2018

Iirc that happens if you put a needless ; after {} -- remove it and things should work.

Comment 4 by thakis@chromium.org, May 23 2018

Status: WontFix (was: Untriaged)
Yup, looks like that's the problem in that cl. See above for how to fix.

Comment 5 by junov@chromium.org, May 29 2018

Ah. Thanks!

Sign in to add a comment