New issue
Advanced search Search tips
Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocking:
issue 845389


Participants' hotlists:
Worker-Reliability


Sign in to add a comment
link

Issue 845979: ServiceWorkerBackgroundSyncTest tests are flaky in Views mode

Reported by ellyjo...@chromium.org, May 23 2018 Project Member

Issue description

These three tests are flaky:

ServiceWorkerBackgroundSyncTestWithJSBindings/ServiceWorkerBackgroundSyncTest.Sync/0
ServiceWorkerBackgroundSyncTestWithNativeBindings/ServiceWorkerBackgroundSyncTest.Sync/0
ServiceWorkerTestWithNativeBindings/ServiceWorkerTest.TabsCreate/0

I suspect some of the other ServiceWorker tests are flaky as well.

I added a bunch of debug logging, and it seems like in passing runs, the javascript runServiceWorker() function executes *before* BackgroundSyncManager::EventCompleteImpl(), but in failing runs, it executes after and the test hangs forever. I suspect that some kind of event is supposed to be signalled that relies on ::EventCompleteImpl() happening last.
 

Comment 1 by ellyjo...@chromium.org, May 23 2018

Owner: falken@chromium.org
Over to falken@ on advice from rockot@ :)

Comment 2 by falken@chromium.org, May 24 2018

Cc: falken@chromium.org
Components: Blink>ServiceWorker Platform>Extensions
Owner: lazyboy@chromium.org
There are some long-running flakes with extension service workers:
 bug 774606 
 bug 834200 
 bug 844821 

Comment 3 by bugdroid1@chromium.org, May 30 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a4f21d6b619eb9baeed4a88976d87d0cfc5a419

commit 4a4f21d6b619eb9baeed4a88976d87d0cfc5a419
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Wed May 30 15:04:16 2018

mac: disable ServiceWorker API tests

These tests are flaky on Mac, especially in Views mode.

Bug:  845979 
Change-Id: Idb2125c8ce24595e501df8544609f0c6e6dd8957
Reviewed-on: https://chromium-review.googlesource.com/1070338
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562824}
[modify] https://crrev.com/4a4f21d6b619eb9baeed4a88976d87d0cfc5a419/chrome/browser/extensions/service_worker_apitest.cc

Comment 4 by robliao@chromium.org, Jul 12 2018

Labels: -M-69 Group-Tests

Comment 5 by robliao@chromium.org, Jul 12 2018

Labels: M-69

Comment 6 by robliao@chromium.org, Jul 26 2018

Labels: -M-69 -Target-69 M-70 Target-70

Comment 7 by thakis@chromium.org, Oct 3

what's the status here?

Comment 8 by thakis@google.com, Oct 11

Blocking: 845389

Comment 9 by bugdroid1@chromium.org, Jan 12

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/efad1853b1aaf33aa3568807b363b56a0a16d194

commit efad1853b1aaf33aa3568807b363b56a0a16d194
Author: Matt Falkenhagen <falken@chromium.org>
Date: Sat Jan 12 02:03:30 2019

extensions: service worker: Reenable some tests on Mac Views.

Speculatively reenabling. The flakiness was probably fixed a while back
in  https://crbug.com/879015 .

Bug:  845979 
Change-Id: If795a5d0e1bd78d77bea5242336fdfcf063ef475
Reviewed-on: https://chromium-review.googlesource.com/c/1402974
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622261}
[modify] https://crrev.com/efad1853b1aaf33aa3568807b363b56a0a16d194/chrome/browser/extensions/service_worker_apitest.cc

Comment 10 by falken@chromium.org, Jan 16

Status: Fixed (was: Assigned)
Haven't heard of test failures, so marking fixed. Probably fixed via  bug 879015 .

Comment 11 by falken@chromium.org, Jan 16

Labels: Hotlist-Reliability

Sign in to add a comment