New issue
Advanced search Search tips

Issue 845966 link

Starred by 3 users

Issue metadata

Status: Duplicate
Merged: issue 777660
Owner: ----
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

[MacViews] Migrate first-run dialog from Cocoa to Views.

Project Member Reported by w...@chromium.org, May 23 2018

Issue description

The first-run dialog is currently hard-wired at build time to use the Cocoa implementation, rather than choosing at run-time based on whether MacViews is enabled.

We should get the Views implementation of the dialog working and make it switchable at run-time in advance of the full migration to MacViews.
 

Comment 1 by tapted@chromium.org, May 23 2018

Cc: ellyjo...@chromium.org
This can possibly be duped into Issue 777660. But note I'm not 100% sure we should do this for Mac (see comments in Issue 777660). i.e. There are arguments for keeping this dialog native.
Mergedinto: 777660
Status: Duplicate (was: Untriaged)
Triage: Looking through Issue 777660, that seems to strongly apply as the dialog is going away. Feel free to undupe if I missed something.
Project Member

Comment 3 by bugdroid1@chromium.org, May 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25fd35f2fb3113198c239b3b99ea732b4d3a43c6

commit 25fd35f2fb3113198c239b3b99ea732b4d3a43c6
Author: Wez <wez@chromium.org>
Date: Fri May 25 22:57:41 2018

Quit browser RunLoop via injected Closure rather than via QuitCurrent*.

Use of QuitCurrent*Deprecated() is ambiguous, since RunLoops can be
nested, and so is unsafe to use in general.

TBR: bartfab
Bug:  845966 ,  844016 , 749312
Change-Id: I537862ea02c4ed67887db32993f40e53f614b3cd
Reviewed-on: https://chromium-review.googlesource.com/1019967
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562046}
[modify] https://crrev.com/25fd35f2fb3113198c239b3b99ea732b4d3a43c6/chrome/browser/apps/app_shim/app_shim_quit_interactive_uitest_mac.mm
[modify] https://crrev.com/25fd35f2fb3113198c239b3b99ea732b4d3a43c6/chrome/browser/apps/app_window_interactive_uitest.cc
[modify] https://crrev.com/25fd35f2fb3113198c239b3b99ea732b4d3a43c6/chrome/browser/browser_process_impl.cc
[modify] https://crrev.com/25fd35f2fb3113198c239b3b99ea732b4d3a43c6/chrome/browser/browser_process_impl.h
[modify] https://crrev.com/25fd35f2fb3113198c239b3b99ea732b4d3a43c6/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/25fd35f2fb3113198c239b3b99ea732b4d3a43c6/chrome/browser/chrome_browser_main.h
[modify] https://crrev.com/25fd35f2fb3113198c239b3b99ea732b4d3a43c6/chrome/browser/chromeos/login/auto_launched_kiosk_browsertest.cc
[modify] https://crrev.com/25fd35f2fb3113198c239b3b99ea732b4d3a43c6/chrome/browser/chromeos/login/kiosk_browsertest.cc
[modify] https://crrev.com/25fd35f2fb3113198c239b3b99ea732b4d3a43c6/chrome/browser/chromeos/login/oobe_browsertest.cc
[modify] https://crrev.com/25fd35f2fb3113198c239b3b99ea732b4d3a43c6/chrome/browser/chromeos/policy/device_system_use_24hour_clock_browsertest.cc
[modify] https://crrev.com/25fd35f2fb3113198c239b3b99ea732b4d3a43c6/chrome/browser/chromeos/policy/display_rotation_default_handler_browsertest.cc
[modify] https://crrev.com/25fd35f2fb3113198c239b3b99ea732b4d3a43c6/chrome/browser/chromeos/policy/unaffiliated_arc_allowed_browsertest.cc
[modify] https://crrev.com/25fd35f2fb3113198c239b3b99ea732b4d3a43c6/chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_browsertest.cc
[modify] https://crrev.com/25fd35f2fb3113198c239b3b99ea732b4d3a43c6/chrome/browser/chromeos/shutdown_policy_browsertest.cc
[modify] https://crrev.com/25fd35f2fb3113198c239b3b99ea732b4d3a43c6/chrome/browser/ui/cocoa/first_run_dialog.mm
[modify] https://crrev.com/25fd35f2fb3113198c239b3b99ea732b4d3a43c6/chrome/browser/ui/tab_modal_confirm_dialog_browsertest.cc
[modify] https://crrev.com/25fd35f2fb3113198c239b3b99ea732b4d3a43c6/chrome/test/base/in_process_browser_test.cc
[modify] https://crrev.com/25fd35f2fb3113198c239b3b99ea732b4d3a43c6/chrome/test/base/in_process_browser_test.h

Cc: vamshi.kommuri@chromium.org
Labels: Needs-Feedback
Tried checking the issue on latest canary 69.0.3443.0 using Mac 10.13.1 and Ubuntu 14.04.
 
Our Observations:
-----------------
We observed first check box unchecked(Attaching screen shot) in the older version 63.0.3236.0 (...From Issue 777660) in comment#1 and the it's(First checkbox) checked in the latest version. 

@Wez: As we are not very sure about the expected behaviour, could you please help us in verifying the fix and let us know if anything missed from our end in the process.
Older Version.png
93.3 KB View Download
Latest Version.png
94.6 KB View Download

Comment 5 by w...@chromium.org, May 29 2018

Labels: -Needs-Feedback
Re #4: There is nothing to test here; this bug was just closed as a duplicate of issue 777660, which is still open, AFAIK.

Sign in to add a comment