New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 845962 link

Starred by 3 users
Status: Verified
Owner:
█ bartfab@chromium.org
Working on ARC now
Closed: May 2018
Cc:
kinaba@chromium.org
Components:
EstimatedDays: 1
NextAction: 2018-05-23
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Change B&R and GLS policy defaults

Project Member Reported by bartfab@chromium.org, May 23 2018 
Android Backup & Restore and Google Location Services are controlled by prefs which can be overridden by policies. By default, the prefs are user controlled, so that a dialog comes up when ARC++ is first run, asking the user whether to use B&R and GLS.

We want to change this so that B&R and GLS are disabled by default and the dialog is suppressed for enterprise users. This could be done today by setting the corresponding policies to |false|. But the FR is to have this be the default behavior when the policies are not set. To achieve this, we will do the following:

* Retire the Boolean ArcBackupRestoreEnabled and ArcLocationServiceEnabled policies
* Add new int-enum policies ArcBackupRestoreServiceEnabled and ArcGoogleLocationServicesEnabled

The new policies will take three values:
* unset -> feature disabled
* 0 -> feature disabled
* 1 -> feature under user control

Unlike all prior policies, the policy must be explicitly set to have the pref unmanaged. The default behavior for managed users will be that the pref is managed and forced to off.
Project Member

Comment 1 by bugdroid1@chromium.org, May 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6979a6d0525cd8a32743bc8ded5463e475111b7e

commit 6979a6d0525cd8a32743bc8ded5463e475111b7e
Author: Bartosz Fabianowski <bartfab@google.com>
Date: Thu May 24 13:29:20 2018

Change B&R and GLS policy defaults

This CL replaces the Boolean B&R and GLS policies with new int-enum
policies. Unlike all policies before, these take control of their
corresponding prefs *even when unset*. Only when explicitly set to
"put the user in control" do these policies relinquish control of
the prefs and allow the user to toggle the features on/off.

Bug:  845962 
Test: ArcServicePolicyHandlerTest and existing browser and unit tests
Change-Id: I653a350326ae56bf26b85c01bcf3041923f52eaa
Reviewed-on: https://chromium-review.googlesource.com/1068189
Commit-Queue: Bartosz Fabianowski <bartfab@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561484}
[modify] https://crrev.com/6979a6d0525cd8a32743bc8ded5463e475111b7e/chrome/browser/chromeos/arc/intent_helper/arc_settings_service_browsertest.cc
[modify] https://crrev.com/6979a6d0525cd8a32743bc8ded5463e475111b7e/chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.cc
[modify] https://crrev.com/6979a6d0525cd8a32743bc8ded5463e475111b7e/chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.h
[modify] https://crrev.com/6979a6d0525cd8a32743bc8ded5463e475111b7e/chrome/browser/chromeos/policy/configuration_policy_handler_chromeos_unittest.cc
[modify] https://crrev.com/6979a6d0525cd8a32743bc8ded5463e475111b7e/chrome/browser/policy/configuration_policy_handler_list_factory.cc
[modify] https://crrev.com/6979a6d0525cd8a32743bc8ded5463e475111b7e/chrome/browser/policy/policy_browsertest.cc
[modify] https://crrev.com/6979a6d0525cd8a32743bc8ded5463e475111b7e/chrome/test/data/policy/policy_test_cases.json
[modify] https://crrev.com/6979a6d0525cd8a32743bc8ded5463e475111b7e/components/policy/resources/policy_templates.json
[modify] https://crrev.com/6979a6d0525cd8a32743bc8ded5463e475111b7e/tools/metrics/histograms/enums.xml

Comment 2 by bartfab@chromium.org, May 24 2018

Status: Fixed (was: Started)

Comment 3 by jingwee@chromium.org, Jun 2 2018 

Would there be a timeline that the new policies ArcBackupRestoreServiceEnabled and ArcGoogleLocationServicesEnabled be available on Cpanel or YAPS?

Comment 4 by jingwee@chromium.org, Jun 5 2018

Status: Verified (was: Fixed)
Verified working in M68.0.3440.15 10718.13.0 dev paine in YAPS environment. Setting ArcBackupRestoreServiceEnabled and ArcGoogleLocationServicesEnabled to 1 allow user control on B&R and CLS services and the default is disabled as seen in the consent screen.

Comment 5 by kinaba@chromium.org, Jul 3

Cc: kinaba@chromium.org
Now it looks to me the latest behavior is that the preferences are no more user-controllable for *unmanaged/non-enterprise* users (since the policy values are never set for them.)
Is this intended behavior?


(I'm not particularly interested in the product-level decision of the feature, but I'm now trying to enable location service in tests (well, in particular, CTS) and my most naive approach seems blocked by this policy hence asking here.)

Comment 6 by bartfab@chromium.org, Jul 3 

Re #5: That's known  bug 849867 . I fixed it in M69 already and will be merging to M68 soon.

Comment 7 by kinaba@chromium.org, Jul 3 

Thanks, great! That makes my life a lot easier.
►

Sign in to add a comment