I've traditionally pasted images from Chrome into a messenger application, but I tested it now by pasting into Microsoft Word, and the image is not pasted. Only whatever I had previously in my clipboard is pasted.

It is not an app locking the clipboard. I tested it on a second home computer, Windows 7 64-bit with Chrome 66, and it too could not paste an image into Microsoft Word using Ctrl+C, including in incognito mode.

Using https://www.google.com/images/branding/googlelogo/2x/googlelogo_color_272x92dp.png
Bisected to 0a9dcf3d5aa4e5de4ac65b40fb7f85ebfc168eb6 = https://crrev.com/c/924027 by hugoh@vewd.com
"Don't copy hidden selections"
Landed in 66.0.3351.0

Looks like no one thought about this use case.

Able to reproduce this issue on reproduce this issue on reported version 66.0.3359.181 and latest canary 68.0.3438.0 using Linux, windows and mac with https://www.google.com/images/branding/googlelogo/2x/googlelogo_color_272x92dp.png.

Good Build: 66.0.3350.0
Bad Build: 66.0.3351.0

Suspecting https://crrev.com/c/924027 from change above changelog.

As author of above cl @hugoh@vewd's Last visit > 30 days ago assigning to one of reviewer xiaochengh@
@xiaochengh: Please confirm the bug and help in re-assigning if this is not related to your change. Adding RB-Stable for M-66. Please remove if not the case.

NOTE: This issue looks similar to  Issue 838808 . cc'ing @paulirish from that bug

As this is regressed in M66 stable and we're very close to M67 stable promotion,  we won't consider this as M67 Stable blocker. Pls let us know ASAP if there is any concern here. Thank you.

Also Similar  issue 838803  is not a Stable blocker , pls see: https://bugs.chromium.org/p/chromium/issues/detail?id=838808#c15.

I *can* copy if I first do CTRL+A:

1. Go to a direct URL of an image file
X. Press CTRL+A 
2. Press Ctrl+C

I believe Chrome won't copy the image, simply because it isn't selected. Looks like Firefox behaves in the same way?

In Firefox and IE pressing Ctrl-A applies visual selection cue, not in Chrome, so it's a very hard-to-guess kludge, especially since the behavior was abruptly changed after 8 years.

I agree. I think Chrome ought to highlight (=blue shading) such selected images too.

I'm 85% sure this bug doesn't have to do with my  Issue 838808 , as it was a Mac-only change.

That aside, @hugoh: it sounds like you support reverting https://crrev.com/c/924027 for now?

I'll merge a revert of crrev.com/c/924027 to M67.

For M68 and later versions, +1 to hugoh@'s proposal.

How safe is the revert to merge to M67? Also this is regressed in M66, why it is critical to merge the revert to M67 which is going to stable next week?

I've found that clicking in the page window then pressing Ctrl+C allows it to work. Before, I didn't need to click in the page window. Simply opening the new tab and having the browser window active was enough. But now I need to click inside the tab window for Ctrl+C to work.

Discussed offline with govind@.

We are NOT merging a revert to M67 due to risk concerns. So we'll only target M68 Stable.

I'll try to fix it there.

Removing "Target-67" per comment #7, #8 and #17.

Actually, we can fix this without creating any other user observable change.

Blink has a fast path for copying image documents:

- Editor::CanCopy() returns true directly if it's image document
- ClipboardCommands::ExecuteCopy() used to (before crrev.com/c/924027) copy the image directly if it's image document, without checking selection or focus

So when trying to blocking copy commands on hidden selection, we just don't block copy command if it's image document.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bbc2ac0d33c867859071da273d3a3c3562e89b80

commit bbc2ac0d33c867859071da273d3a3c3562e89b80
Author: Xiaocheng Hu <xiaochengh@chromium.org>
Date: Fri May 25 20:15:42 2018

(Re)allow copying image documents directly

In https://crrev.com/c/924027, we blocked copy command if selection is
hidden, but also incidentally broke copying on image documents because:
- We don't have visible selection on image document
- Copying on image document is done via a fast path that doesn't check
  selection at all, but the CL blocked the fast path

This patch moves the fast path before checking selection visibility,
so that the original copy behavior on image documents is recovered.

Bug:  845957 
Change-Id: I920198d13ab3aa387f550c5c213fcbadc42fd43e
Reviewed-on: https://chromium-review.googlesource.com/1072730
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561989}
[modify] https://crrev.com/bbc2ac0d33c867859071da273d3a3c3562e89b80/third_party/blink/renderer/core/editing/commands/clipboard_commands.cc
[modify] https://crrev.com/bbc2ac0d33c867859071da273d3a3c3562e89b80/third_party/blink/renderer/core/exported/web_frame_test.cc

Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Able to reproduce this issue on reported version, hence verifying the fix on latest canary 69.0.3443.0 using Mac 10.13.3, Windows 10 and Ubuntu 14.04.

Now observing image being pasted into sheets. Attaching screencast for reference.

As fix is working as expected, adding verified labels.

Thanks!

Deleted: 845957.mp4 636 KB

	845957.mp4 636 KB View Download

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6ac28e0cf9ed81936251f818db38a5b3fd11114

commit c6ac28e0cf9ed81936251f818db38a5b3fd11114
Author: Xiaocheng Hu <xiaochengh@chromium.org>
Date: Mon May 28 18:04:02 2018

(Re)allow copying image documents directly

In https://crrev.com/c/924027, we blocked copy command if selection is
hidden, but also incidentally broke copying on image documents because:
- We don't have visible selection on image document
- Copying on image document is done via a fast path that doesn't check
  selection at all, but the CL blocked the fast path

This patch moves the fast path before checking selection visibility,
so that the original copy behavior on image documents is recovered.

Bug:  845957 
Change-Id: I920198d13ab3aa387f550c5c213fcbadc42fd43e
Reviewed-on: https://chromium-review.googlesource.com/1072730
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#561989}(cherry picked from commit bbc2ac0d33c867859071da273d3a3c3562e89b80)
Reviewed-on: https://chromium-review.googlesource.com/1075687
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#13}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/c6ac28e0cf9ed81936251f818db38a5b3fd11114/third_party/blink/renderer/core/editing/commands/clipboard_commands.cc
[modify] https://crrev.com/c6ac28e0cf9ed81936251f818db38a5b3fd11114/third_party/blink/renderer/core/exported/web_frame_test.cc

@sindhu.chelamcherla@chromium.org I noticed in your video, you clicked on the image in the tab. This was not a proof of a fix. The problem was that I couldn't simply open an image file and then use Ctrl+C to copy it.

However, I installed Chrome Canary and tested it myself, and I can confirm that this bug has been fixed.