Hook up global cert fetchers when the network service is enabled. |
|||
Issue descriptionIOThread makes two calls to set up global cert/OCSP/etc fetchers on different platforms (SetURLRequestContextForNSSHttpIO and SetGlobalCertNetFetcher). We need to call these in the network process when the network service is enabled as well. These methods must be called on the system URLREquestContext before any other URLRequestContexts are created, and all other URLRequestContexts must be destroyed before we clear the globals, which must be cleared before the system URLRequestContext is destroyed. These requirements are a bit onerous, but shouldn't be too hard to implement, if we add a method to ContentBrowserClient to be invoked whenever the network service is started / restarted, and have that initialize the system URLRequestContext.
,
May 23 2018
The above CL was supposed to link to 845942 (Though it was motivated by the fix for this issue).
,
May 31 2018
,
Jun 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ae4fdb1c1ff92a8d6ea3ef586097e0428848d56b commit ae4fdb1c1ff92a8d6ea3ef586097e0428848d56b Author: Matt Menke <mmenke@chromium.org> Date: Sat Jun 02 06:32:54 2018 NetworkService: Hook up global cert fetchers. Add a parameter to NetworkContextParams that, when set, causes the NetworkContext to call SetGlobalCertNetFetcher / SetURLRequestContextForNSSHttpIO on its URLRequestContext. Since the URLRequestContext used to fetch certs must be created first and destroyed last, this CL also refactors NetworkContext lifetime and ownership so that the NetworkService can enforce that constraint, and makes sure that the SystemNetworkContext is created before any others. This CL also incidentally fixes issue 845772 , which is than when the NetworkService is restarted and QUIC was disabled previously, QUIC wouldn't be re-disabled until the SystemNetworkContext was re-created. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ie56241c514337f28dfc41faba407580360814b11 Bug: 845939 , 845772 Reviewed-on: https://chromium-review.googlesource.com/1067959 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by: Emily Stark <estark@chromium.org> Reviewed-by: Eric Roman <eroman@chromium.org> Reviewed-by: John Budorick <jbudorick@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#563933} [modify] https://crrev.com/ae4fdb1c1ff92a8d6ea3ef586097e0428848d56b/build/android/pylib/local/device/local_device_gtest_run.py [modify] https://crrev.com/ae4fdb1c1ff92a8d6ea3ef586097e0428848d56b/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/ae4fdb1c1ff92a8d6ea3ef586097e0428848d56b/chrome/browser/chrome_content_browser_client.h [modify] https://crrev.com/ae4fdb1c1ff92a8d6ea3ef586097e0428848d56b/chrome/browser/io_thread.cc [modify] https://crrev.com/ae4fdb1c1ff92a8d6ea3ef586097e0428848d56b/chrome/browser/net/profile_network_context_service.cc [modify] https://crrev.com/ae4fdb1c1ff92a8d6ea3ef586097e0428848d56b/chrome/browser/net/system_network_context_manager.cc [modify] https://crrev.com/ae4fdb1c1ff92a8d6ea3ef586097e0428848d56b/chrome/browser/net/system_network_context_manager.h [modify] https://crrev.com/ae4fdb1c1ff92a8d6ea3ef586097e0428848d56b/content/browser/network_service_instance.cc [modify] https://crrev.com/ae4fdb1c1ff92a8d6ea3ef586097e0428848d56b/content/public/browser/content_browser_client.cc [modify] https://crrev.com/ae4fdb1c1ff92a8d6ea3ef586097e0428848d56b/content/public/browser/content_browser_client.h [modify] https://crrev.com/ae4fdb1c1ff92a8d6ea3ef586097e0428848d56b/services/network/BUILD.gn [modify] https://crrev.com/ae4fdb1c1ff92a8d6ea3ef586097e0428848d56b/services/network/network_context.cc [modify] https://crrev.com/ae4fdb1c1ff92a8d6ea3ef586097e0428848d56b/services/network/network_context.h [modify] https://crrev.com/ae4fdb1c1ff92a8d6ea3ef586097e0428848d56b/services/network/network_service.cc [modify] https://crrev.com/ae4fdb1c1ff92a8d6ea3ef586097e0428848d56b/services/network/network_service.h [modify] https://crrev.com/ae4fdb1c1ff92a8d6ea3ef586097e0428848d56b/services/network/network_service_unittest.cc [modify] https://crrev.com/ae4fdb1c1ff92a8d6ea3ef586097e0428848d56b/services/network/public/mojom/network_context.mojom [modify] https://crrev.com/ae4fdb1c1ff92a8d6ea3ef586097e0428848d56b/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
,
Jun 2 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, May 23 2018