New issue
Advanced search Search tips

Issue 845929 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[Payments] Instrument icons are of fixed ratio (makes squares look squashed)

Project Member Reported by ma...@chromium.org, May 23 2018

Issue description

Some instrument icons are square (Payment Handlers). 

The Payment Request sheet and some screens show the icons at a fixed 32x20 ratio.


 
Screen Shot 2018-05-23 at 11.08.17 AM.png
47.2 KB View Download

Comment 1 by ma...@chromium.org, May 29 2018

Owner: ma...@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2fafb96a5ee17ccb46dc192be927d6ece73da39

commit a2fafb96a5ee17ccb46dc192be927d6ece73da39
Author: Mathieu Perreault <mathp@chromium.org>
Date: Wed May 30 11:16:03 2018

[Payments] Use a square ratio for payment instruments that are not credit cards

In the Payment Request sheet, icons should show as square and not squashed.

Bug:  845929 
Change-Id: I619f015d12e98d7cf8125a6cb8c99566e40f1d63
Reviewed-on: https://chromium-review.googlesource.com/1077450
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562798}
[modify] https://crrev.com/a2fafb96a5ee17ccb46dc192be927d6ece73da39/chrome/browser/ui/views/payments/payment_method_view_controller.cc
[modify] https://crrev.com/a2fafb96a5ee17ccb46dc192be927d6ece73da39/chrome/browser/ui/views/payments/payment_request_views_util.cc
[modify] https://crrev.com/a2fafb96a5ee17ccb46dc192be927d6ece73da39/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc

Comment 3 by ma...@chromium.org, May 30 2018

Labels: -M-69 M-68 Merge-Request-68
Status: Fixed (was: Started)
Project Member

Comment 4 by sheriffbot@chromium.org, May 31 2018

Labels: -Merge-Request-68 Hotlist-Merge-Approved Merge-Approved-68
Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, May 31 2018

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc5c21de66e2861a5fe846ade84ee526c0e5d714

commit dc5c21de66e2861a5fe846ade84ee526c0e5d714
Author: Mathieu Perreault <mathp@chromium.org>
Date: Thu May 31 11:59:36 2018

[Payments] Use a square ratio for payment instruments that are not credit cards

In the Payment Request sheet, icons should show as square and not squashed.

TBR=mathp@chromium.org

(cherry picked from commit a2fafb96a5ee17ccb46dc192be927d6ece73da39)

Bug:  845929 
Change-Id: I619f015d12e98d7cf8125a6cb8c99566e40f1d63
Reviewed-on: https://chromium-review.googlesource.com/1077450
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#562798}
Reviewed-on: https://chromium-review.googlesource.com/1080256
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#59}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/dc5c21de66e2861a5fe846ade84ee526c0e5d714/chrome/browser/ui/views/payments/payment_method_view_controller.cc
[modify] https://crrev.com/dc5c21de66e2861a5fe846ade84ee526c0e5d714/chrome/browser/ui/views/payments/payment_request_views_util.cc
[modify] https://crrev.com/dc5c21de66e2861a5fe846ade84ee526c0e5d714/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc

Labels: TE-Verified-M69 TE-Verified-69.0.3446.0
Able to reproduce the issue on Mac 10.13.3 using chrome build without fix.

Verified the fix on Mac 10.13.3, Win-10 and Ubuntu 17.10 using Chrome version #69.0.3446.0 as per the comment #0.
Attaching screen shots for reference.
Observed that the Payment Request sheet, icons showed as square and not squashed.
Hence, the fix is working as expected. 
Adding the verified labels.

Thanks...!!
Attaching screen shots
chrome_version@M69.0.3446.0.png
555 KB View Download
845929@bobpay.png
195 KB View Download

Sign in to add a comment