Remove default-enabled flag for minnie |
||||||||||
Issue descriptionThe team has decided not to launch on minnie.
,
May 23 2018
To clarify, the team is not focusing on launching for minnie in M68. The team may still decide to launch on minnie in the future.
,
May 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/b6947a6f342d6089bd2ad269c03b814bbee66836 commit b6947a6f342d6089bd2ad269c03b814bbee66836 Author: Ryan Hansberry <hansberry@chromium.org> Date: Thu May 24 11:10:08 2018 minnie: Remove Instant Tethering support. BUG= chromium:845928 TEST=None Change-Id: Ieaed118c79cf4299ad2fd9c842c6dd4bc5539062 Reviewed-on: https://chromium-review.googlesource.com/1070318 Commit-Ready: Ryan Hansberry <hansberry@chromium.org> Tested-by: Ryan Hansberry <hansberry@chromium.org> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/b6947a6f342d6089bd2ad269c03b814bbee66836/overlay-variant-veyron-minnie/make.conf
,
May 24 2018
,
May 24 2018
[Auto-generated comment by a script] We noticed that this issue is targeted for M-68; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-68 label, otherwise remove Merge-TBD label. Thanks.
,
May 24 2018
This does need to be part of M-68. Please let us know if a merge is required.
,
May 24 2018
This bug requires manual review: We don't branch M68 until 2018-05-24. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 28 2018
This issue is marked as a release blocker with no OS labels associated. Please add an appropriate OS label. All release blocking issues should have OS labels associated to it, so that the issue can tracked and promptly verified, once it gets fixed. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
May 29 2018
,
May 29 2018
,
May 31 2018
It looks like the automated blockerbot@ comment may actually have been incorrect. The CL addressing this issue landed in 10716.0.0 (verified on goldeneye: https://crosland.corp.google.com/log/10715.0.0..10716.0.0) which is in 68, according to goldeneye (therefore there is no need to merge into 68). The command $ cros_merge_to_branch 1070318 R68 Fails with "Upload failed with CL:1070318 had no changes after rebasing to the current patch series." Bernie, would you mind confirming if I'm right that this fix landed in 68 and therefore a merge isn't necessary? Thank you!
,
Jun 1 2018
Confirmed with Bernie offline that this fix successfully landed in M68 and does not need to be merged in (Thanks Bernie!). Nothing else needs to be done; closing this bug.
,
Jun 4 2018
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 5 2018
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by khorimoto@chromium.org
, May 23 2018