Issue 845909 link

Starred by 2 users

Issue metadata

Status:	Fixed
Owner:	georgesak@chromium.org
Closed:	Sep 20
Cc:	█ mad@chromium.org
EstimatedDays:	----
NextAction:	----
OS:	Windows
Pri:	1
Type:	Bug

Chrome reports the signed in user name instead of the profile name

Project Member Reported by georgesak@chromium.org, May 23 2018

Issue description

It uses: profile->GetProfileUserName(), which is documented as:
the username associated with this profile, if any. In non-test implementations, this is usually the Google-services email address.

When it should use: profile->GetPrefs()->GetString(prefs::kProfileName)

Project Member

Comment 1 by bugdroid1@chromium.org, May 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66bfbb452d65cc35aa1c48c95cfc49843dc95841

commit 66bfbb452d65cc35aa1c48c95cfc49843dc95841
Author: Georges Khalil <georgesak@chromium.org>
Date: Wed May 23 15:58:40 2018

Fix profile name for reporting.

BUG= 845909 

Change-Id: I8d697a1b6204927e8b3b96c6959b31bf879bde9f
Reviewed-on: https://chromium-review.googlesource.com/1069005
Reviewed-by: Marc-André Decoste <mad@chromium.org>
Commit-Queue: Georges Khalil <georgesak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561107}
[modify] https://crrev.com/66bfbb452d65cc35aa1c48c95cfc49843dc95841/chrome/browser/extensions/api/enterprise_reporting_private/chrome_desktop_report_request_helper.cc
[modify] https://crrev.com/66bfbb452d65cc35aa1c48c95cfc49843dc95841/chrome/browser/extensions/api/enterprise_reporting_private/chrome_desktop_report_request_helper_unittest.cc

Comment 2 by pastarmovj@chromium.org, Sep 20

Is this fixed already?

Comment 3 by mad@chromium.org, Sep 20

Status: Fixed (was: Started)

Yep, a quick look at a browser details page demonstrates it. :-)

►

Issue 845909 link

Issue metadata

Chrome reports the signed in user name instead of the profile name

Issue description

Comment 1 by bugdroid1@chromium.org, May 23 2018

Comment 1 Deleted

Comment 2 by pastarmovj@chromium.org, Sep 20

Comment 2 Deleted

Comment 3 by mad@chromium.org, Sep 20

Comment 3 Deleted

Sign in to add a comment