New issue
Advanced search Search tips

Issue 845894 link

Starred by 3 users

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Opening a new window from a sandbox creates a permanently-sandboxed tab

Project Member Reported by iclell...@chromium.org, May 23 2018

Issue description

Chrome Version: (copy from chrome://version)
OS: (e.g. Win10, MacOS 10.12, etc...)

Seen in ToT and 66

What steps will reproduce the problem?
(1) Create a sandboxed frame (iframe or top-level, doesn't matter) with allow-popups
(2) Add an <a target="_blank" href="{anywhere}"> tag.
(3) Click the link
(4) Observe that the new page is properly sandboxed
(5) Type a new URL into the omnibox

What is the expected result?

New URL should replace existing contents of the tab, and the new contents should not be sandboxed.

What happens instead?

The new page is also sandboxed. Any page loaded into that frame will be sandboxed, even as a result of the user *typing a new URL* into the omnibox. Searching from the omnibox will not work, as there is an interstitial before the results page which requires JavaScript to redirect.

The tab looks like any other, except that it is permanently, invisibly sandboxed and cannot be reused for regular browsing.


This appears to be handled more rationally in FireFox -- there, the new page is sandboxed, and any navigations that occur within the tab will remain sandboxed, but typing a new URL in the AwesomeBar will replace the contents with a new, non-sandboxed page. Clicking [Back] from there will reinstate the sandbox on the previous contents.

Safari appears to mis-handle this as well, but in a different way.
 
Components: UI>Browser>Navigation
Should like we should just reset the sandbox flags on certain browser-initiated main frame navigations?  We already swap BrowsingInstances for most of them (see  issue 803367 ), and there's some logic to look at appropriate page transitions that was added there and which might be helpful here.  Though I'm also curious what should happen if you type a URL into the omnibox to get to an unsandboxed page, and then go back.  Do we need to restore the previously active flags?
That is the behavior on Firefox, and I'd argue that it is correct.

Sign in to add a comment