Switch audio stream to audio service on Android and ChromeOS |
|||||||||
Issue descriptionExperiment-controlled rollout of a new code path for creating and controlling audio streams. The new code works on top of the audio service. Design doc: https://docs.google.com/document/d/1s_Fd1WRDdpb5n6C2MSJjeC3fis6hULZwfKMeDd4K5tI/edit#heading=h.7nki9mck5t64 Design review: http://crbug/833821 The change: * Does not have user facing changes; * Does not have functionality that saves data or interacts with Google; * Does not have privacy, security, or legal implications. * Does not require new/additional manual testing. So, according to the new launch process, it does not require a launch bug. The two experiment groups are: New code path enabled, new code path disabled. The rollout for desktop is tracked in Issue 832666 (old-style process): on desktop we are also launching the new audio service in a separate process - but not on Android/ChromeOS,
,
May 23 2018
,
May 23 2018
,
May 23 2018
,
May 29 2018
,
Jun 13 2018
Hi olka@, this launch should require a launch bug. The design doc has concerns about sandboxing, leaking muted audio, and permissions. Please move this over to a launch ASAP to get appropriate xfn reviews.
,
Jun 14 2018
felt@ - The DD covers (a) implementing the audio service and (b) running it in a separate process on desktop platforms. * Sandboxing is applicable to desktop only (and approved by security, see the DD and Issue 832666. * There are no concerns about leaking muted audio for in audio service. * And there are no concerns about permissions. I refreshed the introduction chapter to make it clear - could you point me to the places in the DD which look worrisome?
,
Jun 14 2018
"Privacy concerns are mostly related to seamless renderer audio stream restore: various scenarios regarding muting and revoking device permissions should be covered, to make sure we do not leak muted audio and do not perform audio capture without permissions. This is covered in a corresponding design doc and is out of the scope of the main service work." (note that the corresponding design doc is not linked)
,
Jun 15 2018
The design actually is linked in the follow-up section this text points to, but I also added a direct link now. This is a follow-up work which is not a part of the audio service launch.
,
Jun 21 2018
Based on c#7 I don't have any concerns here - felt@, does that cover your original question?
,
Jul 5
felt@ - friendly ping: could you let us know if there any remaining concerns? Thanks!
,
Jul 19
,
Sep 8
No longer on the Chrome team, e-mail me @google.com if any attention still required from me here, otherwise good luck!
,
Oct 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b852f1e17526c94cc5e50fbb68fb12209a6b43de commit b852f1e17526c94cc5e50fbb68fb12209a6b43de Author: Max Morin <maxmorin@chromium.org> Date: Thu Oct 25 10:37:45 2018 Update fieldtrial_testing_config.json These changes harmonizes the field trial testing with the actual experiment configs. Bug: 832666, 845892 Change-Id: I77f8118980ed5de7f3f2951f8ad80838327b3f30 Reviewed-on: https://chromium-review.googlesource.com/c/1297365 Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#602664} [modify] https://crrev.com/b852f1e17526c94cc5e50fbb68fb12209a6b43de/testing/variations/fieldtrial_testing_config.json |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by olka@chromium.org
, May 23 2018