New issue
Advanced search Search tips

Issue 845864 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 795291



Sign in to add a comment

Convert media::SharedMemoryRegion to media::UnalignedSharedMemory

Project Member Reported by mattcary@chromium.org, May 23 2018

Issue description

As suggested by media/gpu/shared_memory_region.h. This is a first step at untangling media/ shared memory usage for conversion to the new shared memory API.
 
Project Member

Comment 1 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a8a787ff73eef6871c8dccb703c95c4fa7377c7

commit 2a8a787ff73eef6871c8dccb703c95c4fa7377c7
Author: Matthew Cary <mattcary@chromium.org>
Date: Wed May 30 06:30:11 2018

Transform media::SharedMemoryRegion to UnalignedMemoryRegion.

SharedMemoryRegion is a trivial wrapper, as noted in the code, which suggests it
should be removed. In addition, removing it is the first step in the general shared
memory refactoring (see bug).

Bug:  845864 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I9e285f962242fef132e63acff4095df96ca28b42
Reviewed-on: https://chromium-review.googlesource.com/1070145
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562753}
[modify] https://crrev.com/2a8a787ff73eef6871c8dccb703c95c4fa7377c7/media/base/decoder_buffer.cc
[modify] https://crrev.com/2a8a787ff73eef6871c8dccb703c95c4fa7377c7/media/base/unaligned_shared_memory.cc
[modify] https://crrev.com/2a8a787ff73eef6871c8dccb703c95c4fa7377c7/media/base/unaligned_shared_memory.h
[modify] https://crrev.com/2a8a787ff73eef6871c8dccb703c95c4fa7377c7/media/base/unaligned_shared_memory_unittest.cc
[modify] https://crrev.com/2a8a787ff73eef6871c8dccb703c95c4fa7377c7/media/gpu/BUILD.gn
[modify] https://crrev.com/2a8a787ff73eef6871c8dccb703c95c4fa7377c7/media/gpu/android/android_video_decode_accelerator.cc
[modify] https://crrev.com/2a8a787ff73eef6871c8dccb703c95c4fa7377c7/media/gpu/android/android_video_decode_accelerator.h
[modify] https://crrev.com/2a8a787ff73eef6871c8dccb703c95c4fa7377c7/media/gpu/android/android_video_encode_accelerator.cc
[modify] https://crrev.com/2a8a787ff73eef6871c8dccb703c95c4fa7377c7/media/gpu/fake_jpeg_decode_accelerator.cc
[modify] https://crrev.com/2a8a787ff73eef6871c8dccb703c95c4fa7377c7/media/gpu/fake_jpeg_decode_accelerator.h
[delete] https://crrev.com/68c2b0e8549fd6ef98e6d4da9ecdb9841fd6ace4/media/gpu/shared_memory_region.cc
[delete] https://crrev.com/68c2b0e8549fd6ef98e6d4da9ecdb9841fd6ace4/media/gpu/shared_memory_region.h
[modify] https://crrev.com/2a8a787ff73eef6871c8dccb703c95c4fa7377c7/media/gpu/test/video_decode_accelerator_unittest_helpers.cc
[modify] https://crrev.com/2a8a787ff73eef6871c8dccb703c95c4fa7377c7/media/gpu/test/video_decode_accelerator_unittest_helpers.h
[modify] https://crrev.com/2a8a787ff73eef6871c8dccb703c95c4fa7377c7/media/gpu/v4l2/v4l2_jpeg_decode_accelerator.cc
[modify] https://crrev.com/2a8a787ff73eef6871c8dccb703c95c4fa7377c7/media/gpu/v4l2/v4l2_jpeg_decode_accelerator.h
[modify] https://crrev.com/2a8a787ff73eef6871c8dccb703c95c4fa7377c7/media/gpu/v4l2/v4l2_slice_video_decode_accelerator.cc
[modify] https://crrev.com/2a8a787ff73eef6871c8dccb703c95c4fa7377c7/media/gpu/v4l2/v4l2_video_decode_accelerator.cc
[modify] https://crrev.com/2a8a787ff73eef6871c8dccb703c95c4fa7377c7/media/gpu/v4l2/v4l2_video_encode_accelerator.cc
[modify] https://crrev.com/2a8a787ff73eef6871c8dccb703c95c4fa7377c7/media/gpu/vaapi/vaapi_jpeg_decode_accelerator.cc
[modify] https://crrev.com/2a8a787ff73eef6871c8dccb703c95c4fa7377c7/media/gpu/vaapi/vaapi_jpeg_decode_accelerator.h
[modify] https://crrev.com/2a8a787ff73eef6871c8dccb703c95c4fa7377c7/media/gpu/vaapi/vaapi_jpeg_encode_accelerator.cc
[modify] https://crrev.com/2a8a787ff73eef6871c8dccb703c95c4fa7377c7/media/gpu/vaapi/vaapi_jpeg_encode_accelerator.h
[modify] https://crrev.com/2a8a787ff73eef6871c8dccb703c95c4fa7377c7/media/gpu/vaapi/vaapi_video_decode_accelerator.cc
[modify] https://crrev.com/2a8a787ff73eef6871c8dccb703c95c4fa7377c7/media/gpu/vaapi/vaapi_video_decode_accelerator.h
[modify] https://crrev.com/2a8a787ff73eef6871c8dccb703c95c4fa7377c7/media/gpu/vaapi/vaapi_video_encode_accelerator.cc
[modify] https://crrev.com/2a8a787ff73eef6871c8dccb703c95c4fa7377c7/media/gpu/vt_video_decode_accelerator_mac.cc

Status: Fixed (was: Started)

Sign in to add a comment