New issue
Advanced search Search tips

Issue 845844 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

"PrintPreviewDialogControllerUnitTest.MultiplePreviewDialogs" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, May 23 2018

Issue description

"PrintPreviewDialogControllerUnitTest.MultiplePreviewDialogs" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 4 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyRgsSBUZsYWtlIjtQcmludFByZXZpZXdEaWFsb2dDb250cm9sbGVyVW5pdFRlc3QuTXVsdGlwbGVQcmV2aWV3RGlhbG9ncww.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 

Comment 1 by gab@chromium.org, May 23 2018

Components: UI>Browser>PrintPreview
Owner: thestig@chromium.org
Status: Assigned (was: Untriaged)
Flakes look like this : https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8945788374944013328%2F%2B%2Fsteps%2Funit_tests__with_patch_%2F0%2Flogs%2FPrintPreviewDialogControllerUnitTest.MultiplePreviewDialogs%2F0

@thestig PTaL

[ RUN      ] PrintPreviewDialogControllerUnitTest.MultiplePreviewDialogs
Received signal 11 SEGV_MAPERR 000000000100
0   unit_tests                          0x00000001149a4d2c base::debug::StackTrace::StackTrace(unsigned long) + 28
1   unit_tests                          0x00000001149a4b51 base::debug::(anonymous namespace)::StackDumpSignalHandler(int, __siginfo*, void*) + 2401
2   libsystem_platform.dylib            0x00007fff76bcdf5a _sigtramp + 26
3   ???                                 0x0000000000000007 0x0 + 7
4   unit_tests                          0x0000000110e734b6 std::__1::__tree<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, base::RepeatingCallback<void (mojo::ScopedInterfaceEndpointHandle)> >, std::__1::__map_value_compare<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, base::RepeatingCallback<void (mojo::ScopedInterfaceEndpointHandle)> >, std::__1::less<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > >, true>, std::__1::allocator<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, base::RepeatingCallback<void (mojo::ScopedInterfaceEndpointHandle)> > > >::destroy(std::__1::__tree_node<std::__1::__value_type<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, base::RepeatingCallback<void (mojo::ScopedInterfaceEndpointHandle)> >, void*>*) + 38
5   unit_tests                          0x0000000110e73729 content::AssociatedInterfaceRegistryImpl::~AssociatedInterfaceRegistryImpl() + 41
6   unit_tests                          0x0000000111cac6b3 content::RenderFrameHostImpl::~RenderFrameHostImpl() + 2803
7   unit_tests                          0x0000000113cb47ee content::TestRenderFrameHost::~TestRenderFrameHost() + 14
8   unit_tests                          0x0000000111cd7822 content::RenderFrameHostManager::~RenderFrameHostManager() + 434
9   unit_tests                          0x0000000111c79ab7 content::FrameTreeNode::~FrameTreeNode() + 999
10  unit_tests                          0x0000000111c76d6e content::FrameTree::~FrameTree() + 30
11  unit_tests                          0x00000001120910a4 content::WebContentsImpl::~WebContentsImpl() + 3636
12  unit_tests                          0x000000011209159e content::WebContentsImpl::~WebContentsImpl() + 14
13  unit_tests                          0x00000001178b6c14 ConstrainedWebDialogDelegateBase::~ConstrainedWebDialogDelegateBase() + 116
14  unit_tests                          0x0000000117b16665 (anonymous namespace)::ConstrainedWebDialogDelegateViews::~ConstrainedWebDialogDelegateViews() + 69
15  unit_tests                          0x0000000117b14d28 (anonymous namespace)::ConstrainedDialogWebView::~ConstrainedDialogWebView() + 200
16  unit_tests                          0x000000011486b264 views::View::~View() + 228
17  unit_tests                          0x00000001148899ae views::ClientView::~ClientView() + 14
18  unit_tests                          0x000000011486b264 views::View::~View() + 228
19  unit_tests                          0x0000000114891827 views::NonClientView::~NonClientView() + 183
20  unit_tests                          0x000000011486c5aa views::View::DoRemoveChildView(views::View*, bool, bool, bool, views::View*) + 906
21  unit_tests                          0x000000011486cff5 views::View::RemoveAllChildViews(bool) + 53
22  unit_tests                          0x000000011487e331 views::internal::RootView::~RootView() + 193
23  unit_tests                          0x000000011487e46e views::internal::RootView::~RootView() + 14
24  unit_tests                          0x0000000114881d43 views::Widget::~Widget() + 179
25  unit_tests                          0x0000000114881fde views::Widget::~Widget() + 14
26  unit_tests                          0x000000011487a923 views::NativeWidgetMac::~NativeWidgetMac() + 51
27  unit_tests                          0x000000011487a9ae views::NativeWidgetMac::~NativeWidgetMac() + 14
28  unit_tests                          0x000000011487abb3 views::NativeWidgetMac::OnWindowDestroyed() + 147
29  unit_tests                          0x00000001147efad4 views::BridgedNativeWidget::OnWindowWillClose() + 292
30  unit_tests                          0x00000001147f61fe -[ViewsNSWindowDelegate windowWillClose:] + 494
31  CoreFoundation                      0x00007fff4efa828c __CFNOTIFICATIONCENTER_IS_CALLING_OUT_TO_AN_OBSERVER__ + 12
32  CoreFoundation                      0x00007fff4efa817a _CFXRegistrationPost + 442
33  CoreFoundation                      0x00007fff4efa7ec2 ___CFXNotificationPost_block_invoke + 50
34  CoreFoundation                      0x00007fff4ef66af2 -[_CFXNotificationRegistrar find:object:observer:enumerator:] + 1826
35  CoreFoundation                      0x00007fff4ef65b8c _CFXNotificationPost + 652
36  Foundation                          0x00007fff51064467 -[NSNotificationCenter postNotificationName:object:userInfo:] + 66
37  AppKit                              0x00007fff4ce3bfb4 -[NSWindow _finishClosingWindow] + 185
38  AppKit                              0x00007fff4c7dc264 -[NSWindow _close] + 378
39  unit_tests                          0x00000001147edb3a views::BridgedNativeWidget::~BridgedNativeWidget() + 314
40  unit_tests                          0x00000001147ee44e views::BridgedNativeWidget::~BridgedNativeWidget() + 14
41  unit_tests                          0x000000011487ab9a views::NativeWidgetMac::OnWindowDestroyed() + 122
42  unit_tests                          0x00000001147efad4 views::BridgedNativeWidget::OnWindowWillClose() + 292
43  unit_tests                          0x00000001147f61fe -[ViewsNSWindowDelegate windowWillClose:] + 494
44  CoreFoundation                      0x00007fff4efa828c __CFNOTIFICATIONCENTER_IS_CALLING_OUT_TO_AN_OBSERVER__ + 12
45  CoreFoundation                      0x00007fff4efa817a _CFXRegistrationPost + 442
46  CoreFoundation                      0x00007fff4efa7ec2 ___CFXNotificationPost_block_invoke + 50
47  CoreFoundation                      0x00007fff4ef66af2 -[_CFXNotificationRegistrar find:object:observer:enumerator:] + 1826
48  CoreFoundation                      0x00007fff4ef65b8c _CFXNotificationPost + 652
49  Foundation                          0x00007fff51064467 -[NSNotificationCenter postNotificationName:object:userInfo:] + 66
50  AppKit                              0x00007fff4ce3bfb4 -[NSWindow _finishClosingWindow] + 185
51  AppKit                              0x00007fff4c7dc264 -[NSWindow _close] + 378
52  unit_tests                          0x000000011487bca1 views::NativeWidgetMac::CloseNow() + 145
53  unit_tests                          0x000000011487a912 views::NativeWidgetMac::~NativeWidgetMac() + 34
54  unit_tests                          0x000000011487a9ae views::NativeWidgetMac::~NativeWidgetMac() + 14
55  unit_tests                          0x0000000114881d5e views::Widget::~Widget() + 206
56  unit_tests                          0x0000000114881fde views::Widget::~Widget() + 14
57  unit_tests                          0x0000000113b6b83a DialogTestBrowserWindow::~DialogTestBrowserWindow() + 58
58  unit_tests                          0x000000010f7025f9 BrowserWithTestWindowTest::TearDown() + 169
59  unit_tests                          0x000000011094e3f0 testing::TestInfo::Run() + 320
60  unit_tests                          0x000000011094ea27 testing::TestCase::Run() + 279
61  unit_tests                          0x000000011095b1b7 testing::internal::UnitTestImpl::RunAllTests() + 871
[end of stack trace]
Cc: roc...@chromium.org
rockot: What's an AssociatedInterfaceRegistryImpl?

Comment 3 by tapted@chromium.org, May 25 2018

Hi, This is an assigned Sheriff-Chromium bug. You're getting this update because the sheriff didn't have time to investigate/poke this bug today. You can help by taking appropriate action. E.g.
 - fix \o/
 - disable test and remove Sheriff-Chromium label
 - revert a CL (and remove label)
 - re-triage/de-dupe, removing Sheriff-Chromium if you think it's no longer flaky.

Thanks!
I'll disable for now. This is a problem in the content/ layer, as print_preview_dialog_controller_unittest.cc has not changed in 18 months.
Cc: tapted@chromium.org
Labels: OS-Mac
Actually... I noticed this is Mac-only and Views code is all over the stack trace. Can you see if it repros for you locally?
Project Member

Comment 6 by bugdroid1@chromium.org, May 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ccc164a704f82c3850bf770a24c45950b9ca5455

commit ccc164a704f82c3850bf770a24c45950b9ca5455
Author: Lei Zhang <thestig@chromium.org>
Date: Fri May 25 23:17:55 2018

Disable PrintPreviewDialogControllerUnitTest.MultiplePreviewDialogs on Mac.

It is flaky.

BUG=845844

Change-Id: I02639a86467eda5311c750b3bacf957ab6adfca8
Reviewed-on: https://chromium-review.googlesource.com/1073964
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562054}
[modify] https://crrev.com/ccc164a704f82c3850bf770a24c45950b9ca5455/chrome/browser/printing/print_preview_dialog_controller_unittest.cc

Cc: thestig@chromium.org
Labels: -Sheriff-Chromium
Owner: tapted@chromium.org
Punting over to tapted@ because it's possibly a Mac Views issue.
Cc: -roc...@chromium.org rockot@google.com

Sign in to add a comment