New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 845835 link

Starred by 2 users
Status: Fixed
Owner:
chenghan@chromium.org
Closed: May 2018
Cc:
█ yhong@chromium.org
chromeos-factory-eng@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

HWID database does not update field with default component

Project Member Reported by chenghan@chromium.org, May 23 2018 
Chrome Version: ToT
OS: Chrome

What steps will reproduce the problem?
Update database with a new component, where the field already has a default component.

What is the expected result?
The new component being added into database.

What happens instead?
The new component is not added into database.
Project Member

Comment 1 by bugdroid1@chromium.org, May 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/913be0635ef709cfabcd44507745e686834101f7

commit 913be0635ef709cfabcd44507745e686834101f7
Author: Yong Hong <yhong@chromium.org>
Date: Thu May 24 11:10:06 2018

hwid: Don't use default components if mismatched components are allowed.

Normally, the existance of a default component is a workaround so
that a bad probed values will not block the factory from generating
the HWID strings.  However, when we run hwid-updater, we consider the
probed values as a golden sample and encountering mismatched probed
values means that we need to record those values in the HWID database
so at this step, we should always ignore the default components.

BUG= chromium:845835 
TEST=make test

Change-Id: I06918ba60aae310cd59b158e0324072f53bf792a
Reviewed-on: https://chromium-review.googlesource.com/1070831
Commit-Ready: Yong Hong <yhong@google.com>
Tested-by: Yong Hong <yhong@google.com>
Reviewed-by: Cheng-Han Yang <chenghan@chromium.org>

[modify] https://crrev.com/913be0635ef709cfabcd44507745e686834101f7/py/hwid/v3/probe_unittest.py
[modify] https://crrev.com/913be0635ef709cfabcd44507745e686834101f7/py/hwid/v3/probe.py

Comment 2 by chenghan@chromium.org, May 25 2018

Status: Fixed (was: Untriaged)
►

Sign in to add a comment