FilesApp crostini preview not working |
|||||
Issue descriptionPreview of image or pdf file in crostini does not work. Double click to open file works OK, but preview (space bar) does not work.
,
May 24 2018
,
May 25 2018
,
May 29 2018
,
Jun 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9867e6aab3d874d0b9e61e1da0920a375cb5a4c2 commit 9867e6aab3d874d0b9e61e1da0920a375cb5a4c2 Author: Joel Hockey <joelhockey@chromium.org> Date: Thu Jun 07 03:21:53 2018 Add file_manager::util::GetCrostiniMountPointName Refactored this code out so it can be used in tests. Bug: 845830 Change-Id: Id6b6f9ed35c38dcea114bcd4f18431ae0d3aafde Reviewed-on: https://chromium-review.googlesource.com/1089603 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#565164} [modify] https://crrev.com/9867e6aab3d874d0b9e61e1da0920a375cb5a4c2/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc [modify] https://crrev.com/9867e6aab3d874d0b9e61e1da0920a375cb5a4c2/chrome/browser/chromeos/file_manager/path_util.cc [modify] https://crrev.com/9867e6aab3d874d0b9e61e1da0920a375cb5a4c2/chrome/browser/chromeos/file_manager/path_util.h
,
Jun 13 2018
Using an image file for testing to verify this bug. The integration tests were recently changed from using an image to a text file to ensure the test does not time out on the bots. I don't expect any problem for that on UI tests, but I will keep an eye on: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=FileManagerUITest
,
Jun 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8865dfe43ed9abf3b9f3674c06ca73e64dc5076b commit 8865dfe43ed9abf3b9f3674c06ca73e64dc5076b Author: Joel Hockey <joelhockey@chromium.org> Date: Wed Jun 13 05:44:09 2018 FilesApp UI test for crostini quickview * Add Quick View test for downloads and crostini. * Update waitForElement to support searching elements within nested shadow roots. Bug: 845830 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I7b8f2ebd29eddfb3aa453aa5db0cd75aadec0650 Reviewed-on: https://chromium-review.googlesource.com/1090517 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#566732} [modify] https://crrev.com/8865dfe43ed9abf3b9f3674c06ca73e64dc5076b/ui/file_manager/file_manager/foreground/js/quick_view_controller.js [modify] https://crrev.com/8865dfe43ed9abf3b9f3674c06ca73e64dc5076b/ui/file_manager/file_manager/test/js/test_util.js [add] https://crrev.com/8865dfe43ed9abf3b9f3674c06ca73e64dc5076b/ui/file_manager/file_manager/test/quick_view.js
,
Jun 13 2018
,
Jun 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/65c2ab5e8709f8f2bd2485cacc38dfd429d91495 commit 65c2ab5e8709f8f2bd2485cacc38dfd429d91495 Author: Joel Hockey <joelhockey@chromium.org> Date: Wed Jun 13 10:37:51 2018 FilesApp UI test for crostini quickview * Add quickview test to FileManagerUITest * Fix error in create_test_main script which was creating invalid markup. Bug: 845830 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I23b9e587df0ac8e4cdd3a45db4a9faba3f13e7cd Reviewed-on: https://chromium-review.googlesource.com/1098754 Reviewed-by: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#566791} [modify] https://crrev.com/65c2ab5e8709f8f2bd2485cacc38dfd429d91495/chrome/browser/chromeos/file_manager/file_manager_uitest.cc [modify] https://crrev.com/65c2ab5e8709f8f2bd2485cacc38dfd429d91495/ui/file_manager/file_manager/test/quick_view.js [modify] https://crrev.com/65c2ab5e8709f8f2bd2485cacc38dfd429d91495/ui/file_manager/file_manager/test/scripts/create_test_main.py |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by sashab@google.com
, May 24 2018