New issue
Advanced search Search tips

Issue 845826 link

Starred by 2 users
Status: Assigned
Owner:
dvadym@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Clean PasswordFormManagerForUI interface

Project Member Reported by dvadym@chromium.org, May 23 2018 
On https://chromium-review.googlesource.com/c/chromium/src/+/1042390 interface PasswordFormManagerForUI for using PasswordFormManager in UI code was extracted. It contains all methods that used in UI code on any platforms. Some of these methods shoudln't be used in UI. For example
IsPasswordOverrided
GetPrefferedMatch

This CL for tracking of cleaning this interface.
Project Member

Comment 1 by bugdroid1@chromium.org, May 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03203a12936ebe75db6e299ffbeaaf4b44c0b424

commit 03203a12936ebe75db6e299ffbeaaf4b44c0b424
Author: Vadym Doroshenko <dvadym@chromium.org>
Date: Thu May 24 11:09:27 2018

Replace GetObservedForm with GetOrigin in PasswordFormManagerForUI.

Only origin is needed from observed_form, let's expose only it.
It has benefits, that it it wouldn't be needed to implement
GetObservedForm in NewPasswordFormManager.

Bug: 831123, 845826

Change-Id: I0b9ad0ff8ffeaf37bdef08bf73359cb46267faec
Reviewed-on: https://chromium-review.googlesource.com/1070371
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561456}
[modify] https://crrev.com/03203a12936ebe75db6e299ffbeaaf4b44c0b424/chrome/browser/password_manager/save_password_infobar_delegate_android.cc
[modify] https://crrev.com/03203a12936ebe75db6e299ffbeaaf4b44c0b424/chrome/browser/password_manager/update_password_infobar_delegate_android.cc
[modify] https://crrev.com/03203a12936ebe75db6e299ffbeaaf4b44c0b424/chrome/browser/ui/passwords/manage_passwords_state.cc
[modify] https://crrev.com/03203a12936ebe75db6e299ffbeaaf4b44c0b424/components/password_manager/core/browser/password_form_manager.cc
[modify] https://crrev.com/03203a12936ebe75db6e299ffbeaaf4b44c0b424/components/password_manager/core/browser/password_form_manager.h
[modify] https://crrev.com/03203a12936ebe75db6e299ffbeaaf4b44c0b424/components/password_manager/core/browser/password_form_manager_for_ui.h
[modify] https://crrev.com/03203a12936ebe75db6e299ffbeaaf4b44c0b424/components/password_manager/core/browser/password_form_manager_unittest.cc
[modify] https://crrev.com/03203a12936ebe75db6e299ffbeaaf4b44c0b424/components/password_manager/core/browser/password_manager.cc
[modify] https://crrev.com/03203a12936ebe75db6e299ffbeaaf4b44c0b424/components/password_manager/core/browser/password_manager_unittest.cc
►

Sign in to add a comment