Findit identified the culprit r560348 with confidence 70.0% in the config "chromium.win / Win7 Tests (dbg)(1)"
based on the flakiness trend:

https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVysAELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJ6Y2hyb21pdW0ud2luL1dpbjcgVGVzdHMgKGRiZykoMSkvNjkxODgvdW5pdF90ZXN0cy9SRzkzYm14dllXUk5aWFJoWkdGMFlVMWhibUZuWlhJdlUyVjBVbVZ4ZFdWemRGUmxjM1F1VTJWMFVtVnhkV1Z6ZEM4eU5nPT0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA


Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Feedback is welcome! Please use component Tools>Test>FindIt>Flakiness

FindIt feedback : these reports are lacking context (i.e. link to the bots on which flakes occurred as well as the flaky runs -- the old flake reports had this and it's a critical part of the manual investigation as a sheriff)

On the flakiness dashboard I see these go further back (before May 17th) than r560348 so that culprit is incorrect : https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=unit_tests&tests=DownloadMetadataManager%2FSetRequestTest.SetRequest%2F26

Here's a flaky run : https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29/69188

[ RUN      ] DownloadMetadataManager/SetRequestTest.SetRequest/26
../../chrome/browser/safe_browsing/incident_reporting/download_metadata_manager_unittest.cc(512): error: Value of: metadata
  Actual: false
Expected: true
Stack trace:
Backtrace:
	StackTraceGetter::CurrentStackTrace [0x0395AB8A+90]
	testing::internal::UnitTestImpl::CurrentOsStackTraceExceptTop [0x0397159A+74]
	testing::internal::AssertHelper::operator= [0x039710AB+75]
	safe_browsing::SetRequestTest_SetRequest_Test::TestBody [0x03208A99+1993]
[  FAILED  ] DownloadMetadataManager/SetRequestTest.SetRequest/26, where GetParam() = (0BF36698 pointing to "this", 0BF3669D pointing to "pending", 0BF36764 pointing to "none", 0BDBB8A9 pointing to "loaded", 0BF3675E pointing to "clear") (109 ms)

I see a flake as far back as April 27th (logs are gone though) : https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=unit_tests&showAllRuns=true&resultsHeight=3000&tests=DownloadMetadataManager%2FSetRequestTest.SetRequest%2F26

It's not just the "/26" variant of this test, e.g. "/1" is also flaking @ https://logs.chromium.org/v/?s=chromium%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8945770054906011136%2F%2B%2Fsteps%2Funit_tests%2F0%2Fstdout

Dashboard : https://test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&testType=unit_tests&tests=DownloadMetadataManager%2FSetRequestTest.SetRequest&resultsHeight=3000

One possibility is that RunAllTasks(); causes the flake because RunUntilIdle() is a flaky paradigm if it involves an asynchronous event through the system and/or another process (e.g. this process can be "idle" before the desired task is complete).

Findit identified the culprit r559895 with confidence 70.0% in the config "chromium.win / Win7 Tests (dbg)(1)"
based on the flakiness trend:

https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVysAELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJ6Y2hyb21pdW0ud2luL1dpbjcgVGVzdHMgKGRiZykoMSkvNjkxODgvdW5pdF90ZXN0cy9SRzkzYm14dllXUk5aWFJoWkdGMFlVMWhibUZuWlhJdlUyVjBVbVZ4ZFdWemRGUmxjM1F1VTJWMFVtVnhkV1Z6ZEM4eU5nPT0MCxITTWFzdGVyRmxha2VBbmFseXNpcxgCDA


Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Feedback is welcome! Please use component Tools>Test>FindIt>Flakiness

Hi, This is an assigned Sheriff-Chromium bug. You're getting this update because the sheriff didn't have time to investigate/poke this bug today. You can help by taking appropriate action. E.g.
 - fix \o/
 - disable test and remove Sheriff-Chromium label
 - revert a CL (and remove label)
 - re-triage/de-dupe, removing Sheriff-Chromium if you think it's no longer flaky.

Thanks!

disable cl https://chromium-review.googlesource.com/#/c/chromium/src/+/1074798 . removing from sheriff queue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/23f80a5e5b38d29fe714f16162427a59c01530d4

commit 23f80a5e5b38d29fe714f16162427a59c01530d4
Author: Trent Apted <tapted@chromium.org>
Date: Mon May 28 02:59:48 2018

Disable flaky DownloadMetadataManager/SetRequestTest.SetRequest/*

TBR=proberge@chromium.org

Bug:  845811 
Change-Id: Icd35039921468ff47b857b510a8fde491ee317b9
Reviewed-on: https://chromium-review.googlesource.com/1074798
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562169}
[modify] https://crrev.com/23f80a5e5b38d29fe714f16162427a59c01530d4/chrome/browser/safe_browsing/incident_reporting/download_metadata_manager_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/363e9eab2e8e9c1624d05dbf945ef371b2c1a4ee

commit 363e9eab2e8e9c1624d05dbf945ef371b2c1a4ee
Author: Greg Thompson <grt@chromium.org>
Date: Tue Jun 12 13:51:06 2018

Fix race in SetRequestTest.SetRequest tests.

A final bg write wasn't being waited for, leading to flaky failures when
trying to read the metadata file.

Also fixed some incorrect use of ASSERT_* macros in helper functions.

BUG= 845811 
R=proberge@chromium.org

Change-Id: Ie1021ceafc03501180324195fe3a1da4dc312890
Reviewed-on: https://chromium-review.googlesource.com/1097076
Reviewed-by: proberge <proberge@chromium.org>
Commit-Queue: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566406}
[modify] https://crrev.com/363e9eab2e8e9c1624d05dbf945ef371b2c1a4ee/chrome/browser/safe_browsing/incident_reporting/download_metadata_manager_unittest.cc

Flake dashboard looks nice and green now.