Regression : "Tabs from other devices" section gets unresponsive after clicking on "Delete" button present in toolbar.
Reported by
avsha...@etouch.net,
May 23 2018
|
|||
Issue descriptionChrome Version : 67.0.3396.56 (Official Build) eff3e3f46cf53019f8f43c3d4678e87fa7086fb8-refs/branch-heads/3396@{#682} 32/64-bit OS : Windows(7, 8, 8.1, 10), Linux(14.04 LTS), Mac(10.12.6, 10.13.1, 10.13.5) Precondition : Please make sure that user is not signed in to chrome. What steps will reproduce the problem? 1. Launch chrome and visit few web pages to generate history records in chrome://history page. 2. Navigate to chrome://history page, go to "Tabs from other devices" section and hit Ctrl + A from keyboard. 3. Click on 'Delete' button seen on the toolbar and then try to click on any button available on the page. 4. Observe. Actual Result : "Tabs from other devices" section gets unresponsive after clicking on "Delete" button present in toolbar. Expected Result : 'Ctrl + A' command should not work under "Tabs from other devices" section unless and until user is signed in to chrome. This is a regression issue, broken in M-66 and providing the bisect using per-revision script: Good Build : 66.0.3334.0 (Revision : 532208) Bad Build : 66.0.3335.0 (Revision : 533164) Change Log URL : https://chromium.googlesource.com/chromium/src/+log/18ac0a07d07f8687258809c8b98c678167e6ae7c..67c8f89613bfaf24bf52f303dbec8267b52c7831 Suspect : https://chromium.googlesource.com/chromium/src/+/67c8f89613bfaf24bf52f303dbec8267b52c7831 @sangwoo : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note : This issue is also reproducible on Canary #68.03438.0, Dev #68.0.3432.3 and Stable #66.0.3359.181
,
May 25 2018
,
May 28 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a620981bebb0b189d90bd4f3302ee7c70e7317b5 commit a620981bebb0b189d90bd4f3302ee7c70e7317b5 Author: sangwoo.ko <sangwoo108@chromium.org> Date: Mon May 28 09:03:37 2018 Disable ctrl+a when it's synced tabs page When it's synced tabs, there's no selectable item. So the accelerator shouldn't work on synced tabs page. Bug: 845802 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5486bfd7cf32dbaff881e7ac6a63f7f18e194e06 Reviewed-on: https://chromium-review.googlesource.com/1074788 Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Reviewed-by: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#562213} [modify] https://crrev.com/a620981bebb0b189d90bd4f3302ee7c70e7317b5/chrome/browser/resources/md_history/app.js [modify] https://crrev.com/a620981bebb0b189d90bd4f3302ee7c70e7317b5/chrome/test/data/webui/md_history/history_list_test.js
,
May 28 2018
Please re-open this if it's still reproducible. Thanks :) |
|||
►
Sign in to add a comment |
|||
Comment 1 by sangwoo108@chromium.org
, May 23 2018