Consider always calling a method to request appropriate permissions when requesting a session. |
||||||||||||
Issue descriptionConsider adding a pure virtual RequestAppropriatePermission() to the device interface (currently VRDevice[Base]) and always calling that from VRDisplayHost::RequestSession(). Doing so would force individual devices to consider whether permissions are required for the specified configuration. We might also want to have a pure virtual AreRequestedOptionsSupported() method when session options are added to the interface.
,
May 26 2018
,
Jun 6 2018
We may end up moving such methods off of the main XR runtime device objects to simplify those - both initialization and scope. For example, arcore_device.cc includes a lot of additional headers just to handle permissions.
,
Jun 7 2018
,
Jul 4
,
Aug 2
,
Aug 7
Removing Blink>WebVR component and assigning to Blink>WebXR
,
Aug 7
Removing Blink>WebVR component and assigning to Blink>WebXR
,
Aug 7
,
Aug 21
,
Sep 4
,
Oct 8
Related discussion from a CR comment. https://chromium-review.googlesource.com/#/c/1256217/9/device/vr/public/mojom/isolated_xr_service.mojom@80 We could add another interface XRSessionProvider that is obtained from XRRuntime when we check the runtime is up to date, and request updates/install modules. Currently we have XRRuntime that exposes several methods, and we have some assumptions (which we validate) about order that methods are called in. Specifically that EnsureInitialized() is called before RequestSession(). By chaining a few interfaces/methods, the type system will guarantee ordering is what we expect. XRRuntime::EnsureInitialized() -> (XRSessionProvider) XRSessionProvider::RequestSession(options) -> (XRSession, XRSessionController) Additionally, this cleanup will naturally fit with allowing the browser to order version checks and permission checks correctly in sequence before requesting a session from a runtime.
,
Nov 21
We may want to implement the changes for "AR mode" first since that could affect the flow. |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by ddorwin@chromium.org
, May 26 2018