New issue
Advanced search Search tips

Issue 845791 link

Starred by 2 users
Status: Fixed
Owner:
dpa...@chromium.org
Closed: May 2018
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Disabled button name is seen faint.

Reported by pranjali...@etouch.net, May 23 2018 
Chrome version :  68.0.3438.0 (Official Build) 92f33534f404595554fb708537b29568da70f384-refs/branch-heads/3438@{#1}(32/64-bit) 

OS : Win(7,8,8.1,10) OS

Steps to reproduce:
1. Launch chrome and navigate to 'chrome://settings/autofill'.
2. click on 'Add' button under Addresses and observe.

Actual Result: Disabled button name is seen faint.
Expected Result: Disabled button name should be seen bit darker .

This is a regression issue broken in ‘M-68’ and will soon update other bisect info.
Good build: 68.0.3437.0 
Bad build: 68.0.3438.0

Comment 1 by pranjali...@etouch.net, May 23 2018

Labels: hasbisect-per-revision OS-Linux OS-Mac
Owner: dpa...@chromium.org
Status: Assigned (was: Unconfirmed)
You are probably looking for a change made after 560817 (known good), but no later than 560818 (first known bad).

CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.

  https://chromium.googlesource.com/chromium/src/+log/92baec6dfd713e8fe9f74bd561667d58ef517d79..bba7e8ac988500dc87a1de6c4809628a9415a1c8

Suspect: https://chromium.googlesource.com/chromium/src/+/bba7e8ac988500dc87a1de6c4809628a9415a1c8

@dpapad: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Thank you.
Actual_result.mp4
165 KB View Download
Expected_result.mp4
196 KB View Download

Comment 2 by nyerramilli@chromium.org, May 23 2018 

This looks like intentional change as after entering the data, 'Save' button gets enabled.

dpapad@, could you please confirm.

Comment 3 by dpa...@chromium.org, May 23 2018 

The disabled buttons text color is not supposed to be white. Invesigating...

Comment 4 by dpa...@chromium.org, May 23 2018

Status: Started (was: Assigned)
I am able to reproduce this.

Comment 5 by dpa...@chromium.org, May 23 2018

Labels: Proj-MaterialDesign-Refresh-WebUI
Project Member

Comment 7 by bugdroid1@chromium.org, May 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc2c5b2e9d5e9e725f837637c55f8a251a957bc7

commit cc2c5b2e9d5e9e725f837637c55f8a251a957bc7
Author: dpapad <dpapad@chromium.org>
Date: Wed May 23 22:11:36 2018

WebUI MD Refresh: Fix disabled button text color regression.

This was caused because of a previous CL increased specificity of the
paper-button.action-button to paper-button:not([raised]).action-button
and similar increase should happen for the disabled case.

Bug:  845791 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I1bd432194165857cfa91dc456cbe4c1eb11e6871
Reviewed-on: https://chromium-review.googlesource.com/1070498
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561271}
[modify] https://crrev.com/cc2c5b2e9d5e9e725f837637c55f8a251a957bc7/ui/webui/resources/cr_elements/paper_button_style_css.html

Comment 8 by dpa...@chromium.org, May 23 2018

Status: Fixed (was: Started)

Comment 9 by pranjali...@etouch.net, May 24 2018

Labels: TE-Verified-68.0.3439.0 TE-Verified-M68
Update:
Retested the above issue using latest canary#68.0.3439.0 on  Win(7,8,8.1,10),Mac(10.12.6,10.13.1,10.13.5) and Linux(14.04) OS and issue is fixed. Text on disabled button is seen properly.

Please refer attached screencast.
Canary_behavior.mp4
183 KB View Download
►

Sign in to add a comment