New issue
Advanced search Search tips

Issue 845781 link

Starred by 2 users
Status: Fixed
Owner:
wangxianzhu@chromium.org
Closed: Aug 14
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

run_web_tests.py --reset-results sometimes removes existing baselines without recreating them

Project Member Reported by wangxianzhu@chromium.org, May 23 2018 
When I rebaselined paint/invalidation/svg/clip-path-child-changes.svg, platform/win/paint/invalidation/svg/clip-path-child-changes-expected.png (shared by Linux) was removed but was not re-created. 

Perhaps related to:
- no existing common baseline
- passing png but failing txt
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a4a0f03e50e3067d244c6325915f867d8a91b9b

commit 2a4a0f03e50e3067d244c6325915f867d8a91b9b
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Tue Aug 14 20:03:48 2018

[run_web_tests] Fix --reset-results when platform baseline exists but fallback doesn't

Previously, --reset-results removed the existing platform baseline
without recreating one if the fallback baseline doesn't exist.

Fix the issue by checking non-exist and non-missing condition
before removing the current baseline.

Bug:  845781 
Change-Id: I7dbe46665d9574b310020c4ffc4041b6235d5570
Reviewed-on: https://chromium-review.googlesource.com/1173483
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583005}
[modify] https://crrev.com/2a4a0f03e50e3067d244c6325915f867d8a91b9b/third_party/blink/tools/blinkpy/web_tests/controllers/single_test_runner.py
[modify] https://crrev.com/2a4a0f03e50e3067d244c6325915f867d8a91b9b/third_party/blink/tools/blinkpy/web_tests/run_webkit_tests_unittest.py

Comment 2 by wangxianzhu@chromium.org, Aug 14

Status: Fixed (was: Assigned)
►

Sign in to add a comment