Assigning a very large json payload to a very with a leading character causes havoc
Reported by
seddon.r...@gmail.com,
May 23 2018
|
||||||||
Issue description
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:59.0) Gecko/20100101 Firefox/59.0
Steps to reproduce the problem:
1. Open chrome devtools and click console
2. type thing = . {copy test.json and paste here}
3. type thing again and choose it in the autocomplete
What is the expected behavior?
That it'll hide the overflow of the payload like it does with assignments that don't cause a syntax error.
What went wrong?
The payload isn't clipped and it covers the entire devtools make it hard to use.
Did this work before? N/A
Chrome version: <Copy from: 'about:version'> Channel: canary
OS Version: OS X 10.13
Flash Version:
Doesn't happen on all very large json, the attached one causes it.
,
May 23 2018
Looks like a bug with our CodeMirror widgets, but at the very least we can put a max size on them.
,
May 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/803cc98e06aab21074f9f400df214e477e725b00 commit 803cc98e06aab21074f9f400df214e477e725b00 Author: Joel Einbinder <einbinder@chromium.org> Date: Thu May 24 14:03:46 2018 DevTools: Prevent the ARIA alert from obscuring DevTools The alert element must be visible for a screen reader to read it, so we place it far off the left edge of the screen. However extremely large text could cause it to overflow onto the page. This patch limits the width of the element, and also limits the max text length of the alerts for better performance. Bug: 845766 Change-Id: I79aadcf863f09ebfdaf2bcb3ba579b891fec2351 Reviewed-on: https://chromium-review.googlesource.com/1067690 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#561490} [modify] https://crrev.com/803cc98e06aab21074f9f400df214e477e725b00/third_party/blink/renderer/devtools/front_end/ui/ARIAUtils.js
,
May 24 2018
,
May 25 2018
Able to reproduce the issue on chrome version 68.0.3437.0(build without fix) Verified the fix on Mac 10.13.3 using Chrome version #68.0.3440.0 as per the comment #0. Attaching screencast for reference. Observed that "there is no syntax error able to see the Devtools." Adding verified labels as fix is working as expected. Thanks...!
,
Aug 13
Issue 863611 has been merged into this issue. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by krajshree@chromium.org
, May 23 2018