New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 845757 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

RLZ nonce/machine ID does not conform to required format

Project Member Reported by stephenlin@chromium.org, May 23 2018

Issue description

Chrome Version: 67.0.3396.49
OS: CrOS 10575.40.0

What steps will reproduce the problem?

(1) Put device in Dev Mode.
(2) Powerwash device. Add --rlz-ping-delay=60 to /etc/chrome_dev.conf.
(3) Go through OOBE. Login.
(4) Open chrome://net-internals
(5) Search in Omnibox
(6) Search in net-internals for "pso". Look at URL. You should see a value like: 

nonce-00035281234D7772C5D5E8A0C43D6E891F9E6B4630E4

The RLZ server requires the format to match the regexp "[A-Z0-9]+" and be exactly 50 chars long. The above string is 50 chars long but uses lowercase letters and has a dash.

The code needs to be updated such that the above would look like:

NONCE000035281234D7772C5D5E8A0C43D6E891F9E6B4630E4

So, uppercase "nonce", remove the dash, and replace it with another random A-Z0-9 value.

The code can be found at:

https://codesearch.chromium.org/chromium/src/rlz/lib/machine_id.cc?rcl=3b6c66d2e5b410ec178ea7b302501889751d4565&l=28

 
Project Member

Comment 1 by bugdroid1@chromium.org, May 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c33471e7ce259ffd374b82cb159beaca48043e8d

commit c33471e7ce259ffd374b82cb159beaca48043e8d
Author: Jonghyun Ahn <jongahn@google.com>
Date: Wed May 23 22:09:49 2018

Modify machine ID to conform to required format.

Bug:  845757 
Change-Id: Ic7ea2c90cbc7b7bf3e6534333fcdac6b4e95336e
Reviewed-on: https://chromium-review.googlesource.com/1069875
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Jong Ahn <jongahn@google.com>
Cr-Commit-Position: refs/heads/master@{#561270}
[modify] https://crrev.com/c33471e7ce259ffd374b82cb159beaca48043e8d/rlz/lib/machine_id.cc
[modify] https://crrev.com/c33471e7ce259ffd374b82cb159beaca48043e8d/rlz/lib/machine_id_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment