New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 845756 link

Starred by 2 users
Status: Fixed
Owner:
akes...@chromium.org
Closed: May 2018
Cc:
█ nxia@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

"rpc_interface_unittest_fixme.py" exists

Project Member Reported by jkop@chromium.org, May 23 2018 
In autotest/frontend/tko, there is a file rpc_interface.py, which has been modified only once since 2014, to deprecate some of its RPCs a year ago. There is also a file rpc_interface_unittest_fixme.py, which has not been touched since 2014 and, just a guess from the name, didn't work then.

These tests are not run by unittest_suite. They seem entirely superfluous.

Comment 1 by jkop@chromium.org, May 23 2018

Owner: akes...@chromium.org
Aviv, you were the last to touch the RPCs, so you may have nonzero state.
Project Member

Comment 2 by bugdroid1@chromium.org, May 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/3c28ba9fe8d86f0dff0cd2ace2da8870753d81e1

commit 3c28ba9fe8d86f0dff0cd2ace2da8870753d81e1
Author: Aviv Keshet <akeshet@chromium.org>
Date: Wed May 23 22:33:50 2018

autotest: delete some obsolete and broken unit tests

BUG= chromium:845756 
TEST=None

Change-Id: Ib81912f55f5f3faa09e3e92645d487b664da4b01
Reviewed-on: https://chromium-review.googlesource.com/1070546
Commit-Ready: Aviv Keshet <akeshet@chromium.org>
Tested-by: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Jacob Kopczynski <jkop@chromium.org>

[delete] https://crrev.com/b782188ddeaebaba4ef655f1ab5347510f4767db/frontend/tko/rpc_interface_unittest_fixme.py

Comment 3 by akes...@chromium.org, May 29 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment