New issue
Advanced search Search tips

Issue 845746 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Extensions Developer mode toggle

Project Member Reported by namratakannan@chromium.org, May 23 2018

Issue description

Update developer mode toggle to GM2 spec.
Will update bug with mocks.
 
Off toggle track:
GG 600

On toggle track:
GG 100

page_extensions_devmode_new toggle_off.png
117 KB View Download
page_extensions_devmode_new toggle_on.png
117 KB View Download

Comment 2 by dpa...@chromium.org, Jun 19 2018

Cc: bettes@chromium.org namratakannan@chromium.org aee@chromium.org
 Issue 850268  has been merged into this issue.

Comment 3 by dpa...@chromium.org, Jun 19 2018

Labels: -M69 M-69 OS-Chrome OS-Linux OS-Mac OS-Windows

Comment 4 by dpa...@chromium.org, Jun 19 2018

Owner: ----
Status: Available (was: Assigned)

Comment 5 by dpa...@chromium.org, Jun 19 2018

Owner: dpa...@chromium.org
Status: Started (was: Available)

Comment 6 by dpa...@chromium.org, Jun 19 2018

CL is at https://chromium-review.googlesource.com/c/chromium/src/+/1107039. Having said that, after using the suggested colors, the actual screenshots look a bit different than the ones at comment #1.

@Namrata: Can you verify?
GG100 is defined at [1] which is #F1F3F4, but this looks a bit lighter than your screenshot earlier. Did you use the same color in the screenshot?

[1] https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/shared_vars_css.html?l=153
toggle_off_after.png
2.9 KB View Download
toggle_on_after.png
2.9 KB View Download

Comment 7 by dpa...@chromium.org, Jun 19 2018

Posting updated screenshots. You can ignore my previous comment, one of the colors was missing.


toggle_off_after.png
2.4 KB View Download
toggle_on_after.png
2.4 KB View Download

Comment 8 by dpa...@chromium.org, Jun 19 2018

@Namrata: New observation. By default we apply opacity 0.5 on the "on" track. So if I use gg100 the result seems slightly different to me than what you posted on comment#1. Should gg100 be adjusted, or should the opacity be removed just for this case, or is the screenshot at #7 just fine?
Screenshot in comment 7 if fine!
Project Member

Comment 10 by bugdroid1@chromium.org, Jun 21 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/977135d4585c03c1b4380915e019b591972af667

commit 977135d4585c03c1b4380915e019b591972af667
Author: dpapad <dpapad@chromium.org>
Date: Thu Jun 21 23:15:34 2018

Extensions MD Refresh: Update developer mode toggle colors.

Bug:  845746 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I402268fc66478b76e11e09a31227dff1569ddb35
Reviewed-on: https://chromium-review.googlesource.com/1107039
Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569430}
[modify] https://crrev.com/977135d4585c03c1b4380915e019b591972af667/chrome/browser/resources/md_extensions/toolbar.html

Status: Fixed (was: Started)

Sign in to add a comment