Extensions Developer mode toggle |
||||||
Issue descriptionUpdate developer mode toggle to GM2 spec. Will update bug with mocks.
,
Jun 19 2018
Issue 850268 has been merged into this issue.
,
Jun 19 2018
,
Jun 19 2018
,
Jun 19 2018
,
Jun 19 2018
CL is at https://chromium-review.googlesource.com/c/chromium/src/+/1107039. Having said that, after using the suggested colors, the actual screenshots look a bit different than the ones at comment #1. @Namrata: Can you verify? GG100 is defined at [1] which is #F1F3F4, but this looks a bit lighter than your screenshot earlier. Did you use the same color in the screenshot? [1] https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/shared_vars_css.html?l=153
,
Jun 19 2018
Posting updated screenshots. You can ignore my previous comment, one of the colors was missing.
,
Jun 19 2018
@Namrata: New observation. By default we apply opacity 0.5 on the "on" track. So if I use gg100 the result seems slightly different to me than what you posted on comment#1. Should gg100 be adjusted, or should the opacity be removed just for this case, or is the screenshot at #7 just fine?
,
Jun 20 2018
Screenshot in comment 7 if fine!
,
Jun 21 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/977135d4585c03c1b4380915e019b591972af667 commit 977135d4585c03c1b4380915e019b591972af667 Author: dpapad <dpapad@chromium.org> Date: Thu Jun 21 23:15:34 2018 Extensions MD Refresh: Update developer mode toggle colors. Bug: 845746 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I402268fc66478b76e11e09a31227dff1569ddb35 Reviewed-on: https://chromium-review.googlesource.com/1107039 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#569430} [modify] https://crrev.com/977135d4585c03c1b4380915e019b591972af667/chrome/browser/resources/md_extensions/toolbar.html
,
Jun 21 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by namratakannan@chromium.org
, Jun 19 2018117 KB
117 KB View Download
117 KB
117 KB View Download