The current trigger works only based on v8 + blink + partitionalloc. It should be based on private footprint and swap values also. https://docs.google.com/document/d/1oJBTrQtC0Ad6_Bx7ImLyjHDWezDKs8RCnm5boAB4-xA/edit#heading=h.7lyy2zc7heu4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eec125feeb7100aa203ba104be8fdb6e04b6ddab commit eec125feeb7100aa203ba104be8fdb6e04b6ddab Author: Siddhartha <ssid@chromium.org> Date: Wed May 30 19:59:28 2018 Move the OOM intervention config to a different file All the config set by field trials will be in one place. No functional change. BUG=845717 Change-Id: Ic7d8408d38cb34b17d195fd4a1a27cf0568436a8 Reviewed-on: https://chromium-review.googlesource.com/1074287 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#562967} [modify] https://crrev.com/eec125feeb7100aa203ba104be8fdb6e04b6ddab/chrome/browser/BUILD.gn [modify] https://crrev.com/eec125feeb7100aa203ba104be8fdb6e04b6ddab/chrome/browser/android/oom_intervention/near_oom_monitor.cc [modify] https://crrev.com/eec125feeb7100aa203ba104be8fdb6e04b6ddab/chrome/browser/android/oom_intervention/near_oom_monitor.h [modify] https://crrev.com/eec125feeb7100aa203ba104be8fdb6e04b6ddab/chrome/browser/android/oom_intervention/near_oom_monitor_unittest.cc [add] https://crrev.com/eec125feeb7100aa203ba104be8fdb6e04b6ddab/chrome/browser/android/oom_intervention/oom_intervention_config.cc [add] https://crrev.com/eec125feeb7100aa203ba104be8fdb6e04b6ddab/chrome/browser/android/oom_intervention/oom_intervention_config.h [modify] https://crrev.com/eec125feeb7100aa203ba104be8fdb6e04b6ddab/chrome/browser/android/oom_intervention/oom_intervention_tab_helper.cc [modify] https://crrev.com/eec125feeb7100aa203ba104be8fdb6e04b6ddab/chrome/browser/android/oom_intervention/oom_intervention_tab_helper.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e587e72faaa5831761ac099e0da7fc354cc5ee3d commit e587e72faaa5831761ac099e0da7fc354cc5ee3d Author: Siddhartha <ssid@chromium.org> Date: Fri Jun 01 22:52:37 2018 Define more OOM intervention params for detection Defines experiment params based on various types of memory metrics in renderer process. Each threshold value set will trigger intervention individually. Bug: 845717 Change-Id: Idd12536d859bed0ecc7cc83a47132a37a27c9f2a Reviewed-on: https://chromium-review.googlesource.com/1069734 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#563844} [modify] https://crrev.com/e587e72faaa5831761ac099e0da7fc354cc5ee3d/chrome/browser/android/oom_intervention/oom_intervention_config.cc [modify] https://crrev.com/e587e72faaa5831761ac099e0da7fc354cc5ee3d/chrome/browser/android/oom_intervention/oom_intervention_config.h [modify] https://crrev.com/e587e72faaa5831761ac099e0da7fc354cc5ee3d/chrome/browser/android/oom_intervention/oom_intervention_tab_helper.cc [modify] https://crrev.com/e587e72faaa5831761ac099e0da7fc354cc5ee3d/third_party/blink/public/platform/oom_intervention.mojom [modify] https://crrev.com/e587e72faaa5831761ac099e0da7fc354cc5ee3d/third_party/blink/renderer/controller/oom_intervention_impl.cc [modify] https://crrev.com/e587e72faaa5831761ac099e0da7fc354cc5ee3d/third_party/blink/renderer/controller/oom_intervention_impl.h [modify] https://crrev.com/e587e72faaa5831761ac099e0da7fc354cc5ee3d/third_party/blink/renderer/controller/oom_intervention_impl_test.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f95e79ad744fdc5ab993761c54c50c28272815fa commit f95e79ad744fdc5ab993761c54c50c28272815fa Author: Siddhartha <ssid@chromium.org> Date: Tue Jun 05 20:02:39 2018 Fix virtual size trigger for OOM intervention Bug: 845717 Change-Id: I744a2376340082abf10db5d208397b3a0a2657d8 Reviewed-on: https://chromium-review.googlesource.com/1086293 Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#564626} [modify] https://crrev.com/f95e79ad744fdc5ab993761c54c50c28272815fa/chrome/browser/android/oom_intervention/oom_intervention_tab_helper.cc [modify] https://crrev.com/f95e79ad744fdc5ab993761c54c50c28272815fa/third_party/blink/common/oom_intervention/oom_intervention_types.h [modify] https://crrev.com/f95e79ad744fdc5ab993761c54c50c28272815fa/third_party/blink/renderer/controller/oom_intervention_impl.cc [modify] https://crrev.com/f95e79ad744fdc5ab993761c54c50c28272815fa/third_party/blink/renderer/controller/oom_intervention_impl.h [modify] https://crrev.com/f95e79ad744fdc5ab993761c54c50c28272815fa/third_party/blink/renderer/controller/oom_intervention_impl_test.cc [modify] https://crrev.com/f95e79ad744fdc5ab993761c54c50c28272815fa/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/146ae0a9f438644ad929067147d0f0da2aa785e2 commit 146ae0a9f438644ad929067147d0f0da2aa785e2 Author: Siddhartha <ssid@chromium.org> Date: Sat Jun 09 01:01:53 2018 Enable OOM intervention even if device has no swap 18% of devices do not support swap. So, do not disable intervention on devices with no swap. The swap detection is not really used since we detect in renderer. BUG=845717 Change-Id: I3c0b20528aa165c541dc2cc2345b01018ad0ffbd Reviewed-on: https://chromium-review.googlesource.com/1092242 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#565806} [modify] https://crrev.com/146ae0a9f438644ad929067147d0f0da2aa785e2/chrome/browser/android/oom_intervention/near_oom_monitor.cc [modify] https://crrev.com/146ae0a9f438644ad929067147d0f0da2aa785e2/chrome/browser/android/oom_intervention/near_oom_monitor.h [modify] https://crrev.com/146ae0a9f438644ad929067147d0f0da2aa785e2/chrome/browser/android/oom_intervention/oom_intervention_config.cc [modify] https://crrev.com/146ae0a9f438644ad929067147d0f0da2aa785e2/chrome/browser/android/oom_intervention/oom_intervention_config.h [modify] https://crrev.com/146ae0a9f438644ad929067147d0f0da2aa785e2/chrome/browser/android/oom_intervention/oom_intervention_tab_helper.cc [modify] https://crrev.com/146ae0a9f438644ad929067147d0f0da2aa785e2/tools/metrics/histograms/enums.xml
This bug has an owner, thus, it's been triaged. Changing status to "assigned".
Comment 1 by bugdroid1@chromium.org
, May 30 2018