New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 845711 link

Starred by 3 users
Status: Fixed
Owner:
wangxianzhu@chromium.org
Closed: May 2018
Cc:
█ krajshree@chromium.org
pdr@chromium.org
enne@chromium.org
chrishtr@chromium.org
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Render performance deteriorates rapidly with added elements

Reported by monfera....@gmail.com, May 22 2018 
Chrome Version       : 66.0.3359.181
OS Version: OS X 10.13.4
URLs (if applicable) : https://t.d3fc.io/status/707615083334148096
Other browsers tested:
  Add OK or FAIL after other browsers where you have tested this issue:
     Safari:
    Firefox:
    IE/Edge:

What steps will reproduce the problem?
1. Go to https://t.d3fc.io/status/707615083334148096 with Chrome
2. ... with Safari
3. ... with Firefox

What is the expected result?
Roughly constant framerate (around 60FPS on my top spec MBP 15)

What happens instead of that?
Chrome frame rate drops off to teens suddenly; image becomes uneven


Please provide any additional information below. Attach a screenshot if
possible.

This used to run very well on Chrome when I created it, and probably afterwards, but it's really slow now. On the other hand it's the first time I look at it with this discrete graphics MBP 15" and also with this specific OS version so no idea if Chrome deteriorated or it'd have been slow on this machine from the beginning.

The image shows a high framerate render (FireFox) and a degraded speed render with uneven spacing (low framerate plus time-driven line drawing...)

UserAgentString: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.181 Safari/537.36
Screen Shot 2018-05-23 at 12.58.40 AM.png
1.3 MB View Download

Comment 1 by aidank...@gmail.com, May 22 2018 

Maybe unrelated but we're currently looking into a similar issue (document with 6000 images) with performance issues on a similar setup. For us we've found that it's a problem with GPU Rasterization (not enabled on OSX 10.11, enabled on 10.12, not enabled on 10.13). If we enable GPU Rasterization, performance drops off a cliff. We're still digging a little deeper in our case.

Would be worth playing with this setting here to see what happens in your case. chrome://flags/#enable-gpu-rasterization

Comment 2 by monfera....@gmail.com, May 22 2018 

Thanks for the quick reply. The .slice(-1e3) in the code causes that there's no more than 1000 SVG lines (it removes an element when adding a new one once it reaches 1k) ie. not a lot, also considering the simplicity of the shape. 

As you suggest, disabling the GPU rasterization leads to way superior and even (consistently timed) results, although both the framerate and the sensitivity to the number of elements, ie. deterioration, is still less good than that of FireFox. I'm on 10.13 and the flag was set to "Default" before you asked me to make this experiment so maybe 10.13 enabled GPU rasterization.

I'm wondering if, performance aside, some of the unevenness of the GPU rasterization might be to do with an earlier observation of mine in WebGL land - the shader time seems proportional to the _AABB_ (axis aligned bounding box) of a line, rather than its length or pixel count. Ie. a diagonal line is way slower than a near-horizontal or near-vertical line of the same length. (I also noticed that Canvas2D has some well-optimized routines for lines of exactly 1 pixel width - it was roughly competitive with WebGL lines - but it's probably unrelated.)

Comment 3 by krajshree@chromium.org, May 23 2018

Labels: Needs-Triage-M66

Comment 4 by krajshree@chromium.org, May 23 2018

Components: Internals>Compositing
Labels: -Type-Bug -Pri-3 hasbisect-per-revision RegressedIn-62 Target-67 Triaged-ET Target-66 FoundIn-66 FoundIn-67 FoundIn-68 M-68 Target-68 OS-Linux OS-Windows Pri-1 Type-Bug-Regression
Owner: enne@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on Windows 10, mac 10.13.3 and Ubuntu 17.10 using chrome reported version #66.0.3359.181 and latest canary #68.0.3438.0.

Bisect Information:
=====================
Good build: 62.0.3176.0
Bad Build : 62.0.3177.0

Change Log URL: 
https://chromium.googlesource.com/chromium/src/+log/29eff3ab49027f70d179c783247568a3ffaacdac..e3d9eee91f3dfe5503bde5f3f4fc776e1552f857

From the above change log suspecting below change
Change-Id: Ic651c35e1ce865f3008dd345952a6fbc97d94740
Reviewed-on: https://chromium-review.googlesource.com/596503

enne@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks...!!

Comment 5 by enne@chromium.org, May 23 2018

Cc: pdr@chromium.org chrishtr@chromium.org enne@chromium.org
Labels: -Pri-1 Pri-2
Owner: wangxianzhu@chromium.org
wangxianzhu, I'm sending this your way because you were looking at this for slimming paint 175.

We might want to consider moving this clip to the callers instead of having a clip on ever display item right now instead of waiting for future slimming paint versions.  This is what I was suggesting in https://chromium-review.googlesource.com/c/chromium/src/+/596503#message-5a37c12f90ad433090baa26a8135e7f6ce5517f4.

(I think something that's been around since M62 is not a P1, sorry.)

Comment 6 by wangxianzhu@chromium.org, May 24 2018

Components: -Internals>Compositing Blink>Paint
Labels: -Target-66 -Target-67
Actually SPv175 doesn't issue the clip and we haven't observed any bugs. I also ran the tests of  bug 750252  without the clip with SPv175 disabled and didn't observe any bug. So I think the bug that a saveLayer requires an explicit clip has been fixed in Skia.

However, SPv175 still has performance issue because of inefficient paint operations for the reported case.

For the test case, SPv1 with the clip issues:
 ...
 Save
 Concat
   SaveLayerAlpha
     ClipRect
     DrawPath
   Restore
   SaveLayerAlpha
     ClipRect
     DrawPath
   Restore
   ...
 Restore
 ...
and during rasterization, each SaveLayerAlpha/ClipRect/DrawPath sequence is combined into a single DrawPath operation. The ClipRect operation doesn't affect the final operations, but still have cost for the raster operation optimizer.

SPv175 issues:
 ...
 SaveLayerAlpha
   Save
     Concat
     ClipRect
     DrawPath
   Restore
 Restore
 SaveLayerAlpha
   Save
     Concat
     ClipRect
     DrawPath
   Restore
 Restore
 ...
and during rasterization, the optimizer can't optimize like it does for SPv1 because of the Save/Concat/Restore operations within the SaveLayerAlpha/Restore pairs, causing bad raster performance.

We need to extract the common Save/Concat/Restore out of the SaveLayerAlpha/Restore pairs.
Project Member

Comment 7 by bugdroid1@chromium.org, May 26 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72bd63baf79068a2a7b11fdf6b6ca3d27ffde62d

commit 72bd63baf79068a2a7b11fdf6b6ca3d27ffde62d
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Sat May 26 04:09:42 2018

[PE] Switch to an effect's transform before applying the effect

This optimizes for the following case:
  t1 = transform;
  e1 = effect(localTransformSpace = t1, opacity=0.5)

  chunk0(transform-root, clip-root, effect-root)
  chunk1(t1, clip-root, e1)
  chunk2(t1, clip-root, e1)

Previously we issued the following paint operations:
  SaveLayerAlpha
    Save
      Concat
      DrawRecord
    Restore
  Restore
  SaveLayerAlpha
    Save
      Concat
      DrawRecord
    Restore
  Restore

Now we issue:
  Save
    Concat
    SaveLayerAlpha
      DrawRecord
    Restore
    SaveLayerAlpha
      DrawRecord
    Restore
  Restore

The latter sequence is much faster to rasterize because
- It has only one Save/Concat/.../Restore pair for all of the
  effects instead of one for each effect;
- The rasterizer can further optimize SaveLayerAlpha/DrawRecord/
  Restore into a single DrawRecord which is even faster.

Bug:  845711 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I1e48300b2fe0526959172a92bf9f4bc6d70a51ab
Reviewed-on: https://chromium-review.googlesource.com/1072901
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562113}
[modify] https://crrev.com/72bd63baf79068a2a7b11fdf6b6ca3d27ffde62d/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[modify] https://crrev.com/72bd63baf79068a2a7b11fdf6b6ca3d27ffde62d/third_party/WebKit/LayoutTests/fast/sub-pixel/save-layer-bounds-should-snap-expected.html
[add] https://crrev.com/72bd63baf79068a2a7b11fdf6b6ca3d27ffde62d/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/transforms/2d/hindi-rotated-expected.png
[add] https://crrev.com/72bd63baf79068a2a7b11fdf6b6ca3d27ffde62d/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/transforms/transform-on-inline-expected.png
[add] https://crrev.com/72bd63baf79068a2a7b11fdf6b6ca3d27ffde62d/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/transforms/transform-table-row-expected.png
[modify] https://crrev.com/72bd63baf79068a2a7b11fdf6b6ca3d27ffde62d/third_party/WebKit/LayoutTests/paint/invalidation/compositing/fixed-pos-inside-composited-intermediate-layer-expected.png
[modify] https://crrev.com/72bd63baf79068a2a7b11fdf6b6ca3d27ffde62d/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/position/fixed-expected.png
[modify] https://crrev.com/72bd63baf79068a2a7b11fdf6b6ca3d27ffde62d/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/scroll/fixed-child-move-after-scroll-expected.png
[modify] https://crrev.com/72bd63baf79068a2a7b11fdf6b6ca3d27ffde62d/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/scroll/fixed-child-of-fixed-move-after-scroll-expected.png
[modify] https://crrev.com/72bd63baf79068a2a7b11fdf6b6ca3d27ffde62d/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/scroll/fixed-move-after-scroll-expected.png
[modify] https://crrev.com/72bd63baf79068a2a7b11fdf6b6ca3d27ffde62d/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/textAnchor-expected.png
[modify] https://crrev.com/72bd63baf79068a2a7b11fdf6b6ca3d27ffde62d/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/textProperties-expected.png
[modify] https://crrev.com/72bd63baf79068a2a7b11fdf6b6ca3d27ffde62d/third_party/WebKit/LayoutTests/platform/linux/svg/custom/dominant-baseline-hanging-expected.png
[modify] https://crrev.com/72bd63baf79068a2a7b11fdf6b6ca3d27ffde62d/third_party/WebKit/LayoutTests/platform/linux/transforms/2d/hindi-rotated-expected.png
[modify] https://crrev.com/72bd63baf79068a2a7b11fdf6b6ca3d27ffde62d/third_party/WebKit/LayoutTests/platform/linux/transforms/transform-on-inline-expected.png
[modify] https://crrev.com/72bd63baf79068a2a7b11fdf6b6ca3d27ffde62d/third_party/WebKit/LayoutTests/platform/linux/transforms/transform-table-row-expected.png
[modify] https://crrev.com/72bd63baf79068a2a7b11fdf6b6ca3d27ffde62d/third_party/WebKit/LayoutTests/platform/mac-mac10.10/svg/custom/dominant-baseline-hanging-expected.png
[modify] https://crrev.com/72bd63baf79068a2a7b11fdf6b6ca3d27ffde62d/third_party/WebKit/LayoutTests/platform/mac-mac10.10/transforms/2d/hindi-rotated-expected.png
[modify] https://crrev.com/72bd63baf79068a2a7b11fdf6b6ca3d27ffde62d/third_party/WebKit/LayoutTests/platform/mac-mac10.12/svg/batik/text/textAnchor-expected.png
[modify] https://crrev.com/72bd63baf79068a2a7b11fdf6b6ca3d27ffde62d/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/filters/filter-on-html-element-with-fixed-position-child-expected.png
[modify] https://crrev.com/72bd63baf79068a2a7b11fdf6b6ca3d27ffde62d/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/position/fixed-expected.png
[modify] https://crrev.com/72bd63baf79068a2a7b11fdf6b6ca3d27ffde62d/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/scroll/fixed-child-move-after-scroll-expected.png
[modify] https://crrev.com/72bd63baf79068a2a7b11fdf6b6ca3d27ffde62d/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/scroll/fixed-child-of-fixed-move-after-scroll-expected.png
[modify] https://crrev.com/72bd63baf79068a2a7b11fdf6b6ca3d27ffde62d/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/scroll/fixed-move-after-scroll-expected.png
[modify] https://crrev.com/72bd63baf79068a2a7b11fdf6b6ca3d27ffde62d/third_party/WebKit/LayoutTests/platform/mac/svg/batik/text/textAnchor-expected.png
[modify] https://crrev.com/72bd63baf79068a2a7b11fdf6b6ca3d27ffde62d/third_party/WebKit/LayoutTests/platform/mac/svg/batik/text/textProperties-expected.png
[modify] https://crrev.com/72bd63baf79068a2a7b11fdf6b6ca3d27ffde62d/third_party/WebKit/LayoutTests/platform/mac/svg/custom/dominant-baseline-hanging-expected.png
[modify] https://crrev.com/72bd63baf79068a2a7b11fdf6b6ca3d27ffde62d/third_party/WebKit/LayoutTests/platform/mac/transforms/2d/hindi-rotated-expected.png
[modify] https://crrev.com/72bd63baf79068a2a7b11fdf6b6ca3d27ffde62d/third_party/WebKit/LayoutTests/platform/mac/transforms/transform-on-inline-expected.png
[modify] https://crrev.com/72bd63baf79068a2a7b11fdf6b6ca3d27ffde62d/third_party/WebKit/LayoutTests/platform/mac/transforms/transform-table-row-expected.png
[modify] https://crrev.com/72bd63baf79068a2a7b11fdf6b6ca3d27ffde62d/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/filters/filter-on-html-element-with-fixed-position-child-expected.png
[modify] https://crrev.com/72bd63baf79068a2a7b11fdf6b6ca3d27ffde62d/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/position/fixed-expected.png
[modify] https://crrev.com/72bd63baf79068a2a7b11fdf6b6ca3d27ffde62d/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/scroll/fixed-child-move-after-scroll-expected.png
[modify] https://crrev.com/72bd63baf79068a2a7b11fdf6b6ca3d27ffde62d/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/scroll/fixed-child-of-fixed-move-after-scroll-expected.png
[modify] https://crrev.com/72bd63baf79068a2a7b11fdf6b6ca3d27ffde62d/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/scroll/fixed-move-after-scroll-expected.png
[modify] https://crrev.com/72bd63baf79068a2a7b11fdf6b6ca3d27ffde62d/third_party/WebKit/LayoutTests/platform/win/svg/batik/text/textAnchor-expected.png
[modify] https://crrev.com/72bd63baf79068a2a7b11fdf6b6ca3d27ffde62d/third_party/WebKit/LayoutTests/platform/win/svg/batik/text/textProperties-expected.png
[modify] https://crrev.com/72bd63baf79068a2a7b11fdf6b6ca3d27ffde62d/third_party/WebKit/LayoutTests/platform/win/svg/custom/dominant-baseline-hanging-expected.png
[modify] https://crrev.com/72bd63baf79068a2a7b11fdf6b6ca3d27ffde62d/third_party/WebKit/LayoutTests/platform/win/transforms/transform-on-inline-expected.png
[modify] https://crrev.com/72bd63baf79068a2a7b11fdf6b6ca3d27ffde62d/third_party/WebKit/LayoutTests/platform/win/transforms/transform-table-row-expected.png
[modify] https://crrev.com/72bd63baf79068a2a7b11fdf6b6ca3d27ffde62d/third_party/WebKit/LayoutTests/platform/win7/transforms/2d/hindi-rotated-expected.png
[modify] https://crrev.com/72bd63baf79068a2a7b11fdf6b6ca3d27ffde62d/third_party/WebKit/LayoutTests/svg/custom/marker-zero-length-linecaps-expected.png
[modify] https://crrev.com/72bd63baf79068a2a7b11fdf6b6ca3d27ffde62d/third_party/WebKit/LayoutTests/svg/custom/small-rect-scale-expected.png
[add] https://crrev.com/72bd63baf79068a2a7b11fdf6b6ca3d27ffde62d/third_party/WebKit/LayoutTests/virtual/disable-spv175/paint/invalidation/compositing/fixed-pos-inside-composited-intermediate-layer-expected.png
[add] https://crrev.com/72bd63baf79068a2a7b11fdf6b6ca3d27ffde62d/third_party/WebKit/LayoutTests/virtual/disable-spv175/paint/invalidation/filters/filter-on-html-element-with-fixed-position-child-expected.png
[modify] https://crrev.com/72bd63baf79068a2a7b11fdf6b6ca3d27ffde62d/third_party/blink/renderer/platform/graphics/compositing/paint_chunks_to_cc_layer.cc
[modify] https://crrev.com/72bd63baf79068a2a7b11fdf6b6ca3d27ffde62d/third_party/blink/renderer/platform/graphics/compositing/paint_chunks_to_cc_layer_test.cc

Comment 8 by monfera....@gmail.com, May 27 2018 

Thanks for confirming and dispatching the above issue. I just run into another example for this speed regression, this used to run at least 30FPS (if not 60FPS) before; now it's 9FPS with double the CPU core count, higher CPU frequency and now a dedicated GPU card: https://codepen.io/monfera/pen/oLoRgX

It runs fluidly in FireFox.

It doesn't run well on Safari because Safari is very slow if the SVG point objects are directly manipulated in the DOM, rather than restated via an SVG attribute string, ie. the Safari slowness has an unrelated reason.

Comment 9 by monfera....@gmail.com, May 27 2018 

... also, there's flashing of the translucent gray painted area (in Chrome; FireFox looks good). I'm not sure if it relates to the recent https://bugs.chromium.org/p/chromium/issues/detail?id=844998

Comment 10 by wangxianzhu@chromium.org, May 27 2018

Labels: -Needs-Triage-M66
monfera.robert@gmail.com, thanks for the new report. I just tried the test case on the latest Canary and it can reach near 60fps. Can you double-check?

Comment 11 by monfera....@gmail.com, May 28 2018 

Thanks for the suggestion. I just installed a fresh Canary and still get 8.5..9FPS. In the above thread,  krajshree@ said that the issue was confirmed, listing specific platforms and versions, including Canary. I have to confess I've no idea if this second example has the same root cause as what I put in the original report; the commonality is that there's a significant slowdown (a fraction of the speed it originally was when I made it). I don't know if you were asking me to check Canary because there was a fix since, but in any case it still runs at around 20% of the original speed.

Comment 12 by krajshree@chromium.org, May 28 2018

Cc: krajshree@chromium.org
Labels: Needs-Feedback
Tested the issue on mac 10.13.3, win-10 and ubuntu 17.10 using latest chrome version #69.0.3443.0.
Observed that on OS-mac, chrome frame rate was around 56-57 fps. On OS-win, chrome frame rate remained at constant frame rate of 60 fps. On OS-linux, chrome frame rate dropped till 18 fps.

Attached screen casts and screen shot for reference.

wangxianzhu@ - Could you please check the attached screen casts and please help us in confirming the fix.

Thanks...!!
845711@linux.webm
7.0 MB View Download
845711@win.PNG
430 KB View Download
845711@mac.mp4
3.1 MB View Download

Comment 13 by monfera....@gmail.com, May 28 2018 

Thanks for the awesome quick solution, on said Canary version #69.0.3443.0 on my OS X machine it is a super solid 60FPS!

Comment 14 by monfera....@gmail.com, May 28 2018 

... not sure if it's related (Blink paint invalidation): some paint residue reported and fixed earlier came back, see the attachment; piece is here: https://t.d3fc.io/status/705212795936247808

The original report for that was https://bugs.chromium.org/p/chromium/issues/detail?id=739643 

The paint residue is now less prominent than before the fix of 739643, and sometimes it's scintillating a little bit, or can clear up on action (window resize etc.)
Screen Shot 2018-05-28 at 4.21.59 PM.png
28.6 KB View Download

Comment 15 by wangxianzhu@chromium.org, May 28 2018

Labels: Merge-Request-68

Comment 16 by wangxianzhu@chromium.org, May 28 2018 

Reopened bug 739643 as per #c14.
Project Member

Comment 17 by sheriffbot@chromium.org, May 29 2018

Labels: -Merge-Request-68 Hotlist-Merge-Approved Merge-Approved-68
Your change meets the bar and is auto-approved for M68. Please go ahead and merge the CL to branch 3440 manually. Please contact milestone owner if you have questions.
Owners: cmasso@(Android), kariahda@(iOS), bhthompson@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 18 by bugdroid1@chromium.org, May 29 2018

Labels: -merge-approved-68 merge-merged-3440
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/32bed4519b268a3922bf174bee5cef3b24c423a7

commit 32bed4519b268a3922bf174bee5cef3b24c423a7
Author: Xianzhu Wang <wangxianzhu@chromium.org>
Date: Tue May 29 16:26:30 2018

[PE] Switch to an effect's transform before applying the effect

This optimizes for the following case:
  t1 = transform;
  e1 = effect(localTransformSpace = t1, opacity=0.5)

  chunk0(transform-root, clip-root, effect-root)
  chunk1(t1, clip-root, e1)
  chunk2(t1, clip-root, e1)

Previously we issued the following paint operations:
  SaveLayerAlpha
    Save
      Concat
      DrawRecord
    Restore
  Restore
  SaveLayerAlpha
    Save
      Concat
      DrawRecord
    Restore
  Restore

Now we issue:
  Save
    Concat
    SaveLayerAlpha
      DrawRecord
    Restore
    SaveLayerAlpha
      DrawRecord
    Restore
  Restore

The latter sequence is much faster to rasterize because
- It has only one Save/Concat/.../Restore pair for all of the
  effects instead of one for each effect;
- The rasterizer can further optimize SaveLayerAlpha/DrawRecord/
  Restore into a single DrawRecord which is even faster.

TBR=wangxianzhu@chromium.org

(cherry picked from commit 72bd63baf79068a2a7b11fdf6b6ca3d27ffde62d)

Bug:  845711 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I1e48300b2fe0526959172a92bf9f4bc6d70a51ab
Reviewed-on: https://chromium-review.googlesource.com/1072901
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#562113}
Reviewed-on: https://chromium-review.googlesource.com/1076669
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#22}
Cr-Branched-From: 010ddcfda246975d194964ccf20038ebbdec6084-refs/heads/master@{#561733}
[modify] https://crrev.com/32bed4519b268a3922bf174bee5cef3b24c423a7/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[modify] https://crrev.com/32bed4519b268a3922bf174bee5cef3b24c423a7/third_party/WebKit/LayoutTests/fast/sub-pixel/save-layer-bounds-should-snap-expected.html
[add] https://crrev.com/32bed4519b268a3922bf174bee5cef3b24c423a7/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/transforms/2d/hindi-rotated-expected.png
[add] https://crrev.com/32bed4519b268a3922bf174bee5cef3b24c423a7/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/transforms/transform-on-inline-expected.png
[add] https://crrev.com/32bed4519b268a3922bf174bee5cef3b24c423a7/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/transforms/transform-table-row-expected.png
[modify] https://crrev.com/32bed4519b268a3922bf174bee5cef3b24c423a7/third_party/WebKit/LayoutTests/paint/invalidation/compositing/fixed-pos-inside-composited-intermediate-layer-expected.png
[modify] https://crrev.com/32bed4519b268a3922bf174bee5cef3b24c423a7/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/position/fixed-expected.png
[modify] https://crrev.com/32bed4519b268a3922bf174bee5cef3b24c423a7/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/scroll/fixed-child-move-after-scroll-expected.png
[modify] https://crrev.com/32bed4519b268a3922bf174bee5cef3b24c423a7/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/scroll/fixed-child-of-fixed-move-after-scroll-expected.png
[modify] https://crrev.com/32bed4519b268a3922bf174bee5cef3b24c423a7/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/scroll/fixed-move-after-scroll-expected.png
[modify] https://crrev.com/32bed4519b268a3922bf174bee5cef3b24c423a7/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/textAnchor-expected.png
[modify] https://crrev.com/32bed4519b268a3922bf174bee5cef3b24c423a7/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/textProperties-expected.png
[modify] https://crrev.com/32bed4519b268a3922bf174bee5cef3b24c423a7/third_party/WebKit/LayoutTests/platform/linux/svg/custom/dominant-baseline-hanging-expected.png
[modify] https://crrev.com/32bed4519b268a3922bf174bee5cef3b24c423a7/third_party/WebKit/LayoutTests/platform/linux/transforms/2d/hindi-rotated-expected.png
[modify] https://crrev.com/32bed4519b268a3922bf174bee5cef3b24c423a7/third_party/WebKit/LayoutTests/platform/linux/transforms/transform-on-inline-expected.png
[modify] https://crrev.com/32bed4519b268a3922bf174bee5cef3b24c423a7/third_party/WebKit/LayoutTests/platform/linux/transforms/transform-table-row-expected.png
[modify] https://crrev.com/32bed4519b268a3922bf174bee5cef3b24c423a7/third_party/WebKit/LayoutTests/platform/mac-mac10.10/svg/custom/dominant-baseline-hanging-expected.png
[modify] https://crrev.com/32bed4519b268a3922bf174bee5cef3b24c423a7/third_party/WebKit/LayoutTests/platform/mac-mac10.10/transforms/2d/hindi-rotated-expected.png
[modify] https://crrev.com/32bed4519b268a3922bf174bee5cef3b24c423a7/third_party/WebKit/LayoutTests/platform/mac-mac10.12/svg/batik/text/textAnchor-expected.png
[modify] https://crrev.com/32bed4519b268a3922bf174bee5cef3b24c423a7/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/filters/filter-on-html-element-with-fixed-position-child-expected.png
[modify] https://crrev.com/32bed4519b268a3922bf174bee5cef3b24c423a7/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/position/fixed-expected.png
[modify] https://crrev.com/32bed4519b268a3922bf174bee5cef3b24c423a7/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/scroll/fixed-child-move-after-scroll-expected.png
[modify] https://crrev.com/32bed4519b268a3922bf174bee5cef3b24c423a7/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/scroll/fixed-child-of-fixed-move-after-scroll-expected.png
[modify] https://crrev.com/32bed4519b268a3922bf174bee5cef3b24c423a7/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/scroll/fixed-move-after-scroll-expected.png
[modify] https://crrev.com/32bed4519b268a3922bf174bee5cef3b24c423a7/third_party/WebKit/LayoutTests/platform/mac/svg/batik/text/textAnchor-expected.png
[modify] https://crrev.com/32bed4519b268a3922bf174bee5cef3b24c423a7/third_party/WebKit/LayoutTests/platform/mac/svg/batik/text/textProperties-expected.png
[modify] https://crrev.com/32bed4519b268a3922bf174bee5cef3b24c423a7/third_party/WebKit/LayoutTests/platform/mac/svg/custom/dominant-baseline-hanging-expected.png
[modify] https://crrev.com/32bed4519b268a3922bf174bee5cef3b24c423a7/third_party/WebKit/LayoutTests/platform/mac/transforms/2d/hindi-rotated-expected.png
[modify] https://crrev.com/32bed4519b268a3922bf174bee5cef3b24c423a7/third_party/WebKit/LayoutTests/platform/mac/transforms/transform-on-inline-expected.png
[modify] https://crrev.com/32bed4519b268a3922bf174bee5cef3b24c423a7/third_party/WebKit/LayoutTests/platform/mac/transforms/transform-table-row-expected.png
[modify] https://crrev.com/32bed4519b268a3922bf174bee5cef3b24c423a7/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/filters/filter-on-html-element-with-fixed-position-child-expected.png
[modify] https://crrev.com/32bed4519b268a3922bf174bee5cef3b24c423a7/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/position/fixed-expected.png
[modify] https://crrev.com/32bed4519b268a3922bf174bee5cef3b24c423a7/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/scroll/fixed-child-move-after-scroll-expected.png
[modify] https://crrev.com/32bed4519b268a3922bf174bee5cef3b24c423a7/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/scroll/fixed-child-of-fixed-move-after-scroll-expected.png
[modify] https://crrev.com/32bed4519b268a3922bf174bee5cef3b24c423a7/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/scroll/fixed-move-after-scroll-expected.png
[modify] https://crrev.com/32bed4519b268a3922bf174bee5cef3b24c423a7/third_party/WebKit/LayoutTests/platform/win/svg/batik/text/textAnchor-expected.png
[modify] https://crrev.com/32bed4519b268a3922bf174bee5cef3b24c423a7/third_party/WebKit/LayoutTests/platform/win/svg/batik/text/textProperties-expected.png
[modify] https://crrev.com/32bed4519b268a3922bf174bee5cef3b24c423a7/third_party/WebKit/LayoutTests/platform/win/svg/custom/dominant-baseline-hanging-expected.png
[modify] https://crrev.com/32bed4519b268a3922bf174bee5cef3b24c423a7/third_party/WebKit/LayoutTests/platform/win/transforms/transform-on-inline-expected.png
[modify] https://crrev.com/32bed4519b268a3922bf174bee5cef3b24c423a7/third_party/WebKit/LayoutTests/platform/win/transforms/transform-table-row-expected.png
[modify] https://crrev.com/32bed4519b268a3922bf174bee5cef3b24c423a7/third_party/WebKit/LayoutTests/platform/win7/transforms/2d/hindi-rotated-expected.png
[modify] https://crrev.com/32bed4519b268a3922bf174bee5cef3b24c423a7/third_party/WebKit/LayoutTests/svg/custom/marker-zero-length-linecaps-expected.png
[modify] https://crrev.com/32bed4519b268a3922bf174bee5cef3b24c423a7/third_party/WebKit/LayoutTests/svg/custom/small-rect-scale-expected.png
[add] https://crrev.com/32bed4519b268a3922bf174bee5cef3b24c423a7/third_party/WebKit/LayoutTests/virtual/disable-spv175/paint/invalidation/compositing/fixed-pos-inside-composited-intermediate-layer-expected.png
[add] https://crrev.com/32bed4519b268a3922bf174bee5cef3b24c423a7/third_party/WebKit/LayoutTests/virtual/disable-spv175/paint/invalidation/filters/filter-on-html-element-with-fixed-position-child-expected.png
[modify] https://crrev.com/32bed4519b268a3922bf174bee5cef3b24c423a7/third_party/blink/renderer/platform/graphics/compositing/paint_chunks_to_cc_layer.cc
[modify] https://crrev.com/32bed4519b268a3922bf174bee5cef3b24c423a7/third_party/blink/renderer/platform/graphics/compositing/paint_chunks_to_cc_layer_test.cc

Comment 19 by wangxianzhu@chromium.org, May 29 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment