New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment
link

Issue 845700: Add //build/config:exe_and_shlib_deps to set_defaults for executable and shared_library targets

Reported by thomasanderson@chromium.org, May 22 2018 Project Member

Issue description

Currently, all executables and shared libraries are expected to add the exe_and_shlib_deps dependency manually.  However, it is easy to forget to do this.  In such cases, the build will likely fail at the link step due to missing libc++ symbols.  It may not be obvious how to fix this issue.

The alternative is the following:
set_defaults("executable") {
  ...
  deps = [ "//build/config:exe_and_shlib_deps "]
}
set_defaults("shared_library") {
  ...
  deps = [ "//build/config:exe_and_shlib_deps "]
}

The disadvantage here is that many targets will need to update "deps = " to "deps +=".  Fortunately, gn warns when overwriting a non-empty list, so it's easy to identify these cases.
 

Comment 1 by thomasanderson@chromium.org, May 22 2018

dpranke/thakis/brettw wdyt?  IMO this is better than the alternative of having to manually specify the dependency.

Though it's unclear how we would go about actually making such a change.  It would seem that we would have to update all of the targets at the same time as the set_defaults() change.  This would be impossible since we need to update Chrome, all dependent repos that have BUILD.gn files, and roll gn and all dependent repos in one CL.

I think the only way to do this would be to temporarily add a hack in gn to suppress overwriting deps when the list is exactly [ "//build/config:exe_and_shlib_deps" ] and remove it once the switch is complete.

Comment 2 by dpranke@chromium.org, May 22 2018

> The disadvantage here is that many targets will need to update
> "deps = " to "deps +=".

That's right, I think perhaps that's the reason we didn't want to do this originally.

At some point we made it possible for a template to override the built-in rule:

https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/reference.md#overriding-builtin-targets

I think that probably could be a seamless way to do what we want?

Comment 3 by thomasanderson@chromium.org, May 22 2018

Nice! That seems to work!  I'll you a CL for that soon

Comment 4 by bugdroid1@chromium.org, May 22 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/buildtools/+/893eb86b02b2571894e328f05551112b96df1cce

commit 893eb86b02b2571894e328f05551112b96df1cce
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Tue May 22 23:28:27 2018

Set no_default_deps in shared libc++ builds

TBR=dpranke
BUG= 845700 

Change-Id: I71f45f6c95c20ac0a779116e0ae8f542e614db6e
[modify] https://crrev.com/893eb86b02b2571894e328f05551112b96df1cce/third_party/libc++/BUILD.gn

Comment 5 by bugdroid1@chromium.org, May 25 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7ed1f0a9c28c932fddc834ca5de44f28266c7f5

commit d7ed1f0a9c28c932fddc834ca5de44f28266c7f5
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Fri May 25 01:40:23 2018

Add exe_and_shlib_deps to executable and shared_library configs

Currently, all executables and shared libraries are expected to add the
exe_and_shlib_deps dependency manually.  However, it is easy to forget to do
this.  In such cases, the build will likely fail at the link step due to missing
libc++ symbols.  It may not be obvious how to fix this issue.

This CL adds exe_and_shlib_deps as an implicit dependency to executable and
shared_library targets so that developers don't have to manually add it.

BUG= 845700 
R=dpranke
TBR=torne

Change-Id: I30edcf0bcd6559b1aaa211a42863b04bc57d4d99
Reviewed-on: https://chromium-review.googlesource.com/1069720
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561729}
[modify] https://crrev.com/d7ed1f0a9c28c932fddc834ca5de44f28266c7f5/DEPS
[modify] https://crrev.com/d7ed1f0a9c28c932fddc834ca5de44f28266c7f5/android_webview/test/BUILD.gn
[modify] https://crrev.com/d7ed1f0a9c28c932fddc834ca5de44f28266c7f5/build/config/BUILDCONFIG.gn
[modify] https://crrev.com/d7ed1f0a9c28c932fddc834ca5de44f28266c7f5/chrome/test/data/nacl/BUILD.gn
[modify] https://crrev.com/d7ed1f0a9c28c932fddc834ca5de44f28266c7f5/tools/gn/BUILD.gn

Comment 6 by thomasanderson@chromium.org, May 25 2018

Status: Started (was: Available)

Comment 7 by thomasanderson@chromium.org, May 25 2018

Cc: jbudorick@chromium.org s...@chromium.org
 Issue 746091  has been merged into this issue.

Comment 9 by bugdroid1@chromium.org, May 30 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a283ff78c63228f088829b8e36d6b7d4d168330b

commit a283ff78c63228f088829b8e36d6b7d4d168330b
Author: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed May 30 03:24:06 2018

Roll src/third_party/pdfium a210ee1..16ccc8b (1 commits)

https://pdfium.googlesource.com/pdfium.git/+log/a210ee1..16ccc8b


git log a210ee1..16ccc8b --date=short --no-merges --format='%ad %ae %s'
2018-05-30 thomasanderson@chromium.org Roll DEPS for build and buildtools.

Created with:
  gclient setdep -r src/third_party/pdfium@16ccc8b

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:845700 

TBR=dsinclair@chromium.org

Change-Id: I7b4167110a88b84678753dd5f5f3cb1fce510ffb
Reviewed-on: https://chromium-review.googlesource.com/1077772
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#562719}
[modify] https://crrev.com/a283ff78c63228f088829b8e36d6b7d4d168330b/DEPS

Comment 10 by bugdroid1@chromium.org, May 30 2018

Project Member
The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/625255b6f8a6f6ee4b7b1eab8202b47c46659fb7

commit 625255b6f8a6f6ee4b7b1eab8202b47c46659fb7
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Wed May 30 18:18:11 2018

Remove manual references to exe_and_shlib_deps

After [1], a manual dependency on exe_and_shlib_deps is no longer necessary
since it's automatically added.  This CL removes all remaining manual references
to exe_and_shlib_deps.

[1] https://chromium.googlesource.com/chromium/src.git/+/d7ed1f0a9c28c932fddc834ca5de44f28266c7f5

BUG= chromium:845700 
R=thestig

Change-Id: I5708e7c662b24493d1216f9a802dfce3de5dbea6
Reviewed-on: https://pdfium-review.googlesource.com/33151
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>

[modify] https://crrev.com/625255b6f8a6f6ee4b7b1eab8202b47c46659fb7/BUILD.gn
[modify] https://crrev.com/625255b6f8a6f6ee4b7b1eab8202b47c46659fb7/third_party/yasm/BUILD.gn
[modify] https://crrev.com/625255b6f8a6f6ee4b7b1eab8202b47c46659fb7/samples/BUILD.gn
[modify] https://crrev.com/625255b6f8a6f6ee4b7b1eab8202b47c46659fb7/testing/test.gni

Comment 11 by bugdroid1@chromium.org, May 30 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce772faa73ab8fa58e848b61b786d449bb988237

commit ce772faa73ab8fa58e848b61b786d449bb988237
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Wed May 30 22:20:37 2018

Remove references to exe_and_shlib_deps in src

After [1], a manual dependency on exe_and_shlib_deps is no longer necessary
since it's automatically added.  This CL removes all remaining manual references
to exe_and_shlib_deps.

[1] https://chromium.googlesource.com/chromium/src.git/+/d7ed1f0a9c28c932fddc834ca5de44f28266c7f5

BUG= 845700 
R=dpranke
TBR=sky,mark

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_compile_x64_dbg;master.tryserver.chromium.android:android_compile_x86_dbg;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I647442fb09eba4c055697bf26504abc3b3284d94
Reviewed-on: https://chromium-review.googlesource.com/1073613
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563028}
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/android_webview/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/android_webview/test/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/ash/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/base/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/base/android/jni_generator/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/base/android/linker/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/base/test/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/build/config/BUILDCONFIG.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/build/config/android/internal_rules.gni
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/build/config/sanitizers/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/chrome/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/chrome/android/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/chrome/browser/nacl_host/test/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/chrome/browser/resources/chromeos/zip_archiver/cpp/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/chrome/browser/vr/testapp/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/chrome/chrome_watcher/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/chrome/installer/mini_installer/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/chrome/installer/setup/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/chrome/installer/test/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/chrome/test/chromedriver/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/chrome/tools/convert_dict/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/chrome/tools/service_discovery_sniffer/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/chrome_elf/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/chromecast/chromecast.gni
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/components/cronet/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/components/exo/wayland/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/components/nacl/loader/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/components/subresource_filter/tools/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/components/sync/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/components/url_formatter/top_domains/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/components/wifi/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/components/zucchini/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/content/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/content/browser/bluetooth/tools/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/content/shell/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/content/shell/android/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/courgette/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/dbus/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/extensions/shell/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/gin/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/google_apis/gcm/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/gpu/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/gpu/gles2_conform_support/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/gpu/tools/compositor_model_bench/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/headless/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/ios/showcase/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/ios/web/shell/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/ios/web/shell/test/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/ios/web_view/shell/test/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/mash/runner/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/media/cast/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/media/cdm/library_cdm/clear_key_cdm/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/mojo/android/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/mojo/edk/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/mojo/public/tools/fuzzers/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/net/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/net/tools/transport_security_state_generator/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/ppapi/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/ppapi/examples/ppapi_example.gni
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/remoting/client/jni/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/remoting/host/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/remoting/host/it2me/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/remoting/host/linux/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/remoting/host/mac/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/remoting/test/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/remoting/tools/javascript_key_tester/pnacl/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/rlz/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/sandbox/linux/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/sandbox/win/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/services/service_manager/public/cpp/service.gni
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/services/service_manager/tests/connect/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/services/service_manager/tests/lifecycle/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/services/service_manager/tests/service_manager/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/skia/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/storage/browser/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/testing/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/testing/test.gni
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/third_party/android_crazy_linker/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/third_party/android_platform/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/third_party/android_protobuf/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/third_party/blink/renderer/platform/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/third_party/breakpad/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/third_party/brotli/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/third_party/crashpad/crashpad/build/crashpad_buildconfig.gni
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/third_party/flatbuffers/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/third_party/ijar/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/third_party/leveldatabase/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/third_party/libdrm/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/third_party/libwebp/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/third_party/mesa/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/third_party/opus/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/third_party/protobuf/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/third_party/qcms/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/third_party/sqlite/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/third_party/yasm/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/third_party/zlib/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/tools/android/forwarder2/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/tools/android/md5sum/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/tools/android/memdump/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/tools/battor_agent/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/tools/gn/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/tools/imagediff/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/tools/perf/clear_system_cache/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/tools/xdisplaycheck/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/ui/app_list/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/ui/aura/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/ui/ozone/demo/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/ui/views/examples/BUILD.gn
[modify] https://crrev.com/ce772faa73ab8fa58e848b61b786d449bb988237/webrunner/BUILD.gn

Comment 12 by bugdroid1@chromium.org, May 30 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db0edeaad8667dbf579755f9f67b5e442b0cf2d4

commit db0edeaad8667dbf579755f9f67b5e442b0cf2d4
Author: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed May 30 23:51:44 2018

Roll src/third_party/pdfium 0789714..a7b65b8 (7 commits)

https://pdfium.googlesource.com/pdfium.git/+log/0789714..a7b65b8


git log 0789714..a7b65b8 --date=short --no-merges --format='%ad %ae %s'
2018-05-30 rharrison@chromium.org Migrate coverage_report.py to use upstream Chromium scripts
2018-05-30 npm@chromium.org Roll third_party/freetype/src/ 9e345c911..d45d4b97e (27 commits)
2018-05-30 thestig@chromium.org Remove dead code in various write function.
2018-05-30 thestig@chromium.org Add pixel tests for PDFs that use generation numbers.
2018-05-30 thestig@chromium.org Exclude certain colorspace types for calculating transparency backdrop color.
2018-05-30 thomasanderson@chromium.org Remove manual references to exe_and_shlib_deps
2018-05-30 tsepez@chromium.org Make common page base class for XFA and non-XFA.

Created with:
  gclient setdep -r src/third_party/pdfium@a7b65b8

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:847346 , chromium:845700 

TBR=dsinclair@chromium.org

Change-Id: I040d66e3a3a9344b7d3858c743a524f40ccd5a76
Reviewed-on: https://chromium-review.googlesource.com/1079847
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#563070}
[modify] https://crrev.com/db0edeaad8667dbf579755f9f67b5e442b0cf2d4/DEPS

Comment 13 by bugdroid1@chromium.org, Jun 4 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/c2455500f4a88a00ebb4fb2a27c4f46aff560bf5

commit c2455500f4a88a00ebb4fb2a27c4f46aff560bf5
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Mon Jun 04 18:35:43 2018

Remove manual references to exe_and_shlib_deps

After [1], a manual dependency on exe_and_shlib_deps is no longer necessary
since it's automatically added.  This CL removes all remaining manual references
to exe_and_shlib_deps.

[1] https://chromium.googlesource.com/chromium/src.git/+/d7ed1f0a9c28c932fddc834ca5de44f28266c7f5

BUG= chromium:845700 
R=machenbach

Change-Id: I17da573b7b6509a690caf8be6ae6afc180105f07
Reviewed-on: https://chromium-review.googlesource.com/1082913
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53500}
[modify] https://crrev.com/c2455500f4a88a00ebb4fb2a27c4f46aff560bf5/BUILD.gn
[modify] https://crrev.com/c2455500f4a88a00ebb4fb2a27c4f46aff560bf5/test/cctest/BUILD.gn
[modify] https://crrev.com/c2455500f4a88a00ebb4fb2a27c4f46aff560bf5/test/inspector/BUILD.gn
[modify] https://crrev.com/c2455500f4a88a00ebb4fb2a27c4f46aff560bf5/test/mkgrokdump/BUILD.gn
[modify] https://crrev.com/c2455500f4a88a00ebb4fb2a27c4f46aff560bf5/test/unittests/BUILD.gn

Comment 15 by bugdroid1@chromium.org, Jun 6 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b267c667033af80a79939c6cf3e7b5e6019c9ccc

commit b267c667033af80a79939c6cf3e7b5e6019c9ccc
Author: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed Jun 06 22:32:01 2018

Roll src/native_client 93deff4..82ff2ae (1 commits)

https://chromium.googlesource.com/native_client/src/native_client.git/+log/93deff4..82ff2ae


git log 93deff4..82ff2ae --date=short --no-merges --format='%ad %ae %s'
2018-06-06 thomasanderson@chromium.org Remove manual references to exe_and_shlib_deps


Created with:
  gclient setdep -r src/native_client@82ff2ae

The AutoRoll server is located here: https://nacl-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:845700 
TBR=mseaborn@chromium.org

Change-Id: Iea87daa701390fc3f17f4fbbd2b88aad16dce4f2
Reviewed-on: https://chromium-review.googlesource.com/1089550
Reviewed-by: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#565063}
[modify] https://crrev.com/b267c667033af80a79939c6cf3e7b5e6019c9ccc/DEPS

Comment 16 by bugdroid1@chromium.org, Jun 8 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/a4a3c19a4367f64b6a5db1d2cd9b3c32ab663d4d

commit a4a3c19a4367f64b6a5db1d2cd9b3c32ab663d4d
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Fri Jun 08 17:28:35 2018

Remove manual references to exe_and_shlib_deps

After [1], a manual dependency on exe_and_shlib_deps is no longer necessary
since it's automatically added.  This CL removes all remaining manual references
to exe_and_shlib_deps.

[1] https://chromium.googlesource.com/chromium/src.git/+/d7ed1f0a9c28c932fddc834ca5de44f28266c7f5

BUG= chromium:845700 

Change-Id: I66bcead6586050bf952c4aa1f4d3f726c88d2277
Reviewed-on: https://chromium-review.googlesource.com/1091231
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

[modify] https://crrev.com/a4a3c19a4367f64b6a5db1d2cd9b3c32ab663d4d/src/tests/BUILD.gn
[modify] https://crrev.com/a4a3c19a4367f64b6a5db1d2cd9b3c32ab663d4d/BUILD.gn
[modify] https://crrev.com/a4a3c19a4367f64b6a5db1d2cd9b3c32ab663d4d/third_party/glslang/BUILD.gn
[modify] https://crrev.com/a4a3c19a4367f64b6a5db1d2cd9b3c32ab663d4d/third_party/vulkan-validation-layers/BUILD.gn

Comment 17 by bugdroid1@chromium.org, Jun 9 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e27f4c7cc547d27a75eeeb28579581bebee61b0

commit 3e27f4c7cc547d27a75eeeb28579581bebee61b0
Author: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Sat Jun 09 02:54:08 2018

Roll src/third_party/angle 4b06c1e..f15f886 (7 commits)

https://chromium.googlesource.com/angle/angle.git/+log/4b06c1e..f15f886


git log 4b06c1e..f15f886 --date=short --no-merges --format='%ad %ae %s'
2018-06-08 ynovikov@chromium.org Differentiate texture and renderbuffer framebuffer attachment capabilities
2018-06-08 lucferron@chromium.org Vulkan: Keep unused uniforms list to fix glslang issues
2018-06-08 lfy@google.com GLES1: Texture environment API
2018-06-08 fjhenigman@chromium.org Vertex format support in AttributeLayoutTest.
2018-06-08 thomasanderson@chromium.org Remove manual references to exe_and_shlib_deps
2018-06-08 geofflang@chromium.org Hold RendererGL objects with a shared_ptr.
2018-06-08 oetuaho@nvidia.com Always use custom float parsing in GLSL


Created with:
  gclient setdep -r src/third_party/angle@f15f886

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:845700 , chromium:849245 
TBR=geofflang@chromium.org

Change-Id: I84d8cf1625fd301c5807f308a57a2a80f2783e04
Reviewed-on: https://chromium-review.googlesource.com/1093429
Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#565829}
[modify] https://crrev.com/3e27f4c7cc547d27a75eeeb28579581bebee61b0/DEPS

Comment 18 by bugdroid1@chromium.org, Jun 12 2018

Project Member
The following revision refers to this bug:
  https://webrtc.googlesource.com/src.git/+/9614a313b8363fdf1d7b0cf27f747fbe89cf1f25

commit 9614a313b8363fdf1d7b0cf27f747fbe89cf1f25
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Tue Jun 12 06:07:16 2018

Remove manual references to exe_and_shlib_deps

After [1], a manual dependency on exe_and_shlib_deps is no longer necessary
since it's automatically added.  This CL removes all remaining manual references
to exe_and_shlib_deps.

[1] https://chromium.googlesource.com/chromium/src.git/+/d7ed1f0a9c28c932fddc834ca5de44f28266c7f5

BUG= chromium:845700 
R=tommi@webrtc.org

Change-Id: I92942bc08c0e34c5c39df3c71f56f89476f8d95c
Reviewed-on: https://webrtc-review.googlesource.com/83061
Commit-Queue: Tommi <tommi@webrtc.org>
Reviewed-by: Tommi <tommi@webrtc.org>
Cr-Commit-Position: refs/heads/master@{#23573}
[modify] https://crrev.com/9614a313b8363fdf1d7b0cf27f747fbe89cf1f25/rtc_tools/BUILD.gn
[modify] https://crrev.com/9614a313b8363fdf1d7b0cf27f747fbe89cf1f25/webrtc.gni

Comment 19 by bugdroid1@chromium.org, Jun 12 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a947f626e8400d52cf797556b949ee23eb8494a3

commit a947f626e8400d52cf797556b949ee23eb8494a3
Author: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Tue Jun 12 10:02:15 2018

Roll src/third_party/webrtc 6c789e08d522..9614a313b836 (2 commits)

https://webrtc.googlesource.com/src.git/+log/6c789e08d522..9614a313b836


git log 6c789e08d522..9614a313b836 --date=short --no-merges --format='%ad %ae %s'
2018-06-12 thomasanderson@chromium.org Remove manual references to exe_and_shlib_deps
2018-06-12 qingsi@google.com Pass the RtcEventLog instance to ICE via JsepTransportController.


Created with:
  gclient setdep -r src/third_party/webrtc@9614a313b836

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG= chromium:845700 
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Idbad5d10fd3cd0e745af105e4267b8cf5098de94
Reviewed-on: https://chromium-review.googlesource.com/1096706
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#566368}
[modify] https://crrev.com/a947f626e8400d52cf797556b949ee23eb8494a3/DEPS

Comment 20 by bugdroid1@chromium.org, Jun 15 2018

Project Member
The following revision refers to this bug:
  https://swiftshader.googlesource.com/SwiftShader.git/+/a62cf68ca10c0a61ef203bb171f6239d15ead951

commit a62cf68ca10c0a61ef203bb171f6239d15ead951
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Fri Jun 15 02:32:50 2018

Remove manual references to exe_and_shlib_deps

After [1], a manual dependency on exe_and_shlib_deps is no longer necessary
since it's automatically added.  This CL removes all remaining manual references
to exe_and_shlib_deps.

[1] https://chromium.googlesource.com/chromium/src.git/+/d7ed1f0a9c28c932fddc834ca5de44f28266c7f5

BUG= chromium:845700 
R=capn

Change-Id: I20a88d716ed4cddd55047529f87267b5383366bc
Reviewed-on: https://swiftshader-review.googlesource.com/19348
Reviewed-by: Nicolas Capens <nicolascapens@google.com>
Tested-by: Tom Anderson <thomasanderson@google.com>

[modify] https://crrev.com/a62cf68ca10c0a61ef203bb171f6239d15ead951/src/OpenGL/libEGL/BUILD.gn
[modify] https://crrev.com/a62cf68ca10c0a61ef203bb171f6239d15ead951/src/OpenGL/libGLESv2/BUILD.gn

Comment 21 by bugdroid1@chromium.org, Jun 15 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/libyuv/libyuv.git/+/780cdfed4eb271839d68bac9a91ffeae6083db76

commit 780cdfed4eb271839d68bac9a91ffeae6083db76
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Fri Jun 15 22:07:38 2018

Remove manual references to exe_and_shlib_deps

After [1], a manual dependency on exe_and_shlib_deps is no longer necessary
since it's automatically added.  This CL removes all remaining manual references
to exe_and_shlib_deps.

[1] https://chromium.googlesource.com/chromium/src.git/+/d7ed1f0a9c28c932fddc834ca5de44f28266c7f5

BUG= chromium:845700 
R=fbarchard

Change-Id: I01ade690f3f098599ec271a1e82ec34c573e21d7
Reviewed-on: https://chromium-review.googlesource.com/1102100
Reviewed-by: Frank Barchard <fbarchard@chromium.org>

[modify] https://crrev.com/780cdfed4eb271839d68bac9a91ffeae6083db76/BUILD.gn

Comment 22 by bugdroid1@chromium.org, Jun 16 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/083b6f261561e534a5f68c6477cef6c0b64ea710

commit 083b6f261561e534a5f68c6477cef6c0b64ea710
Author: Nicolas Capens <capn@chromium.org>
Date: Sat Jun 16 15:51:53 2018

Roll SwiftShader 88482c3..700a1a6

https://swiftshader.googlesource.com/SwiftShader.git/+log/88482c3..700a1a6

BUG= chromium:845700 ,  chromium:852641 ,  chromium:851707 

TBR=kbr@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng;luci.chromium.try:android_optional_gpu_tests_rel

Change-Id: Ic36ddc1988cd83970a4a53b52a1ce1b229d17137
Reviewed-on: https://chromium-review.googlesource.com/1102886
Commit-Queue: Nicolas Capens <capn@chromium.org>
Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567894}
[modify] https://crrev.com/083b6f261561e534a5f68c6477cef6c0b64ea710/DEPS

Comment 23 by bugdroid1@chromium.org, Jun 16 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3a2fd4ce7fefe8dea3c5607982856f91c69ec8c

commit f3a2fd4ce7fefe8dea3c5607982856f91c69ec8c
Author: Dirk Pranke <dpranke@chromium.org>
Date: Sat Jun 16 21:30:31 2018

Revert "Roll SwiftShader 88482c3..700a1a6"

This reverts commit 083b6f261561e534a5f68c6477cef6c0b64ea710.

Reason for revert: I think this is causing crashes on Mac 10.13 (dbg). See https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29/3362.

Original change's description:
> Roll SwiftShader 88482c3..700a1a6
> 
> https://swiftshader.googlesource.com/SwiftShader.git/+log/88482c3..700a1a6
> 
> BUG= chromium:845700 ,  chromium:852641 ,  chromium:851707 
> 
> TBR=kbr@chromium.org
> 
> TEST=bots
> 
> CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng;luci.chromium.try:android_optional_gpu_tests_rel
> 
> Change-Id: Ic36ddc1988cd83970a4a53b52a1ce1b229d17137
> Reviewed-on: https://chromium-review.googlesource.com/1102886
> Commit-Queue: Nicolas Capens <capn@chromium.org>
> Reviewed-by: Alexis Hétu <sugoi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#567894}

TBR=sugoi@chromium.org,capn@chromium.org

Change-Id: I96e96329f4de1581ca11fca443fa943e58ce8f4c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  chromium:845700 ,  chromium:852641 ,  chromium:851707 
Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng;luci.chromium.try:android_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/1103398
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567898}
[modify] https://crrev.com/f3a2fd4ce7fefe8dea3c5607982856f91c69ec8c/DEPS

Comment 24 by bugdroid1@chromium.org, Jun 19 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/efddbaa1da8640c7556477a5040462ddd6f2bb69

commit efddbaa1da8640c7556477a5040462ddd6f2bb69
Author: Alexis Hetu <sugoi@google.com>
Date: Tue Jun 19 01:01:03 2018

Roll SwiftShader 88482c3..1fa2067

https://swiftshader.googlesource.com/SwiftShader.git/+log/88482c3..1fa2067

BUG= chromium:845700   chromium:852641   chromium:851707 

TBR=kbr@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng;luci.chromium.try:android_optional_gpu_tests_rel

Change-Id: I86645f0e44657bd864a347728994e469b789bc75
Reviewed-on: https://chromium-review.googlesource.com/1104986
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568271}
[modify] https://crrev.com/efddbaa1da8640c7556477a5040462ddd6f2bb69/DEPS

Comment 25 by bugdroid1@chromium.org, Jun 20 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a1398397f433b18f39916727d50f849a3e6c2b95

commit a1398397f433b18f39916727d50f849a3e6c2b95
Author: Frank Barchard <fbarchard@google.com>
Date: Wed Jun 20 00:56:25 2018

Roll src/third_party/libyuv/ 780cdfed4..bc383e76d (1 commit)

https://chromium.googlesource.com/libyuv/libyuv.git/+log/780cdfed4eb2..bc383e76d631

$ git log 780cdfed4..bc383e76d --date=short --no-merges --format='%ad %ae %s'
2018-06-15 thomasanderson Update DEPS necessary to green-up CQ bots

Created with:
  roll-dep src/third_party/libyuv

Bug:  chromium:845700 , libyuv:799 
Change-Id: I6f5b0d56dd9c057e3a341a069e121e7b7d09b4dc
Reviewed-on: https://chromium-review.googlesource.com/1106968
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Frank Barchard <fbarchard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568671}
[modify] https://crrev.com/a1398397f433b18f39916727d50f849a3e6c2b95/DEPS

Comment 26 by fbarchard@chromium.org, Jun 20 2018

Fixed for libyuv.  Thanks Thomas... looks better without those deps.

Comment 27 by bugdroid1@chromium.org, Jul 2 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/153acbd707c080919d82af77efc800b8891009bd

commit 153acbd707c080919d82af77efc800b8891009bd
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Mon Jul 02 19:19:04 2018

Remove manual reference to exe_and_shlib_deps

After [1], a manual dependency on exe_and_shlib_deps is no longer necessary
since it's automatically added.  This CL removes all remaining manual references
to exe_and_shlib_deps.

[1] https://chromium.googlesource.com/chromium/src.git/+/d7ed1f0a9c28c932fddc834ca5de44f28266c7f5

BUG= chromium:845700 
R=sullivan

Change-Id: I9967b21ea309add5a366ee43b07396d22250b14d
Reviewed-on: https://chromium-review.googlesource.com/1123065
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>

[modify] https://crrev.com/153acbd707c080919d82af77efc800b8891009bd/telemetry/BUILD.gn

Comment 28 by bugdroid1@chromium.org, Jul 2 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ebc957362cf84376f8059a42fe8ced87cb685b30

commit ebc957362cf84376f8059a42fe8ced87cb685b30
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Mon Jul 02 20:42:55 2018

Roll src/third_party/catapult a14d6738e1fb..153acbd707c0 (1 commits)

https://chromium.googlesource.com/catapult.git/+log/a14d6738e1fb..153acbd707c0


git log a14d6738e1fb..153acbd707c0 --date=short --no-merges --format='%ad %ae %s'
2018-07-02 thomasanderson@chromium.org Remove manual reference to exe_and_shlib_deps


Created with:
  gclient setdep -r src/third_party/catapult@153acbd707c0

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:845700 
TBR=sullivan@chromium.org

Change-Id: If682edec4b9cced3c22128c14c89fde52554cc11
Reviewed-on: https://chromium-review.googlesource.com/1123136
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#571988}
[modify] https://crrev.com/ebc957362cf84376f8059a42fe8ced87cb685b30/DEPS

Comment 29 by bugdroid1@chromium.org, Jul 9 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb7bfaf78b6ef7cda884ef795b0d527807ec9f47

commit cb7bfaf78b6ef7cda884ef795b0d527807ec9f47
Author: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Mon Jul 09 21:29:22 2018

Roll src/third_party/perfetto 916c76140064..5f2d58f235b1 (2 commits)

https://android.googlesource.com/platform/external/perfetto.git/+log/916c76140064..5f2d58f235b1


git log 916c76140064..5f2d58f235b1 --date=short --no-merges --format='%ad %ae %s'
2018-07-09 treehugger-gerrit@google.com Merge "Remove manual reference to exe_and_shlib_deps"
2018-07-02 thomasanderson@chromium.org Remove manual reference to exe_and_shlib_deps


Created with:
  gclient setdep -r src/third_party/perfetto@5f2d58f235b1

The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:845700 
TBR=perfetto-bugs@google.com

Change-Id: Iaf9846fbb79fc0c82c07cbf875147fef14f36374
Reviewed-on: https://chromium-review.googlesource.com/1129880
Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#573450}
[modify] https://crrev.com/cb7bfaf78b6ef7cda884ef795b0d527807ec9f47/DEPS

Comment 30 by bugdroid1@chromium.org, Jul 17 2018

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc509a702481e18cc6f7cba9fd438f4309a5c99e

commit bc509a702481e18cc6f7cba9fd438f4309a5c99e
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Tue Jul 17 01:46:41 2018

Finish removing refrences to exe_and_shlib_deps

This CL removes the last remaining references to exe_and_shlib_deps (3 were
added since my first CL that removed them).

In addition, I also rename the group to something ridiculously long:
executable_and_loadable_module_and_shared_library_deps.  This is because we
cannot set visibility=["//build/config:executable", ...] because those are
templates.  Renaming ensures folks who were used to adding the dependency no
longer add it, and makes sure that no third party projects have any references
either (I checked and they don't, but this is just to make sure).  The long name
discourages adding the dep manually.

BUG= 845700 
TBR=dpranke

Change-Id: I1e8861b1045716f488fdbc90b4b8d0ec95abc0a6
Reviewed-on: https://chromium-review.googlesource.com/1132557
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575518}
[modify] https://crrev.com/bc509a702481e18cc6f7cba9fd438f4309a5c99e/build/config/BUILD.gn
[modify] https://crrev.com/bc509a702481e18cc6f7cba9fd438f4309a5c99e/build/config/BUILDCONFIG.gn
[modify] https://crrev.com/bc509a702481e18cc6f7cba9fd438f4309a5c99e/chrome_elf/BUILD.gn
[modify] https://crrev.com/bc509a702481e18cc6f7cba9fd438f4309a5c99e/chromecast/BUILD.gn
[modify] https://crrev.com/bc509a702481e18cc6f7cba9fd438f4309a5c99e/components/url_formatter/top_domains/BUILD.gn

Comment 31 by thomasanderson@chromium.org, Jul 17 2018

Status: Fixed (was: Started)

Sign in to add a comment