New issue
Advanced search Search tips

Issue 845686 link

Starred by 2 users
Status: Fixed
Owner:
sammiequon@chromium.org
Closed: Jun 2018
Cc:
tbuck...@chromium.org
jdufault@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Using enter to confirm PIN in settings triggers the wrong button, which causes the PIN dialog to reappear.

Project Member Reported by jdufault@chromium.org, May 22 2018 
Using enter to confirm PIN in settings triggers the wrong button, which causes the PIN dialog to reappear. Using the mouse to press confirm works as expected.

This can be seen by adding some tracing to onConfigurePin_ [1].

This is in chrome://settings/lockScreen.

1: https://cs.chromium.org/chromium/src/chrome/browser/resources/settings/people_page/lock_screen.js?l=297-301&rcl=3d724c12d4e27a82499acdb212c79a0cce7ff1c9
Project Member

Comment 1 by bugdroid1@chromium.org, Jun 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb902c630c7fc29901728ef1ca9467c6990f7853

commit fb902c630c7fc29901728ef1ca9467c6990f7853
Author: Sammie Quon <sammiequon@google.com>
Date: Mon Jun 18 22:06:59 2018

settings: Prevent hitting enter on setup PIN dialog to reopen it.

Using the approach suggested in [1].

[1]: https://chromium-review.googlesource.com/c/chromium/src/+/1100235

Test: manual
Bug:  845686 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I66a8cb687463c30ba2414c29245797338a49d60f
Reviewed-on: https://chromium-review.googlesource.com/1103280
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568190}
[modify] https://crrev.com/fb902c630c7fc29901728ef1ca9467c6990f7853/chrome/browser/resources/settings/people_page/lock_screen.html

Comment 2 by dpa...@chromium.org, Jun 26 2018

Status: Started (was: Untriaged)
Is this fixed?

Comment 3 by sammiequon@chromium.org, Jun 26 2018

Status: Fixed (was: Started)
re #2: yes
►

Sign in to add a comment